ltp.lists.linux.it archive mirror
 help / color / mirror / Atom feed
* [LTP] [PATCH] doc/shell-test-api.txt: Don't include tst_test.sh twice
@ 2023-05-18  7:40 Yang Xu
  2023-05-18 20:37 ` Petr Vorel
  0 siblings, 1 reply; 3+ messages in thread
From: Yang Xu @ 2023-05-18  7:40 UTC (permalink / raw)
  To: ltp

Usually, we include tst_test.sh on the end of a case and on the
top of tst_run. Some the beginning tst_test.sh is useless and remove.

Signed-off-by: Yang Xu <xuyang2018.jy@fujitsu.com>
---
 doc/shell-test-api.txt | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/doc/shell-test-api.txt b/doc/shell-test-api.txt
index e5c918660..dde170644 100644
--- a/doc/shell-test-api.txt
+++ b/doc/shell-test-api.txt
@@ -26,7 +26,6 @@ WARNING: All identifiers starting with 'TST_' or 'tst_' are reserved for the
 # This is a basic test for true shell builtin
 
 TST_TESTFUNC=do_test
-. tst_test.sh
 
 do_test()
 {
@@ -79,7 +78,6 @@ not trigger calling it.
 
 TST_TESTFUNC=test
 TST_CNT=2
-. tst_test.sh
 
 test1()
 {
@@ -110,7 +108,6 @@ found they are executed one by one. The test number is passed to it in the '$1'.
 
 TST_TESTFUNC=do_test
 TST_CNT=2
-. tst_test.sh
 
 do_test()
 {
@@ -141,7 +138,6 @@ to it in the '$1'.
 TST_TESTFUNC=do_test
 TST_TEST_DATA="foo:bar:d dd"
 TST_TEST_DATA_IFS=":"
-. tst_test.sh
 
 do_test()
 {
@@ -168,7 +164,6 @@ It's possible to pass data for function with '$TST_TEST_DATA'. Optional
 TST_TESTFUNC=do_test
 TST_CNT=2
 TST_TEST_DATA="foo bar"
-. tst_test.sh
 
 do_test()
 {
@@ -285,7 +280,6 @@ as it doesn't exit (it issues 'tst_res TCONF'). Expected usage is:
 #!/bin/sh
 
 TST_TESTFUNC=do_test
-. tst_test.sh
 
 do_test()
 {
@@ -325,8 +319,6 @@ TST_USAGE=usage
 TST_PARSE_ARGS=parse_args
 TST_TESTFUNC=do_test
 
-. tst_test.sh
-
 ALTERNATIVE=0
 MODE="foo"
 
@@ -378,8 +370,6 @@ TST_POS_ARGS=3
 TST_USAGE=usage
 TST_TESTFUNC=do_test
 
-. tst_test.sh
-
 usage()
 {
 	cat << EOF
-- 
2.39.1


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [LTP] [PATCH] doc/shell-test-api.txt: Don't include tst_test.sh twice
  2023-05-18  7:40 [LTP] [PATCH] doc/shell-test-api.txt: Don't include tst_test.sh twice Yang Xu
@ 2023-05-18 20:37 ` Petr Vorel
  2023-05-19  1:33   ` Yang Xu (Fujitsu)
  0 siblings, 1 reply; 3+ messages in thread
From: Petr Vorel @ 2023-05-18 20:37 UTC (permalink / raw)
  To: Yang Xu; +Cc: ltp

Hi Xu,

> Usually, we include tst_test.sh on the end of a case and on the
> top of tst_run. Some the beginning tst_test.sh is useless and remove.

Thanks a lot for fixing my error in 968bdc1 ("doc: Update shell API examples"), 
which was supposed to update doc to 04021637f ("tst_test.sh: Cleanup getopts usage").

I dared to slightly change your commit message and merged.

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [LTP] [PATCH] doc/shell-test-api.txt: Don't include tst_test.sh twice
  2023-05-18 20:37 ` Petr Vorel
@ 2023-05-19  1:33   ` Yang Xu (Fujitsu)
  0 siblings, 0 replies; 3+ messages in thread
From: Yang Xu (Fujitsu) @ 2023-05-19  1:33 UTC (permalink / raw)
  To: Petr Vorel; +Cc: ltp

Hi Petr

> Hi Xu,
> 
>> Usually, we include tst_test.sh on the end of a case and on the
>> top of tst_run. Some the beginning tst_test.sh is useless and remove.
> 
> Thanks a lot for fixing my error in 968bdc1 ("doc: Update shell API examples"),
> which was supposed to update doc to 04021637f ("tst_test.sh: Cleanup getopts usage").
> 
> I dared to slightly change your commit message and merged.

I have seen this modified commit message, LGTM, thanks.

Best Regards
Yang Xu
> 
> Kind regards,
> Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-05-19  1:33 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-18  7:40 [LTP] [PATCH] doc/shell-test-api.txt: Don't include tst_test.sh twice Yang Xu
2023-05-18 20:37 ` Petr Vorel
2023-05-19  1:33   ` Yang Xu (Fujitsu)

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).