From: Martin Doucha <mdoucha@suse.cz>
To: Petr Vorel <pvorel@suse.cz>
Cc: ltp@lists.linux.it, Richard Palethorpe <rpalethorpe@suse.com>
Subject: Re: [LTP] [PATCH v4 4/9] tst_supported_fs: Support skip list when query single fs
Date: Fri, 9 Sep 2022 16:39:08 +0200 [thread overview]
Message-ID: <5e01e854-7cc6-7b08-d1f8-7f0709fbc07d@suse.cz> (raw)
In-Reply-To: <YxtMFw25BfJaEsji@pevik>
On 09. 09. 22 16:22, Petr Vorel wrote:
> OK, this is not in v5. I don't mind to send v6 on Monday, if we agree this
> is wanted. Implementation detail: should I use for -2 and -1 for these two values?
> (code < 0 would be error, code > 0 would be OK, 0 itself skipped)
One more thing, the skiplist check should be done before availability
check. It's faster and it'll save you work when you're trying to fix
tests that shouldn't be skipped.
--
Martin Doucha mdoucha@suse.cz
QA Engineer for Software Maintenance
SUSE LINUX, s.r.o.
CORSO IIa
Krizikova 148/34
186 00 Prague 8
Czech Republic
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-09-09 14:39 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-02 13:37 [LTP] [PATCH v4 0/9] shell: df01.sh: $TST_ALL_FILESYSTEMS (.all_filesystems) Petr Vorel
2022-09-02 13:37 ` [LTP] [PATCH v4 1/9] shell: Print mount command in tst_mount() Petr Vorel
2022-09-02 13:37 ` [LTP] [PATCH v4 2/9] shell API/tests: Require root for TST_{FORMAT, MOUNT}_DEVICE Petr Vorel
2022-09-02 13:37 ` [LTP] [PATCH v4 3/9] tst_supported_fs: Implement skip list Petr Vorel
2022-09-09 9:40 ` Cyril Hrubis
2022-09-09 9:41 ` Petr Vorel
2022-09-09 9:47 ` Petr Vorel
2022-09-09 10:02 ` Petr Vorel
2022-09-02 13:37 ` [LTP] [PATCH v4 4/9] tst_supported_fs: Support skip list when query single fs Petr Vorel
2022-09-09 9:43 ` Cyril Hrubis
2022-09-09 10:55 ` Petr Vorel
2022-09-09 11:16 ` Cyril Hrubis
2022-09-09 11:33 ` Petr Vorel
2022-09-09 14:15 ` Martin Doucha
2022-09-09 14:22 ` Petr Vorel
2022-09-09 14:39 ` Martin Doucha [this message]
2022-09-09 14:47 ` Petr Vorel
2022-09-09 14:49 ` Martin Doucha
2022-09-12 5:40 ` Petr Vorel
2022-09-02 13:37 ` [LTP] [PATCH v4 5/9] shell: Add $TST_SKIP_FILESYSTEMS + tests Petr Vorel
2022-09-02 22:14 ` Petr Vorel
2022-09-02 13:37 ` [LTP] [PATCH v4 6/9] tst_test.sh: Introduce TST_FS_TYPE_FUSE Petr Vorel
2022-09-02 13:37 ` [LTP] [PATCH v4 7/9] tst_test.sh: Add $TST_ALL_FILESYSTEMS Petr Vorel
2022-09-02 13:37 ` [LTP] [PATCH v4 8/9] shell: Add test for TST_ALL_FILESYSTEMS=1 Petr Vorel
2022-09-02 13:37 ` [LTP] [PATCH v4 9/9] df01.sh: Convert to TST_ALL_FILESYSTEMS=1 Petr Vorel
2022-09-05 6:47 ` [LTP] [PATCH v4 0/9] shell: df01.sh: $TST_ALL_FILESYSTEMS (.all_filesystems) Li Wang
2022-09-05 7:04 ` Petr Vorel
2022-09-05 7:35 ` Li Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e01e854-7cc6-7b08-d1f8-7f0709fbc07d@suse.cz \
--to=mdoucha@suse.cz \
--cc=ltp@lists.linux.it \
--cc=pvorel@suse.cz \
--cc=rpalethorpe@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).