From: Cyril Hrubis <chrubis@suse.cz>
To: Petr Vorel <pvorel@suse.cz>
Cc: Richard Palethorpe <rpalethorpe@suse.com>, ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v4 4/9] tst_supported_fs: Support skip list when query single fs
Date: Fri, 9 Sep 2022 11:43:43 +0200 [thread overview]
Message-ID: <YxsKz9j1mVHIhcfw@yuki> (raw)
In-Reply-To: <20220902133710.1785-5-pvorel@suse.cz>
Hi!
> Acked-by: Richard Palethorpe <rpalethorpe@suse.com>
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
> include/tst_fs.h | 10 ++++++++++
> lib/tst_supported_fs_types.c | 18 ++++++++++++++++++
> testcases/lib/tst_supported_fs.c | 2 +-
> 3 files changed, 29 insertions(+), 1 deletion(-)
>
> diff --git a/include/tst_fs.h b/include/tst_fs.h
> index cc6d9b547..e399aef54 100644
> --- a/include/tst_fs.h
> +++ b/include/tst_fs.h
> @@ -183,6 +183,16 @@ enum tst_fs_impl {
> */
> enum tst_fs_impl tst_fs_is_supported(const char *fs_type);
>
> +/*
> + * Check filesystem support (@see tst_fs_is_supported()), but consider also
> + * filesystems to skip.
> + *
> + * @fs_type A filesystem name to check the support for.
> + * @skiplist A NULL terminated array of filesystems to skip.
> + */
> +enum tst_fs_impl tst_fs_is_supported_skiplist(const char *fs_type, const char
> + *const *skiplist);
> +
> /*
> * Returns NULL-terminated array of kernel-supported filesystems.
> *
> diff --git a/lib/tst_supported_fs_types.c b/lib/tst_supported_fs_types.c
> index 9726d193a..8c9379c1b 100644
> --- a/lib/tst_supported_fs_types.c
> +++ b/lib/tst_supported_fs_types.c
> @@ -134,6 +134,24 @@ enum tst_fs_impl tst_fs_is_supported(const char *fs_type)
> return TST_FS_UNSUPPORTED;
> }
>
> +enum tst_fs_impl tst_fs_is_supported_skiplist(const char *fs_type, const char
> + *const *skiplist)
> +{
> + int ret;
> +
> + ret = tst_fs_is_supported(fs_type);
> +
> + if (!ret)
> + return ret;
> +
> + if (tst_fs_in_skiplist(fs_type, skiplist)) {
> + tst_brk(TCONF, "%s is not supported by the test",
> + fs_type);
I would expect to return TST_FS_UNSUPPORTED here. It's a bit hacky
solution to exit a library call with tst_brk(TCONF, "");
> + }
> +
> + return ret;
> +}
> +
> const char **tst_get_supported_fs_types(const char *const *skiplist)
> {
> unsigned int i, j = 0;
> diff --git a/testcases/lib/tst_supported_fs.c b/testcases/lib/tst_supported_fs.c
> index 87be2b759..75945c809 100644
> --- a/testcases/lib/tst_supported_fs.c
> +++ b/testcases/lib/tst_supported_fs.c
> @@ -70,7 +70,7 @@ int main(int argc, char *argv[])
> }
>
> if (optind < argc)
> - return !tst_fs_is_supported(argv[optind]);
> + return !tst_fs_is_supported_skiplist(argv[optind], (const char * const*)skiplist);
>
> filesystems = tst_get_supported_fs_types((const char * const*)skiplist);
> for (i = 0; filesystems[i]; i++)
> --
> 2.37.2
>
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-09-09 9:42 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-02 13:37 [LTP] [PATCH v4 0/9] shell: df01.sh: $TST_ALL_FILESYSTEMS (.all_filesystems) Petr Vorel
2022-09-02 13:37 ` [LTP] [PATCH v4 1/9] shell: Print mount command in tst_mount() Petr Vorel
2022-09-02 13:37 ` [LTP] [PATCH v4 2/9] shell API/tests: Require root for TST_{FORMAT, MOUNT}_DEVICE Petr Vorel
2022-09-02 13:37 ` [LTP] [PATCH v4 3/9] tst_supported_fs: Implement skip list Petr Vorel
2022-09-09 9:40 ` Cyril Hrubis
2022-09-09 9:41 ` Petr Vorel
2022-09-09 9:47 ` Petr Vorel
2022-09-09 10:02 ` Petr Vorel
2022-09-02 13:37 ` [LTP] [PATCH v4 4/9] tst_supported_fs: Support skip list when query single fs Petr Vorel
2022-09-09 9:43 ` Cyril Hrubis [this message]
2022-09-09 10:55 ` Petr Vorel
2022-09-09 11:16 ` Cyril Hrubis
2022-09-09 11:33 ` Petr Vorel
2022-09-09 14:15 ` Martin Doucha
2022-09-09 14:22 ` Petr Vorel
2022-09-09 14:39 ` Martin Doucha
2022-09-09 14:47 ` Petr Vorel
2022-09-09 14:49 ` Martin Doucha
2022-09-12 5:40 ` Petr Vorel
2022-09-02 13:37 ` [LTP] [PATCH v4 5/9] shell: Add $TST_SKIP_FILESYSTEMS + tests Petr Vorel
2022-09-02 22:14 ` Petr Vorel
2022-09-02 13:37 ` [LTP] [PATCH v4 6/9] tst_test.sh: Introduce TST_FS_TYPE_FUSE Petr Vorel
2022-09-02 13:37 ` [LTP] [PATCH v4 7/9] tst_test.sh: Add $TST_ALL_FILESYSTEMS Petr Vorel
2022-09-02 13:37 ` [LTP] [PATCH v4 8/9] shell: Add test for TST_ALL_FILESYSTEMS=1 Petr Vorel
2022-09-02 13:37 ` [LTP] [PATCH v4 9/9] df01.sh: Convert to TST_ALL_FILESYSTEMS=1 Petr Vorel
2022-09-05 6:47 ` [LTP] [PATCH v4 0/9] shell: df01.sh: $TST_ALL_FILESYSTEMS (.all_filesystems) Li Wang
2022-09-05 7:04 ` Petr Vorel
2022-09-05 7:35 ` Li Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YxsKz9j1mVHIhcfw@yuki \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
--cc=pvorel@suse.cz \
--cc=rpalethorpe@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).