From: Amir Goldstein <amir73il@gmail.com>
To: Gabriel Krisman Bertazi <krisman@collabora.com>
Cc: kernel@collabora.com, Khazhismel Kumykov <khazhy@google.com>,
Matthew Bobrowski <repnop@google.com>, Jan Kara <jack@suse.com>,
Ext4 <linux-ext4@vger.kernel.org>, LTP List <ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH v2 08/10] syscalls/fanotify20: Test event after filesystem abort
Date: Wed, 27 Oct 2021 12:56:14 +0300 [thread overview]
Message-ID: <CAOQ4uxh=Wmso0O6aXsE2Y3JAQte5Q0NYaUKJWLvLUuY_u-a__A@mail.gmail.com> (raw)
In-Reply-To: <20211026184239.151156-9-krisman@collabora.com>
On Tue, Oct 26, 2021 at 9:44 PM Gabriel Krisman Bertazi
<krisman@collabora.com> wrote:
>
> This test monitors the error triggered after a file system abort. It
> works by forcing a remount with the option "abort". This is an error
> not related to a file so it is reported against the superblock with a
> zero size fh.
>
> Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.com>
> ---
> testcases/kernel/syscalls/fanotify/fanotify20.c | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/testcases/kernel/syscalls/fanotify/fanotify20.c b/testcases/kernel/syscalls/fanotify/fanotify20.c
> index 298bb303a810..5c5ee3c6fb74 100644
> --- a/testcases/kernel/syscalls/fanotify/fanotify20.c
> +++ b/testcases/kernel/syscalls/fanotify/fanotify20.c
> @@ -57,6 +57,12 @@ static void do_debugfs_request(const char *dev, char *request)
> SAFE_CMD(cmd, NULL, NULL);
> }
>
> +static void trigger_fs_abort(void)
> +{
> + SAFE_MOUNT(tst_device->dev, MOUNT_PATH, tst_device->fs_type,
> + MS_REMOUNT|MS_RDONLY, "abort");
> +}
> +
> static struct test_case {
> char *name;
> int error;
> @@ -64,6 +70,13 @@ static struct test_case {
> struct fanotify_fid_t *fid;
> void (*trigger_error)(void);
> } testcases[] = {
> + {
> + .name = "Trigger abort",
> + .trigger_error = &trigger_fs_abort,
> + .error_count = 1,
> + .error = ESHUTDOWN,
> + .fid = &null_fid,
> + },
> };
>
I suppose you did not try to run fanotify20 -i 10 ...?
I guess you will need to end the setup() stage with unmounted fs and perform:
mount; fanotify_init; fanotify_mark; at beginning of do_test()
finishing do_test() with closing fanotify fd and unmount.
I never checked it there are pre-test/post-test callbacks available in LTP,
but setup/clean are called at start/end of test loop.
Thanks,
Amir.
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2021-10-27 9:56 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-26 18:42 [LTP] [PATCH v2 00/10] Test the new fanotify FAN_FS_ERROR event Gabriel Krisman Bertazi
2021-10-26 18:42 ` [LTP] [PATCH v2 01/10] syscalls: fanotify: Add macro to require specific mark types Gabriel Krisman Bertazi
2021-10-27 6:10 ` Amir Goldstein
2021-10-26 18:42 ` [LTP] [PATCH v2 02/10] syscalls: fanotify: Add macro to require specific events Gabriel Krisman Bertazi
2021-10-27 6:23 ` Amir Goldstein
2021-10-26 18:42 ` [LTP] [PATCH v2 03/10] syscalls/fanotify20: Introduce helpers for FAN_FS_ERROR test Gabriel Krisman Bertazi
2021-10-27 6:33 ` Amir Goldstein
2021-10-26 18:42 ` [LTP] [PATCH v2 04/10] syscalls/fanotify20: Validate the generic error info Gabriel Krisman Bertazi
2021-10-27 6:43 ` Amir Goldstein
2021-10-27 10:19 ` Amir Goldstein
2021-10-26 18:42 ` [LTP] [PATCH v2 05/10] syscalls/fanotify20: Validate incoming FID in FAN_FS_ERROR Gabriel Krisman Bertazi
2021-10-27 6:48 ` Amir Goldstein
2021-10-26 18:42 ` [LTP] [PATCH v2 06/10] syscalls/fanotify20: Support submission of debugfs commands Gabriel Krisman Bertazi
2021-10-27 6:49 ` Amir Goldstein
2021-10-26 18:42 ` [LTP] [PATCH v2 07/10] syscalls/fanotify20: Create a corrupted file Gabriel Krisman Bertazi
2021-10-27 6:51 ` Amir Goldstein
2021-10-26 18:42 ` [LTP] [PATCH v2 08/10] syscalls/fanotify20: Test event after filesystem abort Gabriel Krisman Bertazi
2021-10-27 9:56 ` Amir Goldstein [this message]
2021-10-26 18:42 ` [LTP] [PATCH v2 09/10] syscalls/fanotify20: Test file event with broken inode Gabriel Krisman Bertazi
2021-10-27 9:57 ` Amir Goldstein
2021-10-26 18:42 ` [LTP] [PATCH v2 10/10] syscalls/fanotify20: Test capture of multiple errors Gabriel Krisman Bertazi
2021-10-27 10:00 ` Amir Goldstein
2021-10-29 15:03 ` Gabriel Krisman Bertazi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOQ4uxh=Wmso0O6aXsE2Y3JAQte5Q0NYaUKJWLvLUuY_u-a__A@mail.gmail.com' \
--to=amir73il@gmail.com \
--cc=jack@suse.com \
--cc=kernel@collabora.com \
--cc=khazhy@google.com \
--cc=krisman@collabora.com \
--cc=linux-ext4@vger.kernel.org \
--cc=ltp@lists.linux.it \
--cc=repnop@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).