From: Petr Vorel <pvorel@suse.cz>
To: Li Wang <liwang@redhat.com>
Cc: LTP List <ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH 1/1] utime03.c: Fix filesystem name
Date: Mon, 17 Jan 2022 10:04:10 +0100 [thread overview]
Message-ID: <YeUxCq4rsLX98E3d@pevik> (raw)
In-Reply-To: <CAEemH2cMpFUz1nzq6DDfe+S-bYam3fYvb8ci=hfXHkjbfxbkeQ@mail.gmail.com>
Hi Li, Cyril,
> > > +++ b/testcases/kernel/syscalls/utime/utime03.c
> > > @@ -93,7 +93,7 @@ static struct tst_test test = {
> > > .mntpoint = MNTPOINT,
> > > .all_filesystems = 1,
> > > .skip_filesystems = (const char *const[]) {
> > > - "v9",
> > > + "9p",
> > I'm wondering does it really take effect with whatever "v9" or "9p"?
> > Because the fs_type_whitelist[] does not include any of them.
+1. Do we want to add 9p to fs_type_whitelist[]? I suppose not, because (despite
of the name containing "whitelist" it's the list of filesystems actually being
tested - this is a bit confusing to me).
> Unless removing the .all_filesystems as well otherwise, it is impossible
> has a chance to test on 9p.
Yep. I forgot that .skip_filesystems works also on single fs.
So correct entry in .skip_filesystems is kind of documentation in case of
.all_filesystems being removed. I guess we should just remove the entry.
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-01-17 9:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-14 21:00 [LTP] [PATCH 1/1] utime03.c: Fix filesystem name Petr Vorel
2022-01-17 2:23 ` Li Wang
2022-01-17 3:13 ` Li Wang
2022-01-17 9:04 ` Petr Vorel [this message]
2022-01-18 7:24 ` Li Wang
2022-01-18 9:01 ` Petr Vorel
2022-01-18 9:11 ` Li Wang
2022-01-18 10:34 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YeUxCq4rsLX98E3d@pevik \
--to=pvorel@suse.cz \
--cc=liwang@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).