From: Cyril Hrubis <chrubis@suse.cz>
To: Petr Vorel <pvorel@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [COMMITTED][PATCH 1/1] nfs05_make_tree: Restore 5 min timeout
Date: Fri, 17 Jun 2022 11:13:07 +0200 [thread overview]
Message-ID: <YqxFo1iFzHatNRIl@yuki> (raw)
In-Reply-To: <20220616162339.19322-1-pvorel@suse.cz>
Hi!
> nfs05_make_tree is a long running test. The previous default timeout 5
> min was enough after reducing runtime in 05be61cf6.
>
> But the new default 30 sec introduced in the concept of max runtime is
> definitely not enough. Restore the previous timeout 5 min.
Looking at the code this is actually a helper binary rather than a test
itself. I think that the problem here is that we mix the shell test
library and C library and the test is a mess of both with unexpected
consequencies.
I guess that it would probably implement main() in the nfs05_make_tree.c
instead as we do for the various tools in testcases/lib/*.c. That would
at least make sure that we will not break anything with changes intended
for tests and not for helper binaries as this one.
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
> testcases/network/nfs/nfs_stress/nfs05_make_tree.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/testcases/network/nfs/nfs_stress/nfs05_make_tree.c b/testcases/network/nfs/nfs_stress/nfs05_make_tree.c
> index fdc13bd5d..5456c1bf0 100644
> --- a/testcases/network/nfs/nfs_stress/nfs05_make_tree.c
> +++ b/testcases/network/nfs/nfs_stress/nfs05_make_tree.c
> @@ -215,4 +215,5 @@ static struct tst_test test = {
> .options = opts,
> .test_all = do_test,
> .setup = setup,
> + .max_runtime = 300,
> };
> --
> 2.36.1
>
>
> --
> Mailing list info: https://lists.linux.it/listinfo/ltp
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-06-17 9:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-16 16:23 [LTP] [COMMITTED][PATCH 1/1] nfs05_make_tree: Restore 5 min timeout Petr Vorel
2022-06-17 9:13 ` Cyril Hrubis [this message]
2022-06-17 13:37 ` Petr Vorel
2022-06-17 15:09 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YqxFo1iFzHatNRIl@yuki \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
--cc=pvorel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).