* [LTP] [COMMITTED][PATCH 1/1] nfs05_make_tree: Restore 5 min timeout
@ 2022-06-16 16:23 Petr Vorel
2022-06-17 9:13 ` Cyril Hrubis
0 siblings, 1 reply; 4+ messages in thread
From: Petr Vorel @ 2022-06-16 16:23 UTC (permalink / raw)
To: ltp
nfs05_make_tree is a long running test. The previous default timeout 5
min was enough after reducing runtime in 05be61cf6.
But the new default 30 sec introduced in the concept of max runtime is
definitely not enough. Restore the previous timeout 5 min.
Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
testcases/network/nfs/nfs_stress/nfs05_make_tree.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/testcases/network/nfs/nfs_stress/nfs05_make_tree.c b/testcases/network/nfs/nfs_stress/nfs05_make_tree.c
index fdc13bd5d..5456c1bf0 100644
--- a/testcases/network/nfs/nfs_stress/nfs05_make_tree.c
+++ b/testcases/network/nfs/nfs_stress/nfs05_make_tree.c
@@ -215,4 +215,5 @@ static struct tst_test test = {
.options = opts,
.test_all = do_test,
.setup = setup,
+ .max_runtime = 300,
};
--
2.36.1
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [LTP] [COMMITTED][PATCH 1/1] nfs05_make_tree: Restore 5 min timeout
2022-06-16 16:23 [LTP] [COMMITTED][PATCH 1/1] nfs05_make_tree: Restore 5 min timeout Petr Vorel
@ 2022-06-17 9:13 ` Cyril Hrubis
2022-06-17 13:37 ` Petr Vorel
0 siblings, 1 reply; 4+ messages in thread
From: Cyril Hrubis @ 2022-06-17 9:13 UTC (permalink / raw)
To: Petr Vorel; +Cc: ltp
Hi!
> nfs05_make_tree is a long running test. The previous default timeout 5
> min was enough after reducing runtime in 05be61cf6.
>
> But the new default 30 sec introduced in the concept of max runtime is
> definitely not enough. Restore the previous timeout 5 min.
Looking at the code this is actually a helper binary rather than a test
itself. I think that the problem here is that we mix the shell test
library and C library and the test is a mess of both with unexpected
consequencies.
I guess that it would probably implement main() in the nfs05_make_tree.c
instead as we do for the various tools in testcases/lib/*.c. That would
at least make sure that we will not break anything with changes intended
for tests and not for helper binaries as this one.
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
> testcases/network/nfs/nfs_stress/nfs05_make_tree.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/testcases/network/nfs/nfs_stress/nfs05_make_tree.c b/testcases/network/nfs/nfs_stress/nfs05_make_tree.c
> index fdc13bd5d..5456c1bf0 100644
> --- a/testcases/network/nfs/nfs_stress/nfs05_make_tree.c
> +++ b/testcases/network/nfs/nfs_stress/nfs05_make_tree.c
> @@ -215,4 +215,5 @@ static struct tst_test test = {
> .options = opts,
> .test_all = do_test,
> .setup = setup,
> + .max_runtime = 300,
> };
> --
> 2.36.1
>
>
> --
> Mailing list info: https://lists.linux.it/listinfo/ltp
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [LTP] [COMMITTED][PATCH 1/1] nfs05_make_tree: Restore 5 min timeout
2022-06-17 9:13 ` Cyril Hrubis
@ 2022-06-17 13:37 ` Petr Vorel
2022-06-17 15:09 ` Cyril Hrubis
0 siblings, 1 reply; 4+ messages in thread
From: Petr Vorel @ 2022-06-17 13:37 UTC (permalink / raw)
To: Cyril Hrubis; +Cc: ltp
> Hi!
> > nfs05_make_tree is a long running test. The previous default timeout 5
> > min was enough after reducing runtime in 05be61cf6.
> > But the new default 30 sec introduced in the concept of max runtime is
> > definitely not enough. Restore the previous timeout 5 min.
> Looking at the code this is actually a helper binary rather than a test
> itself. I think that the problem here is that we mix the shell test
> library and C library and the test is a mess of both with unexpected
> consequencies.
Yes.
> I guess that it would probably implement main() in the nfs05_make_tree.c
> instead as we do for the various tools in testcases/lib/*.c. That would
> at least make sure that we will not break anything with changes intended
> for tests and not for helper binaries as this one.
Helper binaries does not use LTP C API. I'd like to keep it (to have SAFE_*()),
I guess you're not against. Therefore just using TST_NO_DEFAULT_MAIN
and adding main(), right?
Kind regards,
Petr
> > Signed-off-by: Petr Vorel <pvorel@suse.cz>
> > ---
> > testcases/network/nfs/nfs_stress/nfs05_make_tree.c | 1 +
> > 1 file changed, 1 insertion(+)
> > diff --git a/testcases/network/nfs/nfs_stress/nfs05_make_tree.c b/testcases/network/nfs/nfs_stress/nfs05_make_tree.c
> > index fdc13bd5d..5456c1bf0 100644
> > --- a/testcases/network/nfs/nfs_stress/nfs05_make_tree.c
> > +++ b/testcases/network/nfs/nfs_stress/nfs05_make_tree.c
> > @@ -215,4 +215,5 @@ static struct tst_test test = {
> > .options = opts,
> > .test_all = do_test,
> > .setup = setup,
> > + .max_runtime = 300,
> > };
> > --
> > 2.36.1
> > --
> > Mailing list info: https://lists.linux.it/listinfo/ltp
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [LTP] [COMMITTED][PATCH 1/1] nfs05_make_tree: Restore 5 min timeout
2022-06-17 13:37 ` Petr Vorel
@ 2022-06-17 15:09 ` Cyril Hrubis
0 siblings, 0 replies; 4+ messages in thread
From: Cyril Hrubis @ 2022-06-17 15:09 UTC (permalink / raw)
To: Petr Vorel; +Cc: ltp
Hi!
> > I guess that it would probably implement main() in the nfs05_make_tree.c
> > instead as we do for the various tools in testcases/lib/*.c. That would
> > at least make sure that we will not break anything with changes intended
> > for tests and not for helper binaries as this one.
>
> Helper binaries does not use LTP C API. I'd like to keep it (to have SAFE_*()),
> I guess you're not against. Therefore just using TST_NO_DEFAULT_MAIN
> and adding main(), right?
I guess that would work, but I will have to double check the tst_test.c
library.
Also I'm not sure that this would be the best solution, mixing C and
shell code was always akward and maybe we can figure out how to make it
better.
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-06-17 15:07 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-16 16:23 [LTP] [COMMITTED][PATCH 1/1] nfs05_make_tree: Restore 5 min timeout Petr Vorel
2022-06-17 9:13 ` Cyril Hrubis
2022-06-17 13:37 ` Petr Vorel
2022-06-17 15:09 ` Cyril Hrubis
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).