ltp.lists.linux.it archive mirror
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: Luke Nowakowski-Krijger <luke.nowakowskikrijger@canonical.com>
Cc: Richard Palethorpe <rpalethorpe@suse.com>, ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] API/cgroup: Add rdma controller
Date: Thu, 25 Aug 2022 12:59:53 +0200	[thread overview]
Message-ID: <YwdWKb/Imzwk5F1V@pevik> (raw)
In-Reply-To: <20220824215421.90947-1-luke.nowakowskikrijger@canonical.com>

Hi Luke,

> There is a test reporting "TBROK: 'rdma' controller is unknown
> to LTP" so lets add the controller.

Out of curiosity: which test?

Reviewed-by: Petr Vorel <pvorel@suse.cz>

Kind regards,
Petr

> Signed-off-by: Luke Nowakowski-Krijger <luke.nowakowskikrijger@canonical.com>
> ---
>  lib/tst_cgroup.c | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)

> diff --git a/lib/tst_cgroup.c b/lib/tst_cgroup.c
> index 1cfd79243..1da3f0a5d 100644
> --- a/lib/tst_cgroup.c
> +++ b/lib/tst_cgroup.c
> @@ -93,9 +93,10 @@ enum cgroup_ctrl_indx {
>  	CTRL_BLKIO,
>  	CTRL_MISC,
>  	CTRL_PERFEVENT,
> -	CTRL_DEBUG
> +	CTRL_DEBUG,
> +	CTRL_RDMA
>  };
> -#define CTRLS_MAX CTRL_DEBUG
> +#define CTRLS_MAX CTRL_RDMA

>  /* At most we can have one cgroup V1 tree for each controller and one
>   * (empty) v2 tree.
> @@ -253,6 +254,10 @@ static const struct cgroup_file debug_ctrl_files[] = {
>  	{ }
>  };

> +static const struct cgroup_file rdma_ctrl_files[] = {
> +	{ }
> +};
> +
>  #define CTRL_NAME_MAX 31
>  #define CGROUP_CTRL_MEMBER(x, y)[y] = { .ctrl_name = #x, .files = \
>  	x ## _ctrl_files, .ctrl_indx = y, NULL, 0 }
> @@ -275,6 +280,7 @@ static struct cgroup_ctrl controllers[] = {
>  	CGROUP_CTRL_MEMBER(misc, CTRL_MISC),
>  	CGROUP_CTRL_MEMBER(perf_event, CTRL_PERFEVENT),
>  	CGROUP_CTRL_MEMBER(debug, CTRL_DEBUG),
> +	CGROUP_CTRL_MEMBER(rdma, CTRL_RDMA),
>  	{ }
>  };

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2022-08-25 11:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-24 21:54 [LTP] [PATCH] API/cgroup: Add rdma controller Luke Nowakowski-Krijger
2022-08-25 10:59 ` Petr Vorel [this message]
2022-08-25 16:22   ` Richard Palethorpe
2022-08-25 17:39     ` Luke Nowakowski-Krijger
2022-08-25 18:53       ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YwdWKb/Imzwk5F1V@pevik \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    --cc=luke.nowakowskikrijger@canonical.com \
    --cc=rpalethorpe@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).