* [LTP] [PATCH] API/cgroup: Add rdma controller
@ 2022-08-24 21:54 Luke Nowakowski-Krijger
2022-08-25 10:59 ` Petr Vorel
0 siblings, 1 reply; 5+ messages in thread
From: Luke Nowakowski-Krijger @ 2022-08-24 21:54 UTC (permalink / raw)
To: ltp
There is a test reporting "TBROK: 'rdma' controller is unknown
to LTP" so lets add the controller.
Signed-off-by: Luke Nowakowski-Krijger <luke.nowakowskikrijger@canonical.com>
---
lib/tst_cgroup.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/lib/tst_cgroup.c b/lib/tst_cgroup.c
index 1cfd79243..1da3f0a5d 100644
--- a/lib/tst_cgroup.c
+++ b/lib/tst_cgroup.c
@@ -93,9 +93,10 @@ enum cgroup_ctrl_indx {
CTRL_BLKIO,
CTRL_MISC,
CTRL_PERFEVENT,
- CTRL_DEBUG
+ CTRL_DEBUG,
+ CTRL_RDMA
};
-#define CTRLS_MAX CTRL_DEBUG
+#define CTRLS_MAX CTRL_RDMA
/* At most we can have one cgroup V1 tree for each controller and one
* (empty) v2 tree.
@@ -253,6 +254,10 @@ static const struct cgroup_file debug_ctrl_files[] = {
{ }
};
+static const struct cgroup_file rdma_ctrl_files[] = {
+ { }
+};
+
#define CTRL_NAME_MAX 31
#define CGROUP_CTRL_MEMBER(x, y)[y] = { .ctrl_name = #x, .files = \
x ## _ctrl_files, .ctrl_indx = y, NULL, 0 }
@@ -275,6 +280,7 @@ static struct cgroup_ctrl controllers[] = {
CGROUP_CTRL_MEMBER(misc, CTRL_MISC),
CGROUP_CTRL_MEMBER(perf_event, CTRL_PERFEVENT),
CGROUP_CTRL_MEMBER(debug, CTRL_DEBUG),
+ CGROUP_CTRL_MEMBER(rdma, CTRL_RDMA),
{ }
};
--
2.34.1
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [LTP] [PATCH] API/cgroup: Add rdma controller
2022-08-24 21:54 [LTP] [PATCH] API/cgroup: Add rdma controller Luke Nowakowski-Krijger
@ 2022-08-25 10:59 ` Petr Vorel
2022-08-25 16:22 ` Richard Palethorpe
0 siblings, 1 reply; 5+ messages in thread
From: Petr Vorel @ 2022-08-25 10:59 UTC (permalink / raw)
To: Luke Nowakowski-Krijger; +Cc: Richard Palethorpe, ltp
Hi Luke,
> There is a test reporting "TBROK: 'rdma' controller is unknown
> to LTP" so lets add the controller.
Out of curiosity: which test?
Reviewed-by: Petr Vorel <pvorel@suse.cz>
Kind regards,
Petr
> Signed-off-by: Luke Nowakowski-Krijger <luke.nowakowskikrijger@canonical.com>
> ---
> lib/tst_cgroup.c | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
> diff --git a/lib/tst_cgroup.c b/lib/tst_cgroup.c
> index 1cfd79243..1da3f0a5d 100644
> --- a/lib/tst_cgroup.c
> +++ b/lib/tst_cgroup.c
> @@ -93,9 +93,10 @@ enum cgroup_ctrl_indx {
> CTRL_BLKIO,
> CTRL_MISC,
> CTRL_PERFEVENT,
> - CTRL_DEBUG
> + CTRL_DEBUG,
> + CTRL_RDMA
> };
> -#define CTRLS_MAX CTRL_DEBUG
> +#define CTRLS_MAX CTRL_RDMA
> /* At most we can have one cgroup V1 tree for each controller and one
> * (empty) v2 tree.
> @@ -253,6 +254,10 @@ static const struct cgroup_file debug_ctrl_files[] = {
> { }
> };
> +static const struct cgroup_file rdma_ctrl_files[] = {
> + { }
> +};
> +
> #define CTRL_NAME_MAX 31
> #define CGROUP_CTRL_MEMBER(x, y)[y] = { .ctrl_name = #x, .files = \
> x ## _ctrl_files, .ctrl_indx = y, NULL, 0 }
> @@ -275,6 +280,7 @@ static struct cgroup_ctrl controllers[] = {
> CGROUP_CTRL_MEMBER(misc, CTRL_MISC),
> CGROUP_CTRL_MEMBER(perf_event, CTRL_PERFEVENT),
> CGROUP_CTRL_MEMBER(debug, CTRL_DEBUG),
> + CGROUP_CTRL_MEMBER(rdma, CTRL_RDMA),
> { }
> };
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [LTP] [PATCH] API/cgroup: Add rdma controller
2022-08-25 10:59 ` Petr Vorel
@ 2022-08-25 16:22 ` Richard Palethorpe
2022-08-25 17:39 ` Luke Nowakowski-Krijger
0 siblings, 1 reply; 5+ messages in thread
From: Richard Palethorpe @ 2022-08-25 16:22 UTC (permalink / raw)
To: Petr Vorel; +Cc: ltp, Luke Nowakowski-Krijger
Hi,
Petr Vorel <pvorel@suse.cz> writes:
> Hi Luke,
>
>> There is a test reporting "TBROK: 'rdma' controller is unknown
>> to LTP" so lets add the controller.
>
> Out of curiosity: which test?
>
> Reviewed-by: Petr Vorel <pvorel@suse.cz>
>
> Kind regards,
> Petr
I'm not sure, I think it was one of the shell tests which tries to mount
all the controllers. Anyway, merged thanks!
--
Thank you,
Richard.
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [LTP] [PATCH] API/cgroup: Add rdma controller
2022-08-25 16:22 ` Richard Palethorpe
@ 2022-08-25 17:39 ` Luke Nowakowski-Krijger
2022-08-25 18:53 ` Petr Vorel
0 siblings, 1 reply; 5+ messages in thread
From: Luke Nowakowski-Krijger @ 2022-08-25 17:39 UTC (permalink / raw)
To: Richard Palethorpe; +Cc: LTP List
[-- Attachment #1.1: Type: text/plain, Size: 689 bytes --]
Hi,
On Thu, Aug 25, 2022 at 9:24 AM Richard Palethorpe <rpalethorpe@suse.de>
wrote:
> Hi,
>
> Petr Vorel <pvorel@suse.cz> writes:
>
> > Hi Luke,
> >
> >> There is a test reporting "TBROK: 'rdma' controller is unknown
> >> to LTP" so lets add the controller.
> >
> > Out of curiosity: which test?
> >
> > Reviewed-by: Petr Vorel <pvorel@suse.cz>
> >
> > Kind regards,
> > Petr
>
> I'm not sure, I think it was one of the shell tests which tries to mount
> all the controllers. Anyway, merged thanks!
>
>
It looks like cgroup/cgroup_regression_test.sh test 7 was the failing test.
Li ran into this earlier too I think.
Thanks for merging :)
Thanks,
- Luke
--
> Thank you,
> Richard.
>
[-- Attachment #1.2: Type: text/html, Size: 1475 bytes --]
[-- Attachment #2: Type: text/plain, Size: 60 bytes --]
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [LTP] [PATCH] API/cgroup: Add rdma controller
2022-08-25 17:39 ` Luke Nowakowski-Krijger
@ 2022-08-25 18:53 ` Petr Vorel
0 siblings, 0 replies; 5+ messages in thread
From: Petr Vorel @ 2022-08-25 18:53 UTC (permalink / raw)
To: Luke Nowakowski-Krijger; +Cc: LTP List
> Hi,
> On Thu, Aug 25, 2022 at 9:24 AM Richard Palethorpe <rpalethorpe@suse.de>
> wrote:
> > Hi,
> > Petr Vorel <pvorel@suse.cz> writes:
> > > Hi Luke,
> > >> There is a test reporting "TBROK: 'rdma' controller is unknown
> > >> to LTP" so lets add the controller.
> > > Out of curiosity: which test?
> > > Reviewed-by: Petr Vorel <pvorel@suse.cz>
> > > Kind regards,
> > > Petr
> > I'm not sure, I think it was one of the shell tests which tries to mount
> > all the controllers. Anyway, merged thanks!
> It looks like cgroup/cgroup_regression_test.sh test 7 was the failing test.
> Li ran into this earlier too I think.
Thanks for info!
Kind regards,
Petr
> Thanks for merging :)
> Thanks,
> - Luke
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-08-25 18:53 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-24 21:54 [LTP] [PATCH] API/cgroup: Add rdma controller Luke Nowakowski-Krijger
2022-08-25 10:59 ` Petr Vorel
2022-08-25 16:22 ` Richard Palethorpe
2022-08-25 17:39 ` Luke Nowakowski-Krijger
2022-08-25 18:53 ` Petr Vorel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).