lttng-dev.lists.lttng.org archive mirror
 help / color / mirror / Atom feed
* [lttng-dev] [PATCH urcu] cleanup: Improve wording of CONFIG_RCU_DEBUG description
@ 2020-11-17 20:22 Michael Jeanson via lttng-dev
  2020-11-17 20:34 ` Mathieu Desnoyers via lttng-dev
  0 siblings, 1 reply; 2+ messages in thread
From: Michael Jeanson via lttng-dev @ 2020-11-17 20:22 UTC (permalink / raw)
  To: lttng-dev

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
---
 configure.ac             | 4 ++--
 include/urcu/config.h.in | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/configure.ac b/configure.ac
index b62f587..73ab19f 100644
--- a/configure.ac
+++ b/configure.ac
@@ -28,7 +28,7 @@ AH_TEMPLATE([CONFIG_RCU_ARM_HAVE_DMB], [Use the dmb instruction if available for
 AH_TEMPLATE([CONFIG_RCU_TLS], [TLS provided by the compiler.])
 AH_TEMPLATE([CONFIG_RCU_HAVE_CLOCK_GETTIME], [clock_gettime() is detected.])
 AH_TEMPLATE([CONFIG_RCU_FORCE_SYS_MEMBARRIER], [Require the operating system to support the membarrier system call for default and bulletproof flavors.])
-AH_TEMPLATE([CONFIG_RCU_DEBUG], [Enable internal debugging self-checks. Introduce performance penalty.])
+AH_TEMPLATE([CONFIG_RCU_DEBUG], [Enable internal debugging self-checks. Introduces a performance penalty.])
 AH_TEMPLATE([CONFIG_CDS_LFHT_ITER_DEBUG], [Enable extra debugging checks for lock-free hash table iterator traversal. Alters the rculfhash ABI. Make sure to compile both library and application with matching configuration.])
 
 # Allow requiring the operating system to support the membarrier system
@@ -257,7 +257,7 @@ AS_IF([test "x$def_smp_support" = "xyes"], [AC_DEFINE([CONFIG_RCU_SMP], [1])])
 # RCU debugging option
 AC_ARG_ENABLE([rcu-debug],
       AS_HELP_STRING([--enable-rcu-debug], [Enable internal debugging
-		      self-checks. Introduce performance penalty.]))
+		      self-checks. Introduces a performance penalty.]))
 AS_IF([test "x$enable_rcu_debug" = "xyes"], [
        AC_DEFINE([CONFIG_RCU_DEBUG], [1])
 ])
diff --git a/include/urcu/config.h.in b/include/urcu/config.h.in
index 8c3e4da..7350631 100644
--- a/include/urcu/config.h.in
+++ b/include/urcu/config.h.in
@@ -28,7 +28,7 @@
 #undef CONFIG_RCU_FORCE_SYS_MEMBARRIER
 
 /* Enable internal debugging self-checks.
-   Introduce performance penalty. */
+   Introduces a performance penalty. */
 #undef CONFIG_RCU_DEBUG
 
 /* Expose multi-flavor support */
-- 
2.29.2

_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [lttng-dev] [PATCH urcu] cleanup: Improve wording of CONFIG_RCU_DEBUG description
  2020-11-17 20:22 [lttng-dev] [PATCH urcu] cleanup: Improve wording of CONFIG_RCU_DEBUG description Michael Jeanson via lttng-dev
@ 2020-11-17 20:34 ` Mathieu Desnoyers via lttng-dev
  0 siblings, 0 replies; 2+ messages in thread
From: Mathieu Desnoyers via lttng-dev @ 2020-11-17 20:34 UTC (permalink / raw)
  To: Michael Jeanson; +Cc: lttng-dev

Merged into master, stable-0.11, stable-0.12, thanks!

Mathieu

----- On Nov 17, 2020, at 3:22 PM, Michael Jeanson mjeanson@efficios.com wrote:

> Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
> ---
> configure.ac             | 4 ++--
> include/urcu/config.h.in | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/configure.ac b/configure.ac
> index b62f587..73ab19f 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -28,7 +28,7 @@ AH_TEMPLATE([CONFIG_RCU_ARM_HAVE_DMB], [Use the dmb
> instruction if available for
> AH_TEMPLATE([CONFIG_RCU_TLS], [TLS provided by the compiler.])
> AH_TEMPLATE([CONFIG_RCU_HAVE_CLOCK_GETTIME], [clock_gettime() is detected.])
> AH_TEMPLATE([CONFIG_RCU_FORCE_SYS_MEMBARRIER], [Require the operating system to
> support the membarrier system call for default and bulletproof flavors.])
> -AH_TEMPLATE([CONFIG_RCU_DEBUG], [Enable internal debugging self-checks.
> Introduce performance penalty.])
> +AH_TEMPLATE([CONFIG_RCU_DEBUG], [Enable internal debugging self-checks.
> Introduces a performance penalty.])
> AH_TEMPLATE([CONFIG_CDS_LFHT_ITER_DEBUG], [Enable extra debugging checks for
> lock-free hash table iterator traversal. Alters the rculfhash ABI. Make sure to
> compile both library and application with matching configuration.])
> 
> # Allow requiring the operating system to support the membarrier system
> @@ -257,7 +257,7 @@ AS_IF([test "x$def_smp_support" = "xyes"],
> [AC_DEFINE([CONFIG_RCU_SMP], [1])])
> # RCU debugging option
> AC_ARG_ENABLE([rcu-debug],
>       AS_HELP_STRING([--enable-rcu-debug], [Enable internal debugging
> -		      self-checks. Introduce performance penalty.]))
> +		      self-checks. Introduces a performance penalty.]))
> AS_IF([test "x$enable_rcu_debug" = "xyes"], [
>        AC_DEFINE([CONFIG_RCU_DEBUG], [1])
> ])
> diff --git a/include/urcu/config.h.in b/include/urcu/config.h.in
> index 8c3e4da..7350631 100644
> --- a/include/urcu/config.h.in
> +++ b/include/urcu/config.h.in
> @@ -28,7 +28,7 @@
> #undef CONFIG_RCU_FORCE_SYS_MEMBARRIER
> 
> /* Enable internal debugging self-checks.
> -   Introduce performance penalty. */
> +   Introduces a performance penalty. */
> #undef CONFIG_RCU_DEBUG
> 
> /* Expose multi-flavor support */
> --
> 2.29.2

-- 
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com
_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-11-17 20:34 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-17 20:22 [lttng-dev] [PATCH urcu] cleanup: Improve wording of CONFIG_RCU_DEBUG description Michael Jeanson via lttng-dev
2020-11-17 20:34 ` Mathieu Desnoyers via lttng-dev

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).