From: Simon Marchi via lttng-dev <lttng-dev@lists.lttng.org>
To: Rocky Dunlap <dunlap@ucar.edu>
Cc: lttng-dev@lists.lttng.org
Subject: Re: Babeltrace2 - compilation error with intel18
Date: Mon, 23 Mar 2020 11:44:35 -0400 [thread overview]
Message-ID: <1c4447ea-b67a-eaf0-c9dd-d2c10106b5a7@simark.ca> (raw)
In-Reply-To: <4bc0ec69-7587-fe58-691f-5cb23a11cd43@simark.ca>
On 2020-03-20 11:12 p.m., Simon Marchi via lttng-dev wrote:
> So since distutils really wants to compile the Python native modules using all the same
> flags as the Python interpreter was built with, I presume that they really assume that
> you'll be using the exact same toolchain to build your module as was used to build the
> interpreter. Maybe we could just not pass CC/CFLAGS when building the Python module,
> so it will simply be built with the same compiler/linker as Python was built with, and
> we'll avoid all these problems...
If we want to go this route, here's a patch that implements it.
https://review.lttng.org/c/babeltrace/+/3257
This makes it so we don't override the compiler or flags (other than necessary includes
flags) when building the native module. So when configuring with CC=clang, the Python
native module gets built with the Python distribution's default compiler, with just the
flags it wants.
Could you check if that works with CC=icc as well?
Simon
next prev parent reply other threads:[~2020-03-23 15:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-20 21:10 Babeltrace2 - compilation error with intel18 Rocky Dunlap via lttng-dev
2020-03-20 21:47 ` Simon Marchi via lttng-dev
2020-03-20 21:55 ` Rocky Dunlap via lttng-dev
2020-03-20 22:20 ` Simon Marchi via lttng-dev
2020-03-20 22:32 ` Rocky Dunlap via lttng-dev
2020-03-21 3:12 ` Simon Marchi via lttng-dev
2020-03-23 15:44 ` Simon Marchi via lttng-dev [this message]
2020-03-23 16:05 ` Rocky Dunlap via lttng-dev
2020-03-23 16:14 ` Simon Marchi via lttng-dev
2020-03-23 16:56 ` Rocky Dunlap via lttng-dev
2020-03-23 17:24 ` Simon Marchi via lttng-dev
2020-03-23 17:37 ` Rocky Dunlap via lttng-dev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c4447ea-b67a-eaf0-c9dd-d2c10106b5a7@simark.ca \
--to=lttng-dev@lists.lttng.org \
--cc=dunlap@ucar.edu \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).