lttng-dev.lists.lttng.org archive mirror
 help / color / mirror / Atom feed
From: Rocky Dunlap via lttng-dev <lttng-dev@lists.lttng.org>
To: Simon Marchi <simark@simark.ca>
Cc: lttng-dev@lists.lttng.org
Subject: Re: Babeltrace2 - compilation error with intel18
Date: Mon, 23 Mar 2020 10:56:32 -0600	[thread overview]
Message-ID: <CADtyBo6gSKTLzyXsU-E=--rdxaUARCV+-2CgA80pm8sH73EZZQ@mail.gmail.com> (raw)
In-Reply-To: <5f7d96c7-bf73-3ef6-012d-27dd8812361a@simark.ca>


[-- Attachment #1.1: Type: text/plain, Size: 4194 bytes --]

Simon,

Success!  This change worked and I was able to build and install with icc.
Thank you!

I still get a lot of warnings during the build (see below) which seems like
configure should work these out ahead of time.  They are easy enough to
ignore, but if support for intel is added, it would be nice to have these
cleaned up.  For what it's worth, adding support for additional compilers
in my experience has greatly improved the quality of library code - it
tends to snuff out those bugs that are hard to find on a single compiler.

If you decide to merge this in, a release patch 2.0.3 would certainly be
helpful as well!


Example warnings below:
icc: command line warning #10006: ignoring unknown option '-Wnested-externs'
icc: command line warning #10006: ignoring unknown option
'-Wtautological-constant-out-of-range-compare'
icc: command line warning #10006: ignoring unknown option '-Wnested-externs'
icc: command line warning #10006: ignoring unknown option
'-Wno-format-nonliteral'
icc: command line warning #10006: ignoring unknown option
'-Wno-format-nonliteral'
icc: command line warning #10006: ignoring unknown option
'-Wmissing-noreturn'
icc: command line warning #10006: ignoring unknown option
'-Wmissing-noreturn'
icc: command line warning #10006: ignoring unknown option
'-Wduplicated-cond'
icc: command line warning #10006: ignoring unknown option
'-Wduplicated-branches'
icc: command line warning #10006: ignoring unknown option
'-Wduplicated-cond'
icc: command line warning #10006: ignoring unknown option
'-Wduplicated-branches'
icc: command line warning #10006: ignoring unknown option '-Wlogical-op'
icc: command line warning #10006: ignoring unknown option '-Wlogical-op'
icc: command line warning #10006: ignoring unknown option
'-Wno-cast-function-type'
icc: command line warning #10006: ignoring unknown option
'-Wno-cast-function-type'
icc: command line warning #10006: ignoring unknown option
'-Wnull-dereference'
icc: command line warning #10006: ignoring unknown option
'-Wredundant-decls'
icc: command line warning #10006: ignoring unknown option
'-Wjump-misses-init'
icc: command line warning #10006: ignoring unknown option
'-Wsuggest-attribute=format'
icc: command line warning #10006: ignoring unknown option
'-Wtautological-constant-out-of-range-compare'
icc: command line warning #10006: ignoring unknown option '-Wnested-externs'
icc: command line warning #10006: ignoring unknown option
'-Wno-format-nonliteral'
icc: command line warning #10006: ignoring unknown option
'-Wmissing-noreturn'
icc: command line warning #10006: ignoring unknown option
'-Wduplicated-cond'
icc: command line warning #10006: ignoring unknown option
'-Wduplicated-branches'
icc: command line warning #10006: ignoring unknown option '-Wlogical-op'
icc: command line warning #10006: ignoring unknown option
'-Wno-cast-function-type'
icc: command line warning #10006: ignoring unknown option
'-Wnull-dereference'
icc: command line warning #10006: ignoring unknown option
'-Wredundant-decls'
icc: command line warning #10006: ignoring unknown option
'-Wjump-misses-init'
icc: command line warning #10006: ignoring unknown option
'-Wsuggest-attribute=format'
icc: command line warning #10006: ignoring unknown option
'-Wtautological-constant-out-of-range-compare'


On Mon, Mar 23, 2020 at 10:14 AM Simon Marchi <simark@simark.ca> wrote:

> On 2020-03-23 12:05 p.m., Rocky Dunlap wrote:
> > Simon,
> >
> > Yes, I will be happy to give this a try.  What's the easiest way to get
> this patch?  (Sorry, I'm less familiar with Gerrit...)
> >
> > Rocky
>
> You need a babeltrace git repository.  If you don't already have one, you
> can clone it from here:
>
>   https://github.com/efficios/babeltrace
>
> You can then click the "DOWNLOAD" button on the patch's review page, or
> press `d` (a keybinding).
>
> Copy the "Checkout" command (the first one) and paste it in your shell
> (while having the
> repository as the current working directory).  You'll then have the code
> corresponding to
> the proposed patch checked out and ready to build.  Note that when you
> build from the git
> repo, you need to run ./bootstrap first, to generate the configure script.
>
> Simon
>
>

[-- Attachment #1.2: Type: text/html, Size: 5171 bytes --]

[-- Attachment #2: Type: text/plain, Size: 156 bytes --]

_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

  reply	other threads:[~2020-03-23 16:56 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-20 21:10 Babeltrace2 - compilation error with intel18 Rocky Dunlap via lttng-dev
2020-03-20 21:47 ` Simon Marchi via lttng-dev
2020-03-20 21:55   ` Rocky Dunlap via lttng-dev
2020-03-20 22:20     ` Simon Marchi via lttng-dev
2020-03-20 22:32       ` Rocky Dunlap via lttng-dev
2020-03-21  3:12         ` Simon Marchi via lttng-dev
2020-03-23 15:44           ` Simon Marchi via lttng-dev
2020-03-23 16:05             ` Rocky Dunlap via lttng-dev
2020-03-23 16:14               ` Simon Marchi via lttng-dev
2020-03-23 16:56                 ` Rocky Dunlap via lttng-dev [this message]
2020-03-23 17:24                   ` Simon Marchi via lttng-dev
2020-03-23 17:37                     ` Rocky Dunlap via lttng-dev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADtyBo6gSKTLzyXsU-E=--rdxaUARCV+-2CgA80pm8sH73EZZQ@mail.gmail.com' \
    --to=lttng-dev@lists.lttng.org \
    --cc=dunlap@ucar.edu \
    --cc=simark@simark.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).