lttng-dev.lists.lttng.org archive mirror
 help / color / mirror / Atom feed
* [PATCH lttng-ust] doc: fix build failure due to wrong whitespace character
@ 2019-11-18 18:44 Simon Marchi
  0 siblings, 0 replies; 2+ messages in thread
From: Simon Marchi @ 2019-11-18 18:44 UTC (permalink / raw)
  To: lttng-dev; +Cc: Simon Marchi

The previous, commit:

    54435b75df4c ("doc: reformat long lines in doc/examples/Makefile.am")

introduced the following build failure, when the support for JUL is
enabled:

    make[1]: Entering directory '/home/smarchi/build/lttng-ust/doc/examples/java-jul'
    javac -classpath "../../../liblttng-ust-java-agent/java/lttng-ust-agent-jul/lttng-ust-agent-jul.jar:../../../liblttng-ust-java-agent/java/lttng-ust-agent-common/lttng-ust-agent-common.jar:." -g Hello.java
    javac -classpath "../../../liblttng-ust-java-agent/java/lttng-ust-agent-jul/lttng-ust-agent-jul.jar:../../../liblttng-ust-java-agent/java/lttng-ust-agent-common/lttng-ust-agent-common.jar:." -g FilterChangeListenerExample.java
    javac -classpath "../../../liblttng-ust-java-agent/java/lttng-ust-agent-jul/lttng-ust-agent-jul.jar:../../../liblttng-ust-java-agent/java/lttng-ust-agent-common/lttng-ust-agent-common.jar:." -g ApplicationContextExample.java
    make[1]: *** No rule to make target ' '.  Stop.
    make[1]: Leaving directory '/home/smarchi/build/lttng-ust/doc/examples/java-jul'
    Makefile:979: recipe for target 'all-local' failed
    make: *** [all-local] Error 1

I inadvertently inserted a character that looks like a space, but that
is not a space.  make tries to interpret it as a target name, which
obviously fails.

Replace it with a proper space.

Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
---
 doc/examples/Makefile.am | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/doc/examples/Makefile.am b/doc/examples/Makefile.am
index dc37489687e2..2ba8cd89462a 100644
--- a/doc/examples/Makefile.am
+++ b/doc/examples/Makefile.am
@@ -149,7 +149,7 @@ all-local:
 				$(MAKE) all \
 					JAVA_CLASSPATH_OVERRIDE_JUL="../../../liblttng-ust-java-agent/java/lttng-ust-agent-jul" \
 					JAVA_CLASSPATH_OVERRIDE_COMMON="../../../liblttng-ust-java-agent/java/lttng-ust-agent-common" \
-					$(AM_MAKEFLAGS) \
+					$(AM_MAKEFLAGS) \
 			) || exit 1; \
 		done; \
 	fi; \
-- 
2.24.0

_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH lttng-ust] doc: fix build failure due to wrong whitespace character
       [not found] <20191118184414.6902-1-simon.marchi@efficios.com>
@ 2019-11-18 20:06 ` Mathieu Desnoyers
  0 siblings, 0 replies; 2+ messages in thread
From: Mathieu Desnoyers @ 2019-11-18 20:06 UTC (permalink / raw)
  To: Simon Marchi; +Cc: lttng-dev

Merged into lttng-ust master, thanks!

Mathieu

----- On Nov 18, 2019, at 1:44 PM, Simon Marchi simon.marchi@efficios.com wrote:

> The previous, commit:
> 
>    54435b75df4c ("doc: reformat long lines in doc/examples/Makefile.am")
> 
> introduced the following build failure, when the support for JUL is
> enabled:
> 
>    make[1]: Entering directory
>    '/home/smarchi/build/lttng-ust/doc/examples/java-jul'
>    javac -classpath
>    "../../../liblttng-ust-java-agent/java/lttng-ust-agent-jul/lttng-ust-agent-jul.jar:../../../liblttng-ust-java-agent/java/lttng-ust-agent-common/lttng-ust-agent-common.jar:."
>    -g Hello.java
>    javac -classpath
>    "../../../liblttng-ust-java-agent/java/lttng-ust-agent-jul/lttng-ust-agent-jul.jar:../../../liblttng-ust-java-agent/java/lttng-ust-agent-common/lttng-ust-agent-common.jar:."
>    -g FilterChangeListenerExample.java
>    javac -classpath
>    "../../../liblttng-ust-java-agent/java/lttng-ust-agent-jul/lttng-ust-agent-jul.jar:../../../liblttng-ust-java-agent/java/lttng-ust-agent-common/lttng-ust-agent-common.jar:."
>    -g ApplicationContextExample.java
>    make[1]: *** No rule to make target ' '.  Stop.
>    make[1]: Leaving directory '/home/smarchi/build/lttng-ust/doc/examples/java-jul'
>    Makefile:979: recipe for target 'all-local' failed
>    make: *** [all-local] Error 1
> 
> I inadvertently inserted a character that looks like a space, but that
> is not a space.  make tries to interpret it as a target name, which
> obviously fails.
> 
> Replace it with a proper space.
> 
> Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
> ---
> doc/examples/Makefile.am | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/doc/examples/Makefile.am b/doc/examples/Makefile.am
> index dc37489687e2..2ba8cd89462a 100644
> --- a/doc/examples/Makefile.am
> +++ b/doc/examples/Makefile.am
> @@ -149,7 +149,7 @@ all-local:
> 				$(MAKE) all \
> 					JAVA_CLASSPATH_OVERRIDE_JUL="../../../liblttng-ust-java-agent/java/lttng-ust-agent-jul"
> 					\
> 					JAVA_CLASSPATH_OVERRIDE_COMMON="../../../liblttng-ust-java-agent/java/lttng-ust-agent-common"
> 					\
> -					$(AM_MAKEFLAGS) \
> +					$(AM_MAKEFLAGS) \
> 			) || exit 1; \
> 		done; \
> 	fi; \
> --
> 2.24.0
> 
> _______________________________________________
> lttng-dev mailing list
> lttng-dev@lists.lttng.org
> https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

-- 
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com
_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-11-18 20:06 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-18 18:44 [PATCH lttng-ust] doc: fix build failure due to wrong whitespace character Simon Marchi
     [not found] <20191118184414.6902-1-simon.marchi@efficios.com>
2019-11-18 20:06 ` Mathieu Desnoyers

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).