From: Michael Jeanson via lttng-dev <lttng-dev@lists.lttng.org>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: lttng-dev <lttng-dev@lists.lttng.org>
Subject: Re: [lttng-dev] [PATCH] Fix: tracepoint.h: define SDT_USE_VARIADIC in pkg-config CFLAGS
Date: Fri, 26 Jun 2020 17:02:00 -0400 (EDT) [thread overview]
Message-ID: <1673641132.14590.1593205320791.JavaMail.zimbra@efficios.com> (raw)
Message-ID: <20200626210200.QCwWpEjZaj-e6rfWf66giDo3k7mYuvkVx7do0wxAXlE@z> (raw)
In-Reply-To: <20200624160934.205881-1-stefanha@redhat.com>
Hi Stefan,
I proposed a patch here[1] that addresses this problem in a generic way by
duplicating the macro and namespacing it under LTTNG_. Honestly this is more
of an sdt bug, the STAP_PROBEV should be in it's own include guard outside
of _SYS_SDT_H or in it's own header file but we have to work with what's there.
Can you have a look at the patch and confirm that it fixes your problem?
Cheers,
Michael
[1] https://review.lttng.org/c/lttng-ust/+/3685
----- On 24 Jun, 2020, at 12:09, lttng-dev lttng-dev@lists.lttng.org wrote:
> LTTng Userspace Tracer 2.11 with sdt enabled can break builds of
> applications that include <sys/sdt.h> themselves. QEMU
> (https://qemu.org/) is one example.
>
> When applications include <sys/sdt.h> themselves before LTTng Userspace
> Tracer header files and the SDT_USE_VARIADIC macro is not defined,
> compilation fails due to the absense of STAP_PROBEV() macro that LTTng
> Userspace Tracer requires.
>
> Define SDT_USE_VARIADIC in the pkg-config file so that all compilation
> units that use LTTng Userspace Tracer are guaranteed to have the macro
> defined even if <sys/sdt.h> is included elsewhere before LTTng Userspace
> Tracer header files.
>
> In other words, define SDT_USE_VARIADIC on the compiler command-line
> instead of in <lttng/tracepoint.h>. This way it will always been defined
> when <sys/sdt.h> is included.
>
> Make sure to define SDT_USE_VARIADIC when <lttng/tracepoint.h> is
> included without it. This happens when applications do not use
> pkg-config.
>
> Fixes: b2f60c7986bb69f81b79b68f1bfe83aafa3278a7 ("Add sdt.h integration")
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
> Warning: this patch doesn't work yet. SDT_CFLAGS also needs to be passed
> into LTTng Userspace Tracer's own CFLAGS so that compilation can
> succeed. I don't know the autoconf/automake syntax to do this and wanted
> to see what you think of this solution before investing more time.
_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
next prev parent reply other threads:[~2020-06-26 21:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-24 16:09 [PATCH] Fix: tracepoint.h: define SDT_USE_VARIADIC in pkg-config CFLAGS Stefan Hajnoczi via lttng-dev
2020-06-24 16:09 ` [lttng-dev] " Stefan Hajnoczi via lttng-dev
2020-06-26 21:02 ` Michael Jeanson via lttng-dev [this message]
2020-06-26 21:02 ` Michael Jeanson via lttng-dev
2020-06-29 16:26 ` Stefan Hajnoczi via lttng-dev
2020-06-29 16:26 ` [lttng-dev] " Stefan Hajnoczi via lttng-dev
2020-06-29 16:36 ` Michael Jeanson via lttng-dev
2020-06-29 16:36 ` [lttng-dev] " Michael Jeanson via lttng-dev
2020-06-30 9:05 ` Stefan Hajnoczi via lttng-dev
2020-06-30 9:05 ` [lttng-dev] " Stefan Hajnoczi via lttng-dev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1673641132.14590.1593205320791.JavaMail.zimbra@efficios.com \
--to=lttng-dev@lists.lttng.org \
--cc=mjeanson@efficios.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).