From: James Simmons <jsimmons@infradead.org>
To: lustre-devel@lists.lustre.org
Subject: [lustre-devel] [PATCH 25/37] lustre: deprecate libcfs_debug_vmsg2
Date: Sun, 24 Feb 2019 20:02:06 +0000 (GMT) [thread overview]
Message-ID: <alpine.LFD.2.21.1902242001440.1485@casper.infradead.org> (raw)
In-Reply-To: <155053494619.24125.5150721300459339252.stgit@noble.brown>
> Since 2.6.36, Linux' vsprintf has supported %pV
> which supports "recursive sprintf" - exactly the task
> that libcfs_debug_vmsg2 aims to provide.
>
> Instead of calling libcfs_debug_vmsg2(), we can put the fmt and
> args in a 'struct va_format', and pass the address of that structure
> to the "%pV" format.
>
> So do this to remove all users of libcfs_debug_vmsg2().
This is a really nice cleanup.
Reviewed-by: James Simmons <jsimmons@infradead.org>
> Signed-off-by: NeilBrown <neilb@suse.com>
> ---
> drivers/staging/lustre/lustre/ldlm/ldlm_lock.c | 176 ++++++++++----------
> .../staging/lustre/lustre/ptlrpc/pack_generic.c | 42 +++--
> 2 files changed, 115 insertions(+), 103 deletions(-)
>
> diff --git a/drivers/staging/lustre/lustre/ldlm/ldlm_lock.c b/drivers/staging/lustre/lustre/ldlm/ldlm_lock.c
> index f2433dc0e558..6789d3bf0485 100644
> --- a/drivers/staging/lustre/lustre/ldlm/ldlm_lock.c
> +++ b/drivers/staging/lustre/lustre/ldlm/ldlm_lock.c
> @@ -1970,6 +1970,7 @@ void _ldlm_lock_debug(struct ldlm_lock *lock,
> struct ldlm_resource *resource = NULL;
> char *nid = "local";
> va_list args;
> + struct va_format vaf;
>
> if (spin_trylock(&lock->l_lock)) {
> if (lock->l_resource)
> @@ -1978,6 +1979,8 @@ void _ldlm_lock_debug(struct ldlm_lock *lock,
> }
>
> va_start(args, fmt);
> + vaf.fmt = fmt;
> + vaf.va = &args;
>
> if (exp && exp->exp_connection) {
> nid = libcfs_nid2str(exp->exp_connection->c_peer.nid);
> @@ -1988,105 +1991,110 @@ void _ldlm_lock_debug(struct ldlm_lock *lock,
> }
>
> if (!resource) {
> - libcfs_debug_vmsg2(msgdata, fmt, args,
> - " ns: \?\? lock: %p/%#llx lrc: %d/%d,%d mode: %s/%s res: \?\? rrc=\?\? type: \?\?\? flags: %#llx nid: %s remote: %#llx expref: %d pid: %u timeout: %lu lvb_type: %d\n",
> - lock,
> - lock->l_handle.h_cookie,
> - atomic_read(&lock->l_refc),
> - lock->l_readers, lock->l_writers,
> - ldlm_lockname[lock->l_granted_mode],
> - ldlm_lockname[lock->l_req_mode],
> - lock->l_flags, nid,
> - lock->l_remote_handle.cookie,
> - exp ? refcount_read(&exp->exp_refcount) : -99,
> - lock->l_pid, lock->l_callback_timeout,
> - lock->l_lvb_type);
> + libcfs_debug_msg(msgdata,
> + "%pV ns: \?\? lock: %p/%#llx lrc: %d/%d,%d mode: %s/%s res: \?\? rrc=\?\? type: \?\?\? flags: %#llx nid: %s remote: %#llx expref: %d pid: %u timeout: %lu lvb_type: %d\n",
> + &vaf,
> + lock,
> + lock->l_handle.h_cookie,
> + atomic_read(&lock->l_refc),
> + lock->l_readers, lock->l_writers,
> + ldlm_lockname[lock->l_granted_mode],
> + ldlm_lockname[lock->l_req_mode],
> + lock->l_flags, nid,
> + lock->l_remote_handle.cookie,
> + exp ? refcount_read(&exp->exp_refcount) : -99,
> + lock->l_pid, lock->l_callback_timeout,
> + lock->l_lvb_type);
> va_end(args);
> return;
> }
>
> switch (resource->lr_type) {
> case LDLM_EXTENT:
> - libcfs_debug_vmsg2(msgdata, fmt, args,
> - " ns: %s lock: %p/%#llx lrc: %d/%d,%d mode: %s/%s res: " DLDLMRES " rrc: %d type: %s [%llu->%llu] (req %llu->%llu) flags: %#llx nid: %s remote: %#llx expref: %d pid: %u timeout: %lu lvb_type: %d\n",
> - ldlm_lock_to_ns_name(lock), lock,
> - lock->l_handle.h_cookie,
> - atomic_read(&lock->l_refc),
> - lock->l_readers, lock->l_writers,
> - ldlm_lockname[lock->l_granted_mode],
> - ldlm_lockname[lock->l_req_mode],
> - PLDLMRES(resource),
> - atomic_read(&resource->lr_refcount),
> - ldlm_typename[resource->lr_type],
> - lock->l_policy_data.l_extent.start,
> - lock->l_policy_data.l_extent.end,
> - lock->l_req_extent.start,
> - lock->l_req_extent.end,
> - lock->l_flags, nid,
> - lock->l_remote_handle.cookie,
> - exp ? refcount_read(&exp->exp_refcount) : -99,
> - lock->l_pid, lock->l_callback_timeout,
> - lock->l_lvb_type);
> + libcfs_debug_msg(msgdata,
> + "%pV ns: %s lock: %p/%#llx lrc: %d/%d,%d mode: %s/%s res: " DLDLMRES " rrc: %d type: %s [%llu->%llu] (req %llu->%llu) flags: %#llx nid: %s remote: %#llx expref: %d pid: %u timeout: %lu lvb_type: %d\n",
> + &vaf,
> + ldlm_lock_to_ns_name(lock), lock,
> + lock->l_handle.h_cookie,
> + atomic_read(&lock->l_refc),
> + lock->l_readers, lock->l_writers,
> + ldlm_lockname[lock->l_granted_mode],
> + ldlm_lockname[lock->l_req_mode],
> + PLDLMRES(resource),
> + atomic_read(&resource->lr_refcount),
> + ldlm_typename[resource->lr_type],
> + lock->l_policy_data.l_extent.start,
> + lock->l_policy_data.l_extent.end,
> + lock->l_req_extent.start,
> + lock->l_req_extent.end,
> + lock->l_flags, nid,
> + lock->l_remote_handle.cookie,
> + exp ? refcount_read(&exp->exp_refcount) : -99,
> + lock->l_pid, lock->l_callback_timeout,
> + lock->l_lvb_type);
> break;
>
> case LDLM_FLOCK:
> - libcfs_debug_vmsg2(msgdata, fmt, args,
> - " ns: %s lock: %p/%#llx lrc: %d/%d,%d mode: %s/%s res: " DLDLMRES " rrc: %d type: %s pid: %d [%llu->%llu] flags: %#llx nid: %s remote: %#llx expref: %d pid: %u timeout: %lu\n",
> - ldlm_lock_to_ns_name(lock), lock,
> - lock->l_handle.h_cookie,
> - atomic_read(&lock->l_refc),
> - lock->l_readers, lock->l_writers,
> - ldlm_lockname[lock->l_granted_mode],
> - ldlm_lockname[lock->l_req_mode],
> - PLDLMRES(resource),
> - atomic_read(&resource->lr_refcount),
> - ldlm_typename[resource->lr_type],
> - lock->l_policy_data.l_flock.pid,
> - lock->l_policy_data.l_flock.start,
> - lock->l_policy_data.l_flock.end,
> - lock->l_flags, nid,
> - lock->l_remote_handle.cookie,
> - exp ? refcount_read(&exp->exp_refcount) : -99,
> - lock->l_pid, lock->l_callback_timeout);
> + libcfs_debug_msg(msgdata,
> + "%pV ns: %s lock: %p/%#llx lrc: %d/%d,%d mode: %s/%s res: " DLDLMRES " rrc: %d type: %s pid: %d [%llu->%llu] flags: %#llx nid: %s remote: %#llx expref: %d pid: %u timeout: %lu\n",
> + &vaf,
> + ldlm_lock_to_ns_name(lock), lock,
> + lock->l_handle.h_cookie,
> + atomic_read(&lock->l_refc),
> + lock->l_readers, lock->l_writers,
> + ldlm_lockname[lock->l_granted_mode],
> + ldlm_lockname[lock->l_req_mode],
> + PLDLMRES(resource),
> + atomic_read(&resource->lr_refcount),
> + ldlm_typename[resource->lr_type],
> + lock->l_policy_data.l_flock.pid,
> + lock->l_policy_data.l_flock.start,
> + lock->l_policy_data.l_flock.end,
> + lock->l_flags, nid,
> + lock->l_remote_handle.cookie,
> + exp ? refcount_read(&exp->exp_refcount) : -99,
> + lock->l_pid, lock->l_callback_timeout);
> break;
>
> case LDLM_IBITS:
> - libcfs_debug_vmsg2(msgdata, fmt, args,
> - " ns: %s lock: %p/%#llx lrc: %d/%d,%d mode: %s/%s res: " DLDLMRES " bits %#llx rrc: %d type: %s flags: %#llx nid: %s remote: %#llx expref: %d pid: %u timeout: %lu lvb_type: %d\n",
> - ldlm_lock_to_ns_name(lock),
> - lock, lock->l_handle.h_cookie,
> - atomic_read(&lock->l_refc),
> - lock->l_readers, lock->l_writers,
> - ldlm_lockname[lock->l_granted_mode],
> - ldlm_lockname[lock->l_req_mode],
> - PLDLMRES(resource),
> - lock->l_policy_data.l_inodebits.bits,
> - atomic_read(&resource->lr_refcount),
> - ldlm_typename[resource->lr_type],
> - lock->l_flags, nid,
> - lock->l_remote_handle.cookie,
> - exp ? refcount_read(&exp->exp_refcount) : -99,
> - lock->l_pid, lock->l_callback_timeout,
> - lock->l_lvb_type);
> + libcfs_debug_msg(msgdata,
> + "%pV ns: %s lock: %p/%#llx lrc: %d/%d,%d mode: %s/%s res: " DLDLMRES " bits %#llx rrc: %d type: %s flags: %#llx nid: %s remote: %#llx expref: %d pid: %u timeout: %lu lvb_type: %d\n",
> + &vaf,
> + ldlm_lock_to_ns_name(lock),
> + lock, lock->l_handle.h_cookie,
> + atomic_read(&lock->l_refc),
> + lock->l_readers, lock->l_writers,
> + ldlm_lockname[lock->l_granted_mode],
> + ldlm_lockname[lock->l_req_mode],
> + PLDLMRES(resource),
> + lock->l_policy_data.l_inodebits.bits,
> + atomic_read(&resource->lr_refcount),
> + ldlm_typename[resource->lr_type],
> + lock->l_flags, nid,
> + lock->l_remote_handle.cookie,
> + exp ? refcount_read(&exp->exp_refcount) : -99,
> + lock->l_pid, lock->l_callback_timeout,
> + lock->l_lvb_type);
> break;
>
> default:
> - libcfs_debug_vmsg2(msgdata, fmt, args,
> - " ns: %s lock: %p/%#llx lrc: %d/%d,%d mode: %s/%s res: " DLDLMRES " rrc: %d type: %s flags: %#llx nid: %s remote: %#llx expref: %d pid: %u timeout: %lu lvb_type: %d\n",
> - ldlm_lock_to_ns_name(lock),
> - lock, lock->l_handle.h_cookie,
> - atomic_read(&lock->l_refc),
> - lock->l_readers, lock->l_writers,
> - ldlm_lockname[lock->l_granted_mode],
> - ldlm_lockname[lock->l_req_mode],
> - PLDLMRES(resource),
> - atomic_read(&resource->lr_refcount),
> - ldlm_typename[resource->lr_type],
> - lock->l_flags, nid,
> - lock->l_remote_handle.cookie,
> - exp ? refcount_read(&exp->exp_refcount) : -99,
> - lock->l_pid, lock->l_callback_timeout,
> - lock->l_lvb_type);
> + libcfs_debug_msg(msgdata,
> + "%pV ns: %s lock: %p/%#llx lrc: %d/%d,%d mode: %s/%s res: " DLDLMRES " rrc: %d type: %s flags: %#llx nid: %s remote: %#llx expref: %d pid: %u timeout: %lu lvb_type: %d\n",
> + &vaf,
> + ldlm_lock_to_ns_name(lock),
> + lock, lock->l_handle.h_cookie,
> + atomic_read(&lock->l_refc),
> + lock->l_readers, lock->l_writers,
> + ldlm_lockname[lock->l_granted_mode],
> + ldlm_lockname[lock->l_req_mode],
> + PLDLMRES(resource),
> + atomic_read(&resource->lr_refcount),
> + ldlm_typename[resource->lr_type],
> + lock->l_flags, nid,
> + lock->l_remote_handle.cookie,
> + exp ? refcount_read(&exp->exp_refcount) : -99,
> + lock->l_pid, lock->l_callback_timeout,
> + lock->l_lvb_type);
> break;
> }
> va_end(args);
> diff --git a/drivers/staging/lustre/lustre/ptlrpc/pack_generic.c b/drivers/staging/lustre/lustre/ptlrpc/pack_generic.c
> index c7cc86c3fbc3..879cb1162cc7 100644
> --- a/drivers/staging/lustre/lustre/ptlrpc/pack_generic.c
> +++ b/drivers/staging/lustre/lustre/ptlrpc/pack_generic.c
> @@ -2276,6 +2276,7 @@ void _debug_req(struct ptlrpc_request *req,
> int rep_flags = -1;
> int rep_status = -1;
> va_list args;
> + struct va_format vaf;
>
> spin_lock(&req->rq_early_free_lock);
> if (req->rq_repmsg)
> @@ -2298,25 +2299,28 @@ void _debug_req(struct ptlrpc_request *req,
> nid = req->rq_export->exp_connection->c_peer.nid;
>
> va_start(args, fmt);
> - libcfs_debug_vmsg2(msgdata, fmt, args,
> - " req@%p x%llu/t%lld(%lld) o%d->%s@%s:%d/%d lens %d/%d e %d to %lld dl %lld ref %d fl " REQ_FLAGS_FMT "/%x/%x rc %d/%d\n",
> - req, req->rq_xid, req->rq_transno,
> - req_ok ? lustre_msg_get_transno(req->rq_reqmsg) : 0,
> - req_ok ? lustre_msg_get_opc(req->rq_reqmsg) : -1,
> - req->rq_import ?
> - req->rq_import->imp_obd->obd_name :
> - req->rq_export ?
> - req->rq_export->exp_client_uuid.uuid :
> - "<?>",
> - libcfs_nid2str(nid),
> - req->rq_request_portal, req->rq_reply_portal,
> - req->rq_reqlen, req->rq_replen,
> - req->rq_early_count, (s64)req->rq_timedout,
> - (s64)req->rq_deadline,
> - atomic_read(&req->rq_refcount),
> - DEBUG_REQ_FLAGS(req),
> - req_ok ? lustre_msg_get_flags(req->rq_reqmsg) : -1,
> - rep_flags, req->rq_status, rep_status);
> + vaf.fmt = fmt;
> + vaf.va = &args;
> + libcfs_debug_msg(msgdata,
> + "%pV req@%p x%llu/t%lld(%lld) o%d->%s@%s:%d/%d lens %d/%d e %d to %lld dl %lld ref %d fl " REQ_FLAGS_FMT "/%x/%x rc %d/%d\n",
> + &vaf,
> + req, req->rq_xid, req->rq_transno,
> + req_ok ? lustre_msg_get_transno(req->rq_reqmsg) : 0,
> + req_ok ? lustre_msg_get_opc(req->rq_reqmsg) : -1,
> + req->rq_import ?
> + req->rq_import->imp_obd->obd_name :
> + req->rq_export ?
> + req->rq_export->exp_client_uuid.uuid :
> + "<?>",
> + libcfs_nid2str(nid),
> + req->rq_request_portal, req->rq_reply_portal,
> + req->rq_reqlen, req->rq_replen,
> + req->rq_early_count, (s64)req->rq_timedout,
> + (s64)req->rq_deadline,
> + atomic_read(&req->rq_refcount),
> + DEBUG_REQ_FLAGS(req),
> + req_ok ? lustre_msg_get_flags(req->rq_reqmsg) : -1,
> + rep_flags, req->rq_status, rep_status);
> va_end(args);
> }
> EXPORT_SYMBOL(_debug_req);
>
>
>
next prev parent reply other threads:[~2019-02-24 20:02 UTC|newest]
Thread overview: 105+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-19 0:09 [lustre-devel] [PATCH 00/37] More lustre patches from obdclass NeilBrown
2019-02-19 0:09 ` [lustre-devel] [PATCH 01/37] lustre: obdclass: char obd_ioctl_getdata type NeilBrown
2019-02-24 18:35 ` James Simmons
2019-02-19 0:09 ` [lustre-devel] [PATCH 02/37] lustre: llite: don't use class_setup_tunables() NeilBrown
2019-02-24 16:35 ` James Simmons
2019-02-25 22:27 ` NeilBrown
2019-02-26 22:18 ` James Simmons
2019-02-24 16:52 ` [lustre-devel] [PATCH 03/37] lustre: embed typ_kobj if obd_type James Simmons
2019-02-25 22:38 ` NeilBrown
2019-02-26 20:41 ` Simmons, James A.
2019-02-19 0:09 ` [lustre-devel] [PATCH 14/37] lustre: llog: change lgh_refcount to struct kref NeilBrown
2019-02-25 18:16 ` Andreas Dilger
2019-02-19 0:09 ` [lustre-devel] [PATCH 13/37] lustre: llog: remove lgh_hdr_lock NeilBrown
2019-02-24 20:29 ` James Simmons
2019-02-25 18:16 ` Andreas Dilger
2019-02-19 0:09 ` [lustre-devel] [PATCH 07/37] lustre: obd_type: discard obd_type_lock NeilBrown
2019-02-24 17:02 ` James Simmons
2019-02-19 0:09 ` [lustre-devel] [PATCH 08/37] lustre: obdclass: don't copy ops structures in to new type NeilBrown
2019-02-24 17:03 ` James Simmons
2019-02-19 0:09 ` [lustre-devel] [PATCH 16/37] lustre: obdclass: typo: Banlance -> Balance NeilBrown
2019-02-24 17:39 ` James Simmons
2019-02-19 0:09 ` [lustre-devel] [PATCH 05/37] lustre: obd_type: use typ_kobj.name as typ_name NeilBrown
2019-02-24 16:56 ` James Simmons
2019-02-19 0:09 ` [lustre-devel] [PATCH 03/37] lustre: embed typ_kobj if obd_type NeilBrown
2019-02-19 0:09 ` [lustre-devel] [PATCH 09/37] lustre: obdclass: fix module load locking NeilBrown
2019-02-24 17:04 ` James Simmons
2019-02-19 0:09 ` [lustre-devel] [PATCH 17/37] lustre: simplify lprocfs_read_frac_helper NeilBrown
2019-02-24 17:52 ` James Simmons
2019-02-26 23:59 ` NeilBrown
2019-02-27 1:06 ` Andreas Dilger
2019-02-19 0:09 ` [lustre-devel] [PATCH 18/37] lustre: obdclass: discard lprocfs_single/seq_release NeilBrown
2019-02-24 17:53 ` James Simmons
2019-02-19 0:09 ` [lustre-devel] [PATCH 12/37] lustre: remove unused function in linkea NeilBrown
2019-02-25 18:16 ` Andreas Dilger
2019-02-19 0:09 ` [lustre-devel] [PATCH 10/37] lustre: kernelcomm: pass correct gfp_t to kmalloc NeilBrown
2019-02-24 17:05 ` James Simmons
2019-02-25 18:16 ` Andreas Dilger
2019-02-19 0:09 ` [lustre-devel] [PATCH 21/37] lustre: remove several MAX_STRING_SIZE defines NeilBrown
2019-02-24 19:07 ` James Simmons
2019-02-27 0:41 ` NeilBrown
2019-02-25 18:16 ` Andreas Dilger
2019-02-19 0:09 ` [lustre-devel] [PATCH 19/37] lustre: discard lprocfs_strnstr() NeilBrown
2019-02-24 17:53 ` James Simmons
2019-02-19 0:09 ` [lustre-devel] [PATCH 15/37] lustre: llog_obd: Convert loc_refcount to refcount_t NeilBrown
2019-02-25 18:16 ` Andreas Dilger
2019-02-19 0:09 ` [lustre-devel] [PATCH 11/37] lustre: kernelcomm: make libcfs_kkuc_msg_put static NeilBrown
2019-02-24 17:15 ` James Simmons
2019-02-26 23:45 ` NeilBrown
2019-02-27 22:36 ` James Simmons
2019-02-27 22:37 ` James Simmons
2019-02-19 0:09 ` [lustre-devel] [PATCH 04/37] lustre: collect all resource releasing for obj_type NeilBrown
2019-02-24 16:54 ` James Simmons
2019-02-19 0:09 ` [lustre-devel] [PATCH 06/37] lustre: obd_type: discard obd_types linked list NeilBrown
2019-02-24 17:00 ` James Simmons
2019-02-19 0:09 ` [lustre-devel] [PATCH 20/37] lustre: convert rsi_sem to a spinlock NeilBrown
2019-02-25 18:16 ` Andreas Dilger
2019-02-27 0:22 ` NeilBrown
2019-02-27 1:00 ` Andreas Dilger
2019-02-19 0:09 ` [lustre-devel] [PATCH 32/37] lustre: portals_handle: rename ops to owner NeilBrown
2019-02-19 0:09 ` [lustre-devel] [PATCH 22/37] lustre: lprocfs: use log2.h macros instead of shift loop NeilBrown
2019-02-24 18:09 ` James Simmons
2019-02-26 20:55 ` James Simmons
2019-02-27 0:51 ` NeilBrown
2019-02-27 0:54 ` Andreas Dilger
2019-02-19 0:09 ` [lustre-devel] [PATCH 25/37] lustre: deprecate libcfs_debug_vmsg2 NeilBrown
2019-02-24 20:02 ` James Simmons [this message]
2019-02-25 18:16 ` Andreas Dilger
2019-02-19 0:09 ` [lustre-devel] [PATCH 30/37] lustre: handle: move refcount into the lustre_handle NeilBrown
2019-02-27 6:32 ` Andreas Dilger
2019-02-27 21:48 ` NeilBrown
2019-02-27 22:14 ` Andreas Dilger
2019-02-19 0:09 ` [lustre-devel] [PATCH 28/37] lustre: remove scope and source from class_incref and class_decref NeilBrown
2019-02-27 6:52 ` Andreas Dilger
2019-02-28 0:39 ` NeilBrown
2019-02-19 0:09 ` [lustre-devel] [PATCH 26/37] lustre: remove libcfs_debug_vmsg2 NeilBrown
2019-02-25 18:16 ` Andreas Dilger
2019-02-19 0:09 ` [lustre-devel] [PATCH 23/37] lustre: prefer to use tabs for alignment NeilBrown
2019-02-24 18:51 ` James Simmons
2019-02-25 18:16 ` Andreas Dilger
2019-02-19 0:09 ` [lustre-devel] [PATCH 27/37] lustre: discard lu_ref NeilBrown
2019-02-24 20:28 ` James Simmons
2019-02-27 1:17 ` NeilBrown
2019-02-27 5:35 ` Andreas Dilger
2019-03-01 6:45 ` Mike Pershin
2019-02-19 0:09 ` [lustre-devel] [PATCH 29/37] lustre: handles: discard h_owner in favour of h_ops NeilBrown
2019-02-27 6:37 ` Andreas Dilger
2019-02-27 21:41 ` NeilBrown
2019-02-28 6:41 ` Andreas Dilger
2019-02-19 0:09 ` [lustre-devel] [PATCH 33/37] lustre: portals_handle: remove locking from class_handle2object() NeilBrown
2019-02-19 0:09 ` [lustre-devel] [PATCH 34/37] lustre: portals_handle: use hlist for hash lists NeilBrown
2019-02-19 0:09 ` [lustre-devel] [PATCH 31/37] lustre: discard OBD_FREE_RCU NeilBrown
2019-02-19 0:09 ` [lustre-devel] [PATCH 24/37] lustre: lu_object: remove extra newline from debug printing NeilBrown
2019-02-24 19:08 ` James Simmons
2019-02-25 18:16 ` Andreas Dilger
2019-02-19 0:09 ` [lustre-devel] [PATCH 35/37] lustre: portals_handle: discard h_lock NeilBrown
2019-02-19 0:09 ` [lustre-devel] [PATCH 37/37] lustre: obd_sysfs: error-check value stored in jobid_var NeilBrown
2019-02-27 6:17 ` Andreas Dilger
2019-03-01 2:35 ` NeilBrown
2019-03-01 8:32 ` Andreas Dilger
2019-03-01 14:30 ` Patrick Farrell
2019-03-14 0:34 ` NeilBrown
2019-03-14 14:12 ` Patrick Farrell
2019-03-14 22:56 ` NeilBrown
2019-03-14 23:05 ` Andreas Dilger
2019-02-19 0:09 ` [lustre-devel] [PATCH 36/37] lustre: remove unused fields from struct obd_device NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.21.1902242001440.1485@casper.infradead.org \
--to=jsimmons@infradead.org \
--cc=lustre-devel@lists.lustre.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).