* [PATCH net] ipvs: Simplify the allocation of ip_vs_conn slab caches
@ 2024-01-17 7:20 Kunwu Chan
2024-01-17 9:16 ` Denis Kirjanov
2024-01-17 9:29 ` Simon Horman
0 siblings, 2 replies; 6+ messages in thread
From: Kunwu Chan @ 2024-01-17 7:20 UTC (permalink / raw)
To: horms, ja, pablo, kadlec, fw, davem, edumazet, kuba, pabeni
Cc: netdev, lvs-devel, netfilter-devel, coreteam, linux-kernel, Kunwu Chan
Use the new KMEM_CACHE() macro instead of direct kmem_cache_create
to simplify the creation of SLAB caches.
Signed-off-by: Kunwu Chan <chentao@kylinos.cn>
---
net/netfilter/ipvs/ip_vs_conn.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/net/netfilter/ipvs/ip_vs_conn.c b/net/netfilter/ipvs/ip_vs_conn.c
index a743db073887..98d7dbe3d787 100644
--- a/net/netfilter/ipvs/ip_vs_conn.c
+++ b/net/netfilter/ipvs/ip_vs_conn.c
@@ -1511,9 +1511,7 @@ int __init ip_vs_conn_init(void)
return -ENOMEM;
/* Allocate ip_vs_conn slab cache */
- ip_vs_conn_cachep = kmem_cache_create("ip_vs_conn",
- sizeof(struct ip_vs_conn), 0,
- SLAB_HWCACHE_ALIGN, NULL);
+ ip_vs_conn_cachep = KMEM_CACHE(ip_vs_conn, SLAB_HWCACHE_ALIGN);
if (!ip_vs_conn_cachep) {
kvfree(ip_vs_conn_tab);
return -ENOMEM;
--
2.39.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH net] ipvs: Simplify the allocation of ip_vs_conn slab caches
2024-01-17 7:20 [PATCH net] ipvs: Simplify the allocation of ip_vs_conn slab caches Kunwu Chan
@ 2024-01-17 9:16 ` Denis Kirjanov
2024-01-17 9:29 ` Simon Horman
1 sibling, 0 replies; 6+ messages in thread
From: Denis Kirjanov @ 2024-01-17 9:16 UTC (permalink / raw)
To: Kunwu Chan, horms, ja, pablo, kadlec, fw, davem, edumazet, kuba, pabeni
Cc: netdev, lvs-devel, netfilter-devel, coreteam, linux-kernel
On 1/17/24 10:20, Kunwu Chan wrote:
> Use the new KMEM_CACHE() macro instead of direct kmem_cache_create
> to simplify the creation of SLAB caches.
>
> Signed-off-by: Kunwu Chan <chentao@kylinos.cn>
The patch is actually for net-next
> ---
> net/netfilter/ipvs/ip_vs_conn.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/net/netfilter/ipvs/ip_vs_conn.c b/net/netfilter/ipvs/ip_vs_conn.c
> index a743db073887..98d7dbe3d787 100644
> --- a/net/netfilter/ipvs/ip_vs_conn.c
> +++ b/net/netfilter/ipvs/ip_vs_conn.c
> @@ -1511,9 +1511,7 @@ int __init ip_vs_conn_init(void)
> return -ENOMEM;
>
> /* Allocate ip_vs_conn slab cache */
> - ip_vs_conn_cachep = kmem_cache_create("ip_vs_conn",
> - sizeof(struct ip_vs_conn), 0,
> - SLAB_HWCACHE_ALIGN, NULL);
> + ip_vs_conn_cachep = KMEM_CACHE(ip_vs_conn, SLAB_HWCACHE_ALIGN);
> if (!ip_vs_conn_cachep) {
> kvfree(ip_vs_conn_tab);
> return -ENOMEM;
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net] ipvs: Simplify the allocation of ip_vs_conn slab caches
2024-01-17 7:20 [PATCH net] ipvs: Simplify the allocation of ip_vs_conn slab caches Kunwu Chan
2024-01-17 9:16 ` Denis Kirjanov
@ 2024-01-17 9:29 ` Simon Horman
2024-01-18 2:22 ` Kunwu Chan
1 sibling, 1 reply; 6+ messages in thread
From: Simon Horman @ 2024-01-17 9:29 UTC (permalink / raw)
To: Kunwu Chan
Cc: ja, pablo, kadlec, fw, davem, edumazet, kuba, pabeni, netdev,
lvs-devel, netfilter-devel, coreteam, linux-kernel
On Wed, Jan 17, 2024 at 03:20:45PM +0800, Kunwu Chan wrote:
> Use the new KMEM_CACHE() macro instead of direct kmem_cache_create
> to simplify the creation of SLAB caches.
>
> Signed-off-by: Kunwu Chan <chentao@kylinos.cn>
Hi Kunwu Chan,
I think this is more of a cleanup than a fix,
so it should probably be targeted at 'nf-next' rather than 'net'.
If it is a fix, then I would suggest targeting it at 'nf'
and providing a Fixes tag.
The above notwithstanding, this looks good to me.
Acked-by: Simon Horman <horms@kernel.org>
> ---
> net/netfilter/ipvs/ip_vs_conn.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/net/netfilter/ipvs/ip_vs_conn.c b/net/netfilter/ipvs/ip_vs_conn.c
> index a743db073887..98d7dbe3d787 100644
> --- a/net/netfilter/ipvs/ip_vs_conn.c
> +++ b/net/netfilter/ipvs/ip_vs_conn.c
> @@ -1511,9 +1511,7 @@ int __init ip_vs_conn_init(void)
> return -ENOMEM;
>
> /* Allocate ip_vs_conn slab cache */
> - ip_vs_conn_cachep = kmem_cache_create("ip_vs_conn",
> - sizeof(struct ip_vs_conn), 0,
> - SLAB_HWCACHE_ALIGN, NULL);
> + ip_vs_conn_cachep = KMEM_CACHE(ip_vs_conn, SLAB_HWCACHE_ALIGN);
> if (!ip_vs_conn_cachep) {
> kvfree(ip_vs_conn_tab);
> return -ENOMEM;
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net] ipvs: Simplify the allocation of ip_vs_conn slab caches
2024-01-17 9:29 ` Simon Horman
@ 2024-01-18 2:22 ` Kunwu Chan
2024-01-19 15:20 ` Simon Horman
0 siblings, 1 reply; 6+ messages in thread
From: Kunwu Chan @ 2024-01-18 2:22 UTC (permalink / raw)
To: Simon Horman
Cc: ja, pablo, kadlec, fw, davem, edumazet, kuba, pabeni, netdev,
lvs-devel, netfilter-devel, coreteam, linux-kernel
Hi Simon,
Thanks for your reply.
On 2024/1/17 17:29, Simon Horman wrote:
> On Wed, Jan 17, 2024 at 03:20:45PM +0800, Kunwu Chan wrote:
>> Use the new KMEM_CACHE() macro instead of direct kmem_cache_create
>> to simplify the creation of SLAB caches.
>>
>> Signed-off-by: Kunwu Chan <chentao@kylinos.cn>
>
> Hi Kunwu Chan,
>
> I think this is more of a cleanup than a fix,
> so it should probably be targeted at 'nf-next' rather than 'net'.
Thanks, I'm confused about when to use "nf-next" or "net" or "net-next".
"nf-next" means fixing errors for linux-next.git and linux-stable.git,
while "nf" or "next" just means linux-next.git?
>
> If it is a fix, then I would suggest targeting it at 'nf'
> and providing a Fixes tag.
I'll keep it in mind in the future.
>
> The above notwithstanding, this looks good to me.
>
> Acked-by: Simon Horman <horms@kernel.org>
>
>> ---
>> net/netfilter/ipvs/ip_vs_conn.c | 4 +---
>> 1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/net/netfilter/ipvs/ip_vs_conn.c b/net/netfilter/ipvs/ip_vs_conn.c
>> index a743db073887..98d7dbe3d787 100644
>> --- a/net/netfilter/ipvs/ip_vs_conn.c
>> +++ b/net/netfilter/ipvs/ip_vs_conn.c
>> @@ -1511,9 +1511,7 @@ int __init ip_vs_conn_init(void)
>> return -ENOMEM;
>>
>> /* Allocate ip_vs_conn slab cache */
>> - ip_vs_conn_cachep = kmem_cache_create("ip_vs_conn",
>> - sizeof(struct ip_vs_conn), 0,
>> - SLAB_HWCACHE_ALIGN, NULL);
>> + ip_vs_conn_cachep = KMEM_CACHE(ip_vs_conn, SLAB_HWCACHE_ALIGN);
>> if (!ip_vs_conn_cachep) {
>> kvfree(ip_vs_conn_tab);
>> return -ENOMEM;
--
Thanks,
Kunwu
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net] ipvs: Simplify the allocation of ip_vs_conn slab caches
2024-01-18 2:22 ` Kunwu Chan
@ 2024-01-19 15:20 ` Simon Horman
2024-01-22 7:35 ` Kunwu Chan
0 siblings, 1 reply; 6+ messages in thread
From: Simon Horman @ 2024-01-19 15:20 UTC (permalink / raw)
To: Kunwu Chan
Cc: ja, pablo, kadlec, fw, davem, edumazet, kuba, pabeni, netdev,
lvs-devel, netfilter-devel, coreteam, linux-kernel
On Thu, Jan 18, 2024 at 10:22:05AM +0800, Kunwu Chan wrote:
> Hi Simon,
>
> Thanks for your reply.
>
> On 2024/1/17 17:29, Simon Horman wrote:
> > On Wed, Jan 17, 2024 at 03:20:45PM +0800, Kunwu Chan wrote:
> > > Use the new KMEM_CACHE() macro instead of direct kmem_cache_create
> > > to simplify the creation of SLAB caches.
> > >
> > > Signed-off-by: Kunwu Chan <chentao@kylinos.cn>
> >
> > Hi Kunwu Chan,
> >
> > I think this is more of a cleanup than a fix,
> > so it should probably be targeted at 'nf-next' rather than 'net'.
> Thanks, I'm confused about when to use "nf-next" or "net" or "net-next".
> "nf-next" means fixing errors for linux-next.git and linux-stable.git, while
> "nf" or "next" just means linux-next.git?
Hi Kunwu,
nf is for fixes for Netfilter (which includes IPVS). The target tree is nf.git
nf-next is for non-fixes for Netfilter. The target tree if nf-next.git
net is for fixes for Networking code, which does not have a more specific
tree (as is the case for Netfilter). The target tree is net.git.
Liikewise, net-next is for non-fixes for Networking code.
The target tree is net-next.git
The MAINTAINERS file, and get_maintainers.pl script are useful here.
nf is merged into net on request from the Netfilter maintainers,
this is it's path to released kernels.
Likewise, nf-next is merged into net-next.
>
> >
> > If it is a fix, then I would suggest targeting it at 'nf'
> > and providing a Fixes tag.
> I'll keep it in mind in the future.
> >
> > The above notwithstanding, this looks good to me.
> >
> > Acked-by: Simon Horman <horms@kernel.org>
> >
> > > ---
> > > net/netfilter/ipvs/ip_vs_conn.c | 4 +---
> > > 1 file changed, 1 insertion(+), 3 deletions(-)
> > >
> > > diff --git a/net/netfilter/ipvs/ip_vs_conn.c b/net/netfilter/ipvs/ip_vs_conn.c
> > > index a743db073887..98d7dbe3d787 100644
> > > --- a/net/netfilter/ipvs/ip_vs_conn.c
> > > +++ b/net/netfilter/ipvs/ip_vs_conn.c
> > > @@ -1511,9 +1511,7 @@ int __init ip_vs_conn_init(void)
> > > return -ENOMEM;
> > > /* Allocate ip_vs_conn slab cache */
> > > - ip_vs_conn_cachep = kmem_cache_create("ip_vs_conn",
> > > - sizeof(struct ip_vs_conn), 0,
> > > - SLAB_HWCACHE_ALIGN, NULL);
> > > + ip_vs_conn_cachep = KMEM_CACHE(ip_vs_conn, SLAB_HWCACHE_ALIGN);
> > > if (!ip_vs_conn_cachep) {
> > > kvfree(ip_vs_conn_tab);
> > > return -ENOMEM;
> --
> Thanks,
> Kunwu
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net] ipvs: Simplify the allocation of ip_vs_conn slab caches
2024-01-19 15:20 ` Simon Horman
@ 2024-01-22 7:35 ` Kunwu Chan
0 siblings, 0 replies; 6+ messages in thread
From: Kunwu Chan @ 2024-01-22 7:35 UTC (permalink / raw)
To: Simon Horman
Cc: ja, pablo, kadlec, fw, davem, edumazet, kuba, pabeni, netdev,
lvs-devel, netfilter-devel, coreteam, linux-kernel
On 2024/1/19 23:20, Simon Horman wrote:
> On Thu, Jan 18, 2024 at 10:22:05AM +0800, Kunwu Chan wrote:
>> Hi Simon,
>>
>> Thanks for your reply.
>>
>> On 2024/1/17 17:29, Simon Horman wrote:
>>> On Wed, Jan 17, 2024 at 03:20:45PM +0800, Kunwu Chan wrote:
>>>> Use the new KMEM_CACHE() macro instead of direct kmem_cache_create
>>>> to simplify the creation of SLAB caches.
>>>>
>>>> Signed-off-by: Kunwu Chan <chentao@kylinos.cn>
>>>
>>> Hi Kunwu Chan,
>>>
>>> I think this is more of a cleanup than a fix,
>>> so it should probably be targeted at 'nf-next' rather than 'net'.
>> Thanks, I'm confused about when to use "nf-next" or "net" or "net-next".
>> "nf-next" means fixing errors for linux-next.git and linux-stable.git, while
>> "nf" or "next" just means linux-next.git?
>
> Hi Kunwu,
>
> nf is for fixes for Netfilter (which includes IPVS). The target tree is nf.git
> nf-next is for non-fixes for Netfilter. The target tree if nf-next.git
>
> net is for fixes for Networking code, which does not have a more specific
> tree (as is the case for Netfilter). The target tree is net.git.
> Liikewise, net-next is for non-fixes for Networking code.
> The target tree is net-next.git
>
Hi Simon,
Thank you very much for your detailed guidance.
In the future, I will carefully follow the rules you introduced to set
the appropriate subject for the patch.
> The MAINTAINERS file, and get_maintainers.pl script are useful here.
>
> nf is merged into net on request from the Netfilter maintainers,
> this is it's path to released kernels.
> Likewise, nf-next is merged into net-next.
>
Before send the patch, I'll read the MAINTAINERS file, and search in
email-list to confirm the correct subject.
And if need a new subject patch, i could resend a new one.
>>
>>>
>>> If it is a fix, then I would suggest targeting it at 'nf'
>>> and providing a Fixes tag.
>> I'll keep it in mind in the future.
>>>
>>> The above notwithstanding, this looks good to me.
>>>
>>> Acked-by: Simon Horman <horms@kernel.org>
>>>
>>>> ---
>>>> net/netfilter/ipvs/ip_vs_conn.c | 4 +---
>>>> 1 file changed, 1 insertion(+), 3 deletions(-)
>>>>
>>>> diff --git a/net/netfilter/ipvs/ip_vs_conn.c b/net/netfilter/ipvs/ip_vs_conn.c
>>>> index a743db073887..98d7dbe3d787 100644
>>>> --- a/net/netfilter/ipvs/ip_vs_conn.c
>>>> +++ b/net/netfilter/ipvs/ip_vs_conn.c
>>>> @@ -1511,9 +1511,7 @@ int __init ip_vs_conn_init(void)
>>>> return -ENOMEM;
>>>> /* Allocate ip_vs_conn slab cache */
>>>> - ip_vs_conn_cachep = kmem_cache_create("ip_vs_conn",
>>>> - sizeof(struct ip_vs_conn), 0,
>>>> - SLAB_HWCACHE_ALIGN, NULL);
>>>> + ip_vs_conn_cachep = KMEM_CACHE(ip_vs_conn, SLAB_HWCACHE_ALIGN);
>>>> if (!ip_vs_conn_cachep) {
>>>> kvfree(ip_vs_conn_tab);
>>>> return -ENOMEM;
>> --
>> Thanks,
>> Kunwu
>>
--
Thanks,
Kunwu
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-01-22 7:35 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-17 7:20 [PATCH net] ipvs: Simplify the allocation of ip_vs_conn slab caches Kunwu Chan
2024-01-17 9:16 ` Denis Kirjanov
2024-01-17 9:29 ` Simon Horman
2024-01-18 2:22 ` Kunwu Chan
2024-01-19 15:20 ` Simon Horman
2024-01-22 7:35 ` Kunwu Chan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).