* [PATCH] net: qrtr: start MHI channel after endpoit creation
@ 2022-04-30 10:34 Maxim Kochetkov
2022-05-03 2:35 ` Hemant Kumar
2022-07-09 6:08 ` Manivannan Sadhasivam
0 siblings, 2 replies; 5+ messages in thread
From: Maxim Kochetkov @ 2022-04-30 10:34 UTC (permalink / raw)
To: mhi; +Cc: manivannan.sadhasivam, quic_hemantk, bbhatt, Maxim Kochetkov
From: Maxim Kochetkov <mkochetkov@airspan.com>
MHI channel may generates event/interrupt right after enabling.
It may leads to 2 race conditions issues.
1)
Such event may be dropped by qcom_mhi_qrtr_dl_callback() at check:
if (!qdev || mhi_res->transaction_status)
return;
Because dev_set_drvdata(&mhi_dev->dev, qdev) may be not performed at
this moment. In this situation qrtr-ns will be unable to enumerate
services in device.
---------------------------------------------------------------
2)
Such event may come at the moment after dev_set_drvdata() and
before qrtr_endpoint_register(). In this case kernel will panic with
accessing wrong pointer at qcom_mhi_qrtr_dl_callback():
rc = qrtr_endpoint_post(&qdev->ep, mhi_res->buf_addr,
mhi_res->bytes_xferd);
Because endpoint is not created yet.
--------------------------------------------------------------
So move mhi_prepare_for_transfer_autoqueue after endpoint creation
to fix it.
Fixes: a2e2cc0dbb11 ("net: qrtr: Start MHI channels during init")
Signed-off-by: Maxim Kochetkov <mkochetkov@airspan.com>
---
net/qrtr/mhi.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/net/qrtr/mhi.c b/net/qrtr/mhi.c
index 18196e1c8c2f..17520d9e7a51 100644
--- a/net/qrtr/mhi.c
+++ b/net/qrtr/mhi.c
@@ -78,11 +78,6 @@ static int qcom_mhi_qrtr_probe(struct mhi_device *mhi_dev,
struct qrtr_mhi_dev *qdev;
int rc;
- /* start channels */
- rc = mhi_prepare_for_transfer_autoqueue(mhi_dev);
- if (rc)
- return rc;
-
qdev = devm_kzalloc(&mhi_dev->dev, sizeof(*qdev), GFP_KERNEL);
if (!qdev)
return -ENOMEM;
@@ -96,6 +91,11 @@ static int qcom_mhi_qrtr_probe(struct mhi_device *mhi_dev,
if (rc)
return rc;
+ /* start channels */
+ rc = mhi_prepare_for_transfer_autoqueue(mhi_dev);
+ if (rc)
+ return rc;
+
dev_dbg(qdev->dev, "Qualcomm MHI QRTR driver probed\n");
return 0;
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] net: qrtr: start MHI channel after endpoit creation
2022-04-30 10:34 [PATCH] net: qrtr: start MHI channel after endpoit creation Maxim Kochetkov
@ 2022-05-03 2:35 ` Hemant Kumar
2022-07-07 6:20 ` Maxim Kochetkov
2022-07-09 6:08 ` Manivannan Sadhasivam
1 sibling, 1 reply; 5+ messages in thread
From: Hemant Kumar @ 2022-05-03 2:35 UTC (permalink / raw)
To: Maxim Kochetkov, mhi; +Cc: manivannan.sadhasivam, bbhatt, Maxim Kochetkov
On 4/30/2022 3:34 AM, Maxim Kochetkov wrote:
> From: Maxim Kochetkov <mkochetkov@airspan.com>
>
> MHI channel may generates event/interrupt right after enabling.
> It may leads to 2 race conditions issues.
>
> 1)
> Such event may be dropped by qcom_mhi_qrtr_dl_callback() at check:
>
> if (!qdev || mhi_res->transaction_status)
> return;
>
> Because dev_set_drvdata(&mhi_dev->dev, qdev) may be not performed at
> this moment. In this situation qrtr-ns will be unable to enumerate
> services in device.
> ---------------------------------------------------------------
>
> 2)
> Such event may come at the moment after dev_set_drvdata() and
> before qrtr_endpoint_register(). In this case kernel will panic with
> accessing wrong pointer at qcom_mhi_qrtr_dl_callback():
>
> rc = qrtr_endpoint_post(&qdev->ep, mhi_res->buf_addr,
> mhi_res->bytes_xferd);
>
> Because endpoint is not created yet.
> --------------------------------------------------------------
> So move mhi_prepare_for_transfer_autoqueue after endpoint creation
> to fix it.
>
> Fixes: a2e2cc0dbb11 ("net: qrtr: Start MHI channels during init")
> Signed-off-by: Maxim Kochetkov <mkochetkov@airspan.com>
Reviewed-by: Hemant Kumar <quic_hemantk@quicinc.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] net: qrtr: start MHI channel after endpoit creation
2022-05-03 2:35 ` Hemant Kumar
@ 2022-07-07 6:20 ` Maxim Kochetkov
2022-07-09 6:10 ` Manivannan Sadhasivam
0 siblings, 1 reply; 5+ messages in thread
From: Maxim Kochetkov @ 2022-07-07 6:20 UTC (permalink / raw)
To: Hemant Kumar, mhi; +Cc: manivannan.sadhasivam, bbhatt, Maxim Kochetkov
On 03.05.2022 05:35, Hemant Kumar wrote:
>
> On 4/30/2022 3:34 AM, Maxim Kochetkov wrote:
>> From: Maxim Kochetkov <mkochetkov@airspan.com>
>>
>> Fixes: a2e2cc0dbb11 ("net: qrtr: Start MHI channels during init")
>> Signed-off-by: Maxim Kochetkov <mkochetkov@airspan.com>
> Reviewed-by: Hemant Kumar <quic_hemantk@quicinc.com>
Will it be merged?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] net: qrtr: start MHI channel after endpoit creation
2022-07-07 6:20 ` Maxim Kochetkov
@ 2022-07-09 6:10 ` Manivannan Sadhasivam
0 siblings, 0 replies; 5+ messages in thread
From: Manivannan Sadhasivam @ 2022-07-09 6:10 UTC (permalink / raw)
To: Maxim Kochetkov
Cc: Hemant Kumar, mhi, manivannan.sadhasivam, bbhatt, Maxim Kochetkov
On Thu, Jul 07, 2022 at 09:20:11AM +0300, Maxim Kochetkov wrote:
>
>
> On 03.05.2022 05:35, Hemant Kumar wrote:
> >
> > On 4/30/2022 3:34 AM, Maxim Kochetkov wrote:
> > > From: Maxim Kochetkov <mkochetkov@airspan.com>
> > >
> > > Fixes: a2e2cc0dbb11 ("net: qrtr: Start MHI channels during init")
> > > Signed-off-by: Maxim Kochetkov <mkochetkov@airspan.com>
> > Reviewed-by: Hemant Kumar <quic_hemantk@quicinc.com>
>
> Will it be merged?
QRTR belongs to netdev. So you need to CC netdev list and their maintainers.
Please keep the review tags while sending out next revision.
Thanks,
Mani
--
மணிவண்ணன் சதாசிவம்
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] net: qrtr: start MHI channel after endpoit creation
2022-04-30 10:34 [PATCH] net: qrtr: start MHI channel after endpoit creation Maxim Kochetkov
2022-05-03 2:35 ` Hemant Kumar
@ 2022-07-09 6:08 ` Manivannan Sadhasivam
1 sibling, 0 replies; 5+ messages in thread
From: Manivannan Sadhasivam @ 2022-07-09 6:08 UTC (permalink / raw)
To: Maxim Kochetkov
Cc: mhi, manivannan.sadhasivam, quic_hemantk, bbhatt, Maxim Kochetkov
On Sat, Apr 30, 2022 at 01:34:30PM +0300, Maxim Kochetkov wrote:
> From: Maxim Kochetkov <mkochetkov@airspan.com>
>
> MHI channel may generates event/interrupt right after enabling.
> It may leads to 2 race conditions issues.
>
> 1)
> Such event may be dropped by qcom_mhi_qrtr_dl_callback() at check:
>
> if (!qdev || mhi_res->transaction_status)
> return;
>
> Because dev_set_drvdata(&mhi_dev->dev, qdev) may be not performed at
> this moment. In this situation qrtr-ns will be unable to enumerate
> services in device.
> ---------------------------------------------------------------
>
> 2)
> Such event may come at the moment after dev_set_drvdata() and
> before qrtr_endpoint_register(). In this case kernel will panic with
> accessing wrong pointer at qcom_mhi_qrtr_dl_callback():
>
> rc = qrtr_endpoint_post(&qdev->ep, mhi_res->buf_addr,
> mhi_res->bytes_xferd);
>
> Because endpoint is not created yet.
> --------------------------------------------------------------
> So move mhi_prepare_for_transfer_autoqueue after endpoint creation
> to fix it.
>
> Fixes: a2e2cc0dbb11 ("net: qrtr: Start MHI channels during init")
> Signed-off-by: Maxim Kochetkov <mkochetkov@airspan.com>
Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>
Thanks,
Mani
> ---
> net/qrtr/mhi.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/net/qrtr/mhi.c b/net/qrtr/mhi.c
> index 18196e1c8c2f..17520d9e7a51 100644
> --- a/net/qrtr/mhi.c
> +++ b/net/qrtr/mhi.c
> @@ -78,11 +78,6 @@ static int qcom_mhi_qrtr_probe(struct mhi_device *mhi_dev,
> struct qrtr_mhi_dev *qdev;
> int rc;
>
> - /* start channels */
> - rc = mhi_prepare_for_transfer_autoqueue(mhi_dev);
> - if (rc)
> - return rc;
> -
> qdev = devm_kzalloc(&mhi_dev->dev, sizeof(*qdev), GFP_KERNEL);
> if (!qdev)
> return -ENOMEM;
> @@ -96,6 +91,11 @@ static int qcom_mhi_qrtr_probe(struct mhi_device *mhi_dev,
> if (rc)
> return rc;
>
> + /* start channels */
> + rc = mhi_prepare_for_transfer_autoqueue(mhi_dev);
> + if (rc)
> + return rc;
> +
> dev_dbg(qdev->dev, "Qualcomm MHI QRTR driver probed\n");
>
> return 0;
> --
> 2.34.1
>
--
மணிவண்ணன் சதாசிவம்
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-07-09 6:10 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-30 10:34 [PATCH] net: qrtr: start MHI channel after endpoit creation Maxim Kochetkov
2022-05-03 2:35 ` Hemant Kumar
2022-07-07 6:20 ` Maxim Kochetkov
2022-07-09 6:10 ` Manivannan Sadhasivam
2022-07-09 6:08 ` Manivannan Sadhasivam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).