[PATCH] bus: mhi: host: always print detected modem name

[PATCH] bus: mhi: host: always print detected modem name

[Koen Vandeputte]

This harmless print provides a very easy way of knowing
if the modem is detected properly during probing.

Promote it to an informational print so no hassle is required
enabling kernel debugging info to obtain it.

The rationale here is that:
On a lot of low-storage embedded devices, extensive kernel
debugging info is not always present as this would
increase it's size to much causing partition size issues.

Signed-off-by: Koen Vandeputte <koen.vandeputte@ncentric.com>
---
 drivers/bus/mhi/host/pci_generic.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c
index 9e545f2a5a26..51e2b901bae0 100644
--- a/drivers/bus/mhi/host/pci_generic.c
+++ b/drivers/bus/mhi/host/pci_generic.c
@@ -841,7 +841,7 @@ static int mhi_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id)
 	struct mhi_controller *mhi_cntrl;
 	int err;
 
-	dev_dbg(&pdev->dev, "MHI PCI device found: %s\n", info->name);
+	dev_info(&pdev->dev, "MHI PCI device found: %s\n", info->name);
 
 	/* mhi_pdev.mhi_cntrl must be zero-initialized */
 	mhi_pdev = devm_kzalloc(&pdev->dev, sizeof(*mhi_pdev), GFP_KERNEL);
-- 
2.34.1

Re: [PATCH] bus: mhi: host: always print detected modem name

[Jeffrey Hugo]

On 8/19/2022 2:36 AM, Koen Vandeputte wrote:
> This harmless print provides a very easy way of knowing
> if the modem is detected properly during probing.
> 
> Promote it to an informational print so no hassle is required
> enabling kernel debugging info to obtain it.
> 
> The rationale here is that:
> On a lot of low-storage embedded devices, extensive kernel
> debugging info is not always present as this would
> increase it's size to much causing partition size issues.

With dynamic debug, you can turn on this one specific log and nothing 
else.  Seems like it would have the same effect as this change.

> 
> Signed-off-by: Koen Vandeputte <koen.vandeputte@ncentric.com>
> ---
>   drivers/bus/mhi/host/pci_generic.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c
> index 9e545f2a5a26..51e2b901bae0 100644
> --- a/drivers/bus/mhi/host/pci_generic.c
> +++ b/drivers/bus/mhi/host/pci_generic.c
> @@ -841,7 +841,7 @@ static int mhi_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id)
>   	struct mhi_controller *mhi_cntrl;
>   	int err;
>   
> -	dev_dbg(&pdev->dev, "MHI PCI device found: %s\n", info->name);
> +	dev_info(&pdev->dev, "MHI PCI device found: %s\n", info->name);
>   
>   	/* mhi_pdev.mhi_cntrl must be zero-initialized */
>   	mhi_pdev = devm_kzalloc(&pdev->dev, sizeof(*mhi_pdev), GFP_KERNEL);

Re: [PATCH] bus: mhi: host: always print detected modem name

[Koen Vandeputte]

On 19.08.22 15:24, Jeffrey Hugo wrote:
> On 8/19/2022 2:36 AM, Koen Vandeputte wrote:
>> This harmless print provides a very easy way of knowing
>> if the modem is detected properly during probing.
>>
>> Promote it to an informational print so no hassle is required
>> enabling kernel debugging info to obtain it.
>>
>> The rationale here is that:
>> On a lot of low-storage embedded devices, extensive kernel
>> debugging info is not always present as this would
>> increase it's size to much causing partition size issues.
>
> With dynamic debug, you can turn on this one specific log and nothing 
> else.  Seems like it would have the same effect as this change.

Hi Jeffrey,

This is exactly my point.
A lot of targets using OpenWRT don't have dynamic debug featuring 
compiled-in as it enlarges the kernel too much :-)
Also, it seems pretty logical to at least simply show which modem type 
has been detected on boot.

Also, I'm currently encountering a bug using MHI on kernel 5.15.x which 
was a pain to debug without this print:
- Using a FN980v1 (which is available in the PCI list in pci_generic.c)
- The modem is always detected as generic sdx55 iso the more specific 
fn980v1 (all ID's match perfectly, and sdx55 is defined behind it, but 
still ...)
- Enabling dynamic debug on MHI parts when build as a module didn't work 
at all

I had to manually add this proposed patch to detect this wrong behavior

>
>>
>> Signed-off-by: Koen Vandeputte <koen.vandeputte@ncentric.com>
>> ---
>>   drivers/bus/mhi/host/pci_generic.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/bus/mhi/host/pci_generic.c 
>> b/drivers/bus/mhi/host/pci_generic.c
>> index 9e545f2a5a26..51e2b901bae0 100644
>> --- a/drivers/bus/mhi/host/pci_generic.c
>> +++ b/drivers/bus/mhi/host/pci_generic.c
>> @@ -841,7 +841,7 @@ static int mhi_pci_probe(struct pci_dev *pdev, 
>> const struct pci_device_id *id)
>>       struct mhi_controller *mhi_cntrl;
>>       int err;
>>   -    dev_dbg(&pdev->dev, "MHI PCI device found: %s\n", info->name);
>> +    dev_info(&pdev->dev, "MHI PCI device found: %s\n", info->name);
>>         /* mhi_pdev.mhi_cntrl must be zero-initialized */
>>       mhi_pdev = devm_kzalloc(&pdev->dev, sizeof(*mhi_pdev), 
>> GFP_KERNEL);
>

Re: [PATCH] bus: mhi: host: always print detected modem name

[Manivannan Sadhasivam]

+ Loic

On Fri, Aug 19, 2022 at 10:36:15AM +0200, Koen Vandeputte wrote:
> This harmless print provides a very easy way of knowing
> if the modem is detected properly during probing.
> 
> Promote it to an informational print so no hassle is required
> enabling kernel debugging info to obtain it.
> 
> The rationale here is that:
> On a lot of low-storage embedded devices, extensive kernel
> debugging info is not always present as this would
> increase it's size to much causing partition size issues.
> 
> Signed-off-by: Koen Vandeputte <koen.vandeputte@ncentric.com>

The justification makes sense to me.

Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

Thanks,
Mani

> ---
>  drivers/bus/mhi/host/pci_generic.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c
> index 9e545f2a5a26..51e2b901bae0 100644
> --- a/drivers/bus/mhi/host/pci_generic.c
> +++ b/drivers/bus/mhi/host/pci_generic.c
> @@ -841,7 +841,7 @@ static int mhi_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id)
>  	struct mhi_controller *mhi_cntrl;
>  	int err;
>  
> -	dev_dbg(&pdev->dev, "MHI PCI device found: %s\n", info->name);
> +	dev_info(&pdev->dev, "MHI PCI device found: %s\n", info->name);
>  
>  	/* mhi_pdev.mhi_cntrl must be zero-initialized */
>  	mhi_pdev = devm_kzalloc(&pdev->dev, sizeof(*mhi_pdev), GFP_KERNEL);
> -- 
> 2.34.1
> 
> 

-- 
மணிவண்ணன் சதாசிவம்

Re: [PATCH] bus: mhi: host: always print detected modem name

[Loic Poulain]

On Mon, 29 Aug 2022 at 19:37, Manivannan Sadhasivam
<manivannan.sadhasivam@linaro.org> wrote:
>
> + Loic
>
> On Fri, Aug 19, 2022 at 10:36:15AM +0200, Koen Vandeputte wrote:
> > This harmless print provides a very easy way of knowing
> > if the modem is detected properly during probing.
> >
> > Promote it to an informational print so no hassle is required
> > enabling kernel debugging info to obtain it.
> >
> > The rationale here is that:
> > On a lot of low-storage embedded devices, extensive kernel
> > debugging info is not always present as this would
> > increase it's size to much causing partition size issues.
> >
> > Signed-off-by: Koen Vandeputte <koen.vandeputte@ncentric.com>
>
> The justification makes sense to me.
>
> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

Fair enough.

Reviewed-by: Loic Poulain <loic.poulain@linaro.org>

>
> Thanks,
> Mani
>
> > ---
> >  drivers/bus/mhi/host/pci_generic.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c
> > index 9e545f2a5a26..51e2b901bae0 100644
> > --- a/drivers/bus/mhi/host/pci_generic.c
> > +++ b/drivers/bus/mhi/host/pci_generic.c
> > @@ -841,7 +841,7 @@ static int mhi_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id)
> >       struct mhi_controller *mhi_cntrl;
> >       int err;
> >
> > -     dev_dbg(&pdev->dev, "MHI PCI device found: %s\n", info->name);
> > +     dev_info(&pdev->dev, "MHI PCI device found: %s\n", info->name);
> >
> >       /* mhi_pdev.mhi_cntrl must be zero-initialized */
> >       mhi_pdev = devm_kzalloc(&pdev->dev, sizeof(*mhi_pdev), GFP_KERNEL);
> > --
> > 2.34.1
> >
> >
>
> --
> மணிவண்ணன் சதாசிவம்

Re: [PATCH] bus: mhi: host: always print detected modem name

[Manivannan Sadhasivam]

On Fri, Aug 19, 2022 at 10:36:15AM +0200, Koen Vandeputte wrote:
> This harmless print provides a very easy way of knowing
> if the modem is detected properly during probing.
> 
> Promote it to an informational print so no hassle is required
> enabling kernel debugging info to obtain it.
> 
> The rationale here is that:
> On a lot of low-storage embedded devices, extensive kernel
> debugging info is not always present as this would
> increase it's size to much causing partition size issues.
> 
> Signed-off-by: Koen Vandeputte <koen.vandeputte@ncentric.com>

While applying this patch, checkpatch.pl complains that the email addresses
mismatch.

From:/Signed-off-by: email address mismatch: 'From: Koen Vandeputte <koen.vandeputte@citymesh.com>'
!= 'Signed-off-by: Koen Vandeputte <koen.vandeputte@ncentric.com>'

Can you please fix it and resend?

Thanks,
Mani


> ---
>  drivers/bus/mhi/host/pci_generic.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c
> index 9e545f2a5a26..51e2b901bae0 100644
> --- a/drivers/bus/mhi/host/pci_generic.c
> +++ b/drivers/bus/mhi/host/pci_generic.c
> @@ -841,7 +841,7 @@ static int mhi_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id)
>  	struct mhi_controller *mhi_cntrl;
>  	int err;
>  
> -	dev_dbg(&pdev->dev, "MHI PCI device found: %s\n", info->name);
> +	dev_info(&pdev->dev, "MHI PCI device found: %s\n", info->name);
>  
>  	/* mhi_pdev.mhi_cntrl must be zero-initialized */
>  	mhi_pdev = devm_kzalloc(&pdev->dev, sizeof(*mhi_pdev), GFP_KERNEL);
> -- 
> 2.34.1
> 
> 

-- 
மணிவண்ணன் சதாசிவம்