[PATCH 0/2] Add a secondary AT port to the Telit FN990

[PATCH 0/2] Add a secondary AT port to the Telit FN990

[Fabio Porcedda]

In order to add a secondary AT port to the Telit FN990 first add "DUN2"
to mhi_wwan_ctrl.c, after that add a seconday AT port to the
Telit FN990 in pci_generic.c

Fabio Porcedda (2):
  net: wwan: mhi_wwan_ctrl: Add DUN2 to have a secondary AT port
  bus: mhi: host: pci_generic: Add a secondary AT port to Telit FN990

 drivers/bus/mhi/host/pci_generic.c | 2 ++
 drivers/net/wwan/mhi_wwan_ctrl.c   | 1 +
 2 files changed, 3 insertions(+)

-- 
2.37.3

[PATCH 1/2] net: wwan: mhi_wwan_ctrl: Add DUN2 to have a secondary AT port

[Fabio Porcedda]

In order to have a secondary AT port add "DUN2".

Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
---
 drivers/net/wwan/mhi_wwan_ctrl.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/wwan/mhi_wwan_ctrl.c b/drivers/net/wwan/mhi_wwan_ctrl.c
index e4d0f696687f..f7ca52353f40 100644
--- a/drivers/net/wwan/mhi_wwan_ctrl.c
+++ b/drivers/net/wwan/mhi_wwan_ctrl.c
@@ -258,6 +258,7 @@ static void mhi_wwan_ctrl_remove(struct mhi_device *mhi_dev)
 
 static const struct mhi_device_id mhi_wwan_ctrl_match_table[] = {
 	{ .chan = "DUN", .driver_data = WWAN_PORT_AT },
+	{ .chan = "DUN2", .driver_data = WWAN_PORT_AT },
 	{ .chan = "MBIM", .driver_data = WWAN_PORT_MBIM },
 	{ .chan = "QMI", .driver_data = WWAN_PORT_QMI },
 	{ .chan = "DIAG", .driver_data = WWAN_PORT_QCDM },
-- 
2.37.3

[PATCH 2/2] bus: mhi: host: pci_generic: Add a secondary AT port to Telit FN990

[Fabio Porcedda]

Add a secondary AT port using one of OEM reserved channel.

Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
---
 drivers/bus/mhi/host/pci_generic.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c
index 51e2b901bae0..caa4ce28cf9e 100644
--- a/drivers/bus/mhi/host/pci_generic.c
+++ b/drivers/bus/mhi/host/pci_generic.c
@@ -507,6 +507,8 @@ static const struct mhi_channel_config mhi_telit_fn990_channels[] = {
 	MHI_CHANNEL_CONFIG_DL(13, "MBIM", 32, 0),
 	MHI_CHANNEL_CONFIG_UL(32, "DUN", 32, 0),
 	MHI_CHANNEL_CONFIG_DL(33, "DUN", 32, 0),
+	MHI_CHANNEL_CONFIG_UL(92, "DUN2", 32, 1),
+	MHI_CHANNEL_CONFIG_DL(93, "DUN2", 32, 1),
 	MHI_CHANNEL_CONFIG_HW_UL(100, "IP_HW0_MBIM", 128, 2),
 	MHI_CHANNEL_CONFIG_HW_DL(101, "IP_HW0_MBIM", 128, 3),
 };
-- 
2.37.3

Re: [PATCH 0/2] Add a secondary AT port to the Telit FN990

[Sergey Ryazanov]

Hello Fabio,

On Fri, Sep 16, 2022 at 5:43 PM Fabio Porcedda <fabio.porcedda@gmail.com> wrote:
> In order to add a secondary AT port to the Telit FN990 first add "DUN2"
> to mhi_wwan_ctrl.c, after that add a seconday AT port to the
> Telit FN990 in pci_generic.c
>
> Fabio Porcedda (2):
>   net: wwan: mhi_wwan_ctrl: Add DUN2 to have a secondary AT port
>   bus: mhi: host: pci_generic: Add a secondary AT port to Telit FN990

The code looks good to me, but it needs to be checked by someone who
is familiar with MHI.

Loic, what do you think?

-- 
Sergey

Re: [PATCH 1/2] net: wwan: mhi_wwan_ctrl: Add DUN2 to have a secondary AT port

[Loic Poulain]

On Fri, 16 Sept 2022 at 16:43, Fabio Porcedda <fabio.porcedda@gmail.com> wrote:
>
> In order to have a secondary AT port add "DUN2".
>
> Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>

Reviewed-by: Loic Poulain <loic.poulain@linaro.org>

> ---
>  drivers/net/wwan/mhi_wwan_ctrl.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/wwan/mhi_wwan_ctrl.c b/drivers/net/wwan/mhi_wwan_ctrl.c
> index e4d0f696687f..f7ca52353f40 100644
> --- a/drivers/net/wwan/mhi_wwan_ctrl.c
> +++ b/drivers/net/wwan/mhi_wwan_ctrl.c
> @@ -258,6 +258,7 @@ static void mhi_wwan_ctrl_remove(struct mhi_device *mhi_dev)
>
>  static const struct mhi_device_id mhi_wwan_ctrl_match_table[] = {
>         { .chan = "DUN", .driver_data = WWAN_PORT_AT },
> +       { .chan = "DUN2", .driver_data = WWAN_PORT_AT },
>         { .chan = "MBIM", .driver_data = WWAN_PORT_MBIM },
>         { .chan = "QMI", .driver_data = WWAN_PORT_QMI },
>         { .chan = "DIAG", .driver_data = WWAN_PORT_QCDM },
> --
> 2.37.3
>

Re: [PATCH 2/2] bus: mhi: host: pci_generic: Add a secondary AT port to Telit FN990

[Loic Poulain]

On Fri, 16 Sept 2022 at 16:43, Fabio Porcedda <fabio.porcedda@gmail.com> wrote:
>
> Add a secondary AT port using one of OEM reserved channel.
>
> Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>

Reviewed-by: Loic Poulain <loic.poulain@linaro.org>

> ---
>  drivers/bus/mhi/host/pci_generic.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c
> index 51e2b901bae0..caa4ce28cf9e 100644
> --- a/drivers/bus/mhi/host/pci_generic.c
> +++ b/drivers/bus/mhi/host/pci_generic.c
> @@ -507,6 +507,8 @@ static const struct mhi_channel_config mhi_telit_fn990_channels[] = {
>         MHI_CHANNEL_CONFIG_DL(13, "MBIM", 32, 0),
>         MHI_CHANNEL_CONFIG_UL(32, "DUN", 32, 0),
>         MHI_CHANNEL_CONFIG_DL(33, "DUN", 32, 0),
> +       MHI_CHANNEL_CONFIG_UL(92, "DUN2", 32, 1),
> +       MHI_CHANNEL_CONFIG_DL(93, "DUN2", 32, 1),
>         MHI_CHANNEL_CONFIG_HW_UL(100, "IP_HW0_MBIM", 128, 2),
>         MHI_CHANNEL_CONFIG_HW_DL(101, "IP_HW0_MBIM", 128, 3),
>  };
> --
> 2.37.3
>

Re: [PATCH 0/2] Add a secondary AT port to the Telit FN990

[patchwork-bot+netdevbpf]

Hello:

This series was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:

On Fri, 16 Sep 2022 16:43:27 +0200 you wrote:
> In order to add a secondary AT port to the Telit FN990 first add "DUN2"
> to mhi_wwan_ctrl.c, after that add a seconday AT port to the
> Telit FN990 in pci_generic.c
> 
> Fabio Porcedda (2):
>   net: wwan: mhi_wwan_ctrl: Add DUN2 to have a secondary AT port
>   bus: mhi: host: pci_generic: Add a secondary AT port to Telit FN990
> 
> [...]

Here is the summary with links:
  - [1/2] net: wwan: mhi_wwan_ctrl: Add DUN2 to have a secondary AT port
    https://git.kernel.org/netdev/net-next/c/0c60d1657d3d
  - [2/2] bus: mhi: host: pci_generic: Add a secondary AT port to Telit FN990
    https://git.kernel.org/netdev/net-next/c/479aa3b0ec2e

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Re: [PATCH 2/2] bus: mhi: host: pci_generic: Add a secondary AT port to Telit FN990

[Manivannan Sadhasivam]

On Fri, Sep 16, 2022 at 04:43:29PM +0200, Fabio Porcedda wrote:
> Add a secondary AT port using one of OEM reserved channel.
> 
> Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>

Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>

Thanks,
Mani

> ---
>  drivers/bus/mhi/host/pci_generic.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c
> index 51e2b901bae0..caa4ce28cf9e 100644
> --- a/drivers/bus/mhi/host/pci_generic.c
> +++ b/drivers/bus/mhi/host/pci_generic.c
> @@ -507,6 +507,8 @@ static const struct mhi_channel_config mhi_telit_fn990_channels[] = {
>  	MHI_CHANNEL_CONFIG_DL(13, "MBIM", 32, 0),
>  	MHI_CHANNEL_CONFIG_UL(32, "DUN", 32, 0),
>  	MHI_CHANNEL_CONFIG_DL(33, "DUN", 32, 0),
> +	MHI_CHANNEL_CONFIG_UL(92, "DUN2", 32, 1),
> +	MHI_CHANNEL_CONFIG_DL(93, "DUN2", 32, 1),
>  	MHI_CHANNEL_CONFIG_HW_UL(100, "IP_HW0_MBIM", 128, 2),
>  	MHI_CHANNEL_CONFIG_HW_DL(101, "IP_HW0_MBIM", 128, 3),
>  };
> -- 
> 2.37.3
> 
> 

-- 
மணிவண்ணன் சதாசிவம்

Re: [PATCH 2/2] bus: mhi: host: pci_generic: Add a secondary AT port to Telit FN990

[Manivannan Sadhasivam]

On Fri, Sep 16, 2022 at 04:43:29PM +0200, Fabio Porcedda wrote:
> Add a secondary AT port using one of OEM reserved channel.
> 
> Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>

Applied to mhi-next!

Thanks,
Mani

> ---
>  drivers/bus/mhi/host/pci_generic.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c
> index 51e2b901bae0..caa4ce28cf9e 100644
> --- a/drivers/bus/mhi/host/pci_generic.c
> +++ b/drivers/bus/mhi/host/pci_generic.c
> @@ -507,6 +507,8 @@ static const struct mhi_channel_config mhi_telit_fn990_channels[] = {
>  	MHI_CHANNEL_CONFIG_DL(13, "MBIM", 32, 0),
>  	MHI_CHANNEL_CONFIG_UL(32, "DUN", 32, 0),
>  	MHI_CHANNEL_CONFIG_DL(33, "DUN", 32, 0),
> +	MHI_CHANNEL_CONFIG_UL(92, "DUN2", 32, 1),
> +	MHI_CHANNEL_CONFIG_DL(93, "DUN2", 32, 1),
>  	MHI_CHANNEL_CONFIG_HW_UL(100, "IP_HW0_MBIM", 128, 2),
>  	MHI_CHANNEL_CONFIG_HW_DL(101, "IP_HW0_MBIM", 128, 3),
>  };
> -- 
> 2.37.3
> 
> 

-- 
மணிவண்ணன் சதாசிவம்