[PATCH v2] bus: mhi: host: pci_generic: Add HP variant of T99W175

[PATCH v2] bus: mhi: host: pci_generic: Add HP variant of T99W175

[Song Fuchang]

The Foxconn T99W175 modem has an HP variant, which has
the following output from lspci:

   01:00.0 Wireless controller [0d40]: Device 03f0:0a6c

It also has some HP-specific serial numbers on the
metal case. It works well with this driver, so add
support for this to the pci_generic driver.

Signed-off-by: Song Fuchang <song.fc@gmail.com>
---

Changes in v2:

   - Add more detailed commit message.


  drivers/bus/mhi/host/pci_generic.c | 3 +++
  1 file changed, 3 insertions(+)

diff --git a/drivers/bus/mhi/host/pci_generic.c 
b/drivers/bus/mhi/host/pci_generic.c
index 9e545f2a5a26..650e8b9c26ad 100644
--- a/drivers/bus/mhi/host/pci_generic.c
+++ b/drivers/bus/mhi/host/pci_generic.c
@@ -592,6 +592,9 @@ static const struct pci_device_id mhi_pci_id_table[] = {
         /* MV32-WB (Cinterion) */
         { PCI_DEVICE(0x1269, 0x00bb),
                 .driver_data = (kernel_ulong_t) &mhi_mv32_info },
+       /* T99W175 (sdx55), HP variant */
+       { PCI_DEVICE(0x03f0, 0x0a6c),
+               .driver_data = (kernel_ulong_t) &mhi_foxconn_sdx55_info },
         {  }
  };
  MODULE_DEVICE_TABLE(pci, mhi_pci_id_table);
-- 
2.37.3

Re: [PATCH v2] bus: mhi: host: pci_generic: Add HP variant of T99W175

[Manivannan Sadhasivam]

On Tue, Nov 01, 2022 at 08:59:29PM +0800, Song Fuchang wrote:
> The Foxconn T99W175 modem has an HP variant, which has
> the following output from lspci:
> 
>   01:00.0 Wireless controller [0d40]: Device 03f0:0a6c
> 
> It also has some HP-specific serial numbers on the
> metal case. It works well with this driver, so add
> support for this to the pci_generic driver.
> 
> Signed-off-by: Song Fuchang <song.fc@gmail.com>

Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>

Thanks,
Mani

> ---
> 
> Changes in v2:
> 
>   - Add more detailed commit message.
> 
> 
>  drivers/bus/mhi/host/pci_generic.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/bus/mhi/host/pci_generic.c
> b/drivers/bus/mhi/host/pci_generic.c
> index 9e545f2a5a26..650e8b9c26ad 100644
> --- a/drivers/bus/mhi/host/pci_generic.c
> +++ b/drivers/bus/mhi/host/pci_generic.c
> @@ -592,6 +592,9 @@ static const struct pci_device_id mhi_pci_id_table[] = {
>         /* MV32-WB (Cinterion) */
>         { PCI_DEVICE(0x1269, 0x00bb),
>                 .driver_data = (kernel_ulong_t) &mhi_mv32_info },
> +       /* T99W175 (sdx55), HP variant */
> +       { PCI_DEVICE(0x03f0, 0x0a6c),
> +               .driver_data = (kernel_ulong_t) &mhi_foxconn_sdx55_info },
>         {  }
>  };
>  MODULE_DEVICE_TABLE(pci, mhi_pci_id_table);
> -- 
> 2.37.3
> 
> 

-- 
மணிவண்ணன் சதாசிவம்

Re: [PATCH v2] bus: mhi: host: pci_generic: Add HP variant of T99W175

[Manivannan Sadhasivam]

On Tue, Nov 01, 2022 at 08:59:29PM +0800, Song Fuchang wrote:
> The Foxconn T99W175 modem has an HP variant, which has
> the following output from lspci:
> 
>   01:00.0 Wireless controller [0d40]: Device 03f0:0a6c
> 
> It also has some HP-specific serial numbers on the
> metal case. It works well with this driver, so add
> support for this to the pci_generic driver.
> 
> Signed-off-by: Song Fuchang <song.fc@gmail.com>

I cannot apply this patch using git am. Diff header seems to be mangled.

"error: git diff header lacks filename information when removing 1 leading pathname component (line 12)"

Please fix it and resend.

Thanks,
Mani

> ---
> 
> Changes in v2:
> 
>   - Add more detailed commit message.
> 
> 
>  drivers/bus/mhi/host/pci_generic.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/bus/mhi/host/pci_generic.c
> b/drivers/bus/mhi/host/pci_generic.c
> index 9e545f2a5a26..650e8b9c26ad 100644
> --- a/drivers/bus/mhi/host/pci_generic.c
> +++ b/drivers/bus/mhi/host/pci_generic.c
> @@ -592,6 +592,9 @@ static const struct pci_device_id mhi_pci_id_table[] = {
>         /* MV32-WB (Cinterion) */
>         { PCI_DEVICE(0x1269, 0x00bb),
>                 .driver_data = (kernel_ulong_t) &mhi_mv32_info },
> +       /* T99W175 (sdx55), HP variant */
> +       { PCI_DEVICE(0x03f0, 0x0a6c),
> +               .driver_data = (kernel_ulong_t) &mhi_foxconn_sdx55_info },
>         {  }
>  };
>  MODULE_DEVICE_TABLE(pci, mhi_pci_id_table);
> -- 
> 2.37.3
> 
> 

-- 
மணிவண்ணன் சதாசிவம்