* [PATCH v2] mhi: pci_generic: add support for sc8280xp-crd SDX55 variant
@ 2022-11-04 9:39 Johan Hovold
2022-11-07 7:41 ` Manivannan Sadhasivam
2022-11-07 11:42 ` Manivannan Sadhasivam
0 siblings, 2 replies; 3+ messages in thread
From: Johan Hovold @ 2022-11-04 9:39 UTC (permalink / raw)
To: Manivannan Sadhasivam
Cc: Hemant Kumar, mhi, linux-arm-msm, linux-kernel, Johan Hovold
The SC8280XP Compute Reference Design (CRD) has an on-PCB SDX55 modem
which uses MBIM.
The exact channel configuration is not known but the Foxconn SDX55
configuration allows the modem to be used so reuse that one for now.
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
Changes in v2
- drop comment describing this variant (Mani)
drivers/bus/mhi/host/pci_generic.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c
index caa4ce28cf9e..7dcd0ef3184a 100644
--- a/drivers/bus/mhi/host/pci_generic.c
+++ b/drivers/bus/mhi/host/pci_generic.c
@@ -542,6 +542,8 @@ static const struct mhi_pci_dev_info mhi_telit_fn990_info = {
static const struct pci_device_id mhi_pci_id_table[] = {
{ PCI_DEVICE(PCI_VENDOR_ID_QCOM, 0x0304),
.driver_data = (kernel_ulong_t) &mhi_qcom_sdx24_info },
+ { PCI_DEVICE_SUB(PCI_VENDOR_ID_QCOM, 0x0306, PCI_VENDOR_ID_QCOM, 0x010c),
+ .driver_data = (kernel_ulong_t) &mhi_foxconn_sdx55_info },
/* EM919x (sdx55), use the same vid:pid as qcom-sdx55m */
{ PCI_DEVICE_SUB(PCI_VENDOR_ID_QCOM, 0x0306, 0x18d7, 0x0200),
.driver_data = (kernel_ulong_t) &mhi_sierra_em919x_info },
--
2.37.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] mhi: pci_generic: add support for sc8280xp-crd SDX55 variant
2022-11-04 9:39 [PATCH v2] mhi: pci_generic: add support for sc8280xp-crd SDX55 variant Johan Hovold
@ 2022-11-07 7:41 ` Manivannan Sadhasivam
2022-11-07 11:42 ` Manivannan Sadhasivam
1 sibling, 0 replies; 3+ messages in thread
From: Manivannan Sadhasivam @ 2022-11-07 7:41 UTC (permalink / raw)
To: Johan Hovold; +Cc: Hemant Kumar, mhi, linux-arm-msm, linux-kernel
On Fri, Nov 04, 2022 at 10:39:13AM +0100, Johan Hovold wrote:
> The SC8280XP Compute Reference Design (CRD) has an on-PCB SDX55 modem
> which uses MBIM.
>
> The exact channel configuration is not known but the Foxconn SDX55
> configuration allows the modem to be used so reuse that one for now.
>
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>
Thanks,
Mani
> ---
>
> Changes in v2
> - drop comment describing this variant (Mani)
>
>
> drivers/bus/mhi/host/pci_generic.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c
> index caa4ce28cf9e..7dcd0ef3184a 100644
> --- a/drivers/bus/mhi/host/pci_generic.c
> +++ b/drivers/bus/mhi/host/pci_generic.c
> @@ -542,6 +542,8 @@ static const struct mhi_pci_dev_info mhi_telit_fn990_info = {
> static const struct pci_device_id mhi_pci_id_table[] = {
> { PCI_DEVICE(PCI_VENDOR_ID_QCOM, 0x0304),
> .driver_data = (kernel_ulong_t) &mhi_qcom_sdx24_info },
> + { PCI_DEVICE_SUB(PCI_VENDOR_ID_QCOM, 0x0306, PCI_VENDOR_ID_QCOM, 0x010c),
> + .driver_data = (kernel_ulong_t) &mhi_foxconn_sdx55_info },
> /* EM919x (sdx55), use the same vid:pid as qcom-sdx55m */
> { PCI_DEVICE_SUB(PCI_VENDOR_ID_QCOM, 0x0306, 0x18d7, 0x0200),
> .driver_data = (kernel_ulong_t) &mhi_sierra_em919x_info },
> --
> 2.37.3
>
>
--
மணிவண்ணன் சதாசிவம்
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] mhi: pci_generic: add support for sc8280xp-crd SDX55 variant
2022-11-04 9:39 [PATCH v2] mhi: pci_generic: add support for sc8280xp-crd SDX55 variant Johan Hovold
2022-11-07 7:41 ` Manivannan Sadhasivam
@ 2022-11-07 11:42 ` Manivannan Sadhasivam
1 sibling, 0 replies; 3+ messages in thread
From: Manivannan Sadhasivam @ 2022-11-07 11:42 UTC (permalink / raw)
To: Johan Hovold; +Cc: Hemant Kumar, mhi, linux-arm-msm, linux-kernel
On Fri, Nov 04, 2022 at 10:39:13AM +0100, Johan Hovold wrote:
> The SC8280XP Compute Reference Design (CRD) has an on-PCB SDX55 modem
> which uses MBIM.
>
> The exact channel configuration is not known but the Foxconn SDX55
> configuration allows the modem to be used so reuse that one for now.
>
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
Modified the subject to the format "bus: mhi: host: pci_generic" and applied
to mhi-next!
Thanks,
Mani
> ---
>
> Changes in v2
> - drop comment describing this variant (Mani)
>
>
> drivers/bus/mhi/host/pci_generic.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c
> index caa4ce28cf9e..7dcd0ef3184a 100644
> --- a/drivers/bus/mhi/host/pci_generic.c
> +++ b/drivers/bus/mhi/host/pci_generic.c
> @@ -542,6 +542,8 @@ static const struct mhi_pci_dev_info mhi_telit_fn990_info = {
> static const struct pci_device_id mhi_pci_id_table[] = {
> { PCI_DEVICE(PCI_VENDOR_ID_QCOM, 0x0304),
> .driver_data = (kernel_ulong_t) &mhi_qcom_sdx24_info },
> + { PCI_DEVICE_SUB(PCI_VENDOR_ID_QCOM, 0x0306, PCI_VENDOR_ID_QCOM, 0x010c),
> + .driver_data = (kernel_ulong_t) &mhi_foxconn_sdx55_info },
> /* EM919x (sdx55), use the same vid:pid as qcom-sdx55m */
> { PCI_DEVICE_SUB(PCI_VENDOR_ID_QCOM, 0x0306, 0x18d7, 0x0200),
> .driver_data = (kernel_ulong_t) &mhi_sierra_em919x_info },
> --
> 2.37.3
>
>
--
மணிவண்ணன் சதாசிவம்
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-11-07 11:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-04 9:39 [PATCH v2] mhi: pci_generic: add support for sc8280xp-crd SDX55 variant Johan Hovold
2022-11-07 7:41 ` Manivannan Sadhasivam
2022-11-07 11:42 ` Manivannan Sadhasivam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).