mhi.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
* [GIT PULL] MHI changes for v6.3
@ 2023-01-30  8:21 Manivannan Sadhasivam
  2023-02-02 15:54 ` Greg KH
  0 siblings, 1 reply; 5+ messages in thread
From: Manivannan Sadhasivam @ 2023-01-30  8:21 UTC (permalink / raw)
  To: gregkh; +Cc: mhi, quic_carlv, slark_xiao, error27

The following changes since commit 1b929c02afd37871d5afb9d498426f83432e71c2:

  Linux 6.2-rc1 (2022-12-25 13:41:39 -0800)

are available in the Git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/mani/mhi.git tags/mhi-for-v6.3

for you to fetch changes up to 62c0f48fa940d5c9f96b55b79c6c1b9cec6d0d45:

  bus: mhi: ep: Fix off by one in mhi_ep_process_cmd_ring() (2023-01-27 12:31:42 +0530)

----------------------------------------------------------------
MHI Host
========

- Fixed the module description

MHI Endpoint
============

- Powered down the MHI EP stack completely during MHI RESET instead of just
  doing transfer abort as the MMIO register access will be prohibited
  afterwards. EP stack will also be powered on again in case the RESET
  happened due to SYS_ERR.

- Added a sanity check before processing the command ring to make sure that
  the channel is supported by the controller.

- Added a check to make sure the xfer_cb is available for the channel
  before trying to send the error status to the client drivers. This
  helps in avoiding a potential null pointer dereference.

- Fixed the debug log of RESET command

- Modified the channel ring handler lock to protect the whole handler
  instead of locking it partially. This helps in avoiding a race that may
  happen if a channel STOP/RESET command is issued by the host parallely.

- Saved the MHI state locally during suspend and resume. Otherwise, the MHI
  EP stack will not be aware of a channel that got disabled and may try to
  access it later.

- Changed the MHI state_lock to mutex instead of spinlock. This helps in
  avoiding the sleeping in atomic bug reported by Dan Carpenter and also
  allows the lock to be held throughout the state change.

- Fixed the off by one error while doing the MHI channel check during
  command ring processing.

MHI Generic
===========

- Updated the MHI toplevel Makefile to use Kconfig flags for building the
  host and endpoint sub-directories conditionally.

----------------------------------------------------------------
Carl Vanderlip (1):
      bus: mhi: Update Makefile to used Kconfig flags

Dan Carpenter (1):
      bus: mhi: ep: Fix off by one in mhi_ep_process_cmd_ring()

Manivannan Sadhasivam (7):
      bus: mhi: ep: Power up/down MHI stack during MHI RESET
      bus: mhi: ep: Check if the channel is supported by the controller
      bus: mhi: ep: Only send -ENOTCONN status if client driver is available
      bus: mhi: ep: Fix the debug message for MHI_PKT_TYPE_RESET_CHAN_CMD cmd
      bus: mhi: ep: Move chan->lock to the start of processing queued ch ring
      bus: mhi: ep: Save channel state locally during suspend and resume
      bus: mhi: ep: Change state_lock to mutex

Slark Xiao (1):
      bus: mhi: host: Update mhi driver description

 drivers/bus/mhi/Makefile    |  4 ++--
 drivers/bus/mhi/ep/main.c   | 85 ++++++++++++++++++++++++++++++++++++++++++++++---------------------------------------
 drivers/bus/mhi/ep/sm.c     | 42 ++++++++++++++++++++++++------------------
 drivers/bus/mhi/host/init.c |  2 +-
 include/linux/mhi_ep.h      |  4 ++--
 5 files changed, 75 insertions(+), 62 deletions(-)

-- 
மணிவண்ணன் சதாசிவம்

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [GIT PULL] MHI changes for v6.3
  2023-01-30  8:21 [GIT PULL] MHI changes for v6.3 Manivannan Sadhasivam
@ 2023-02-02 15:54 ` Greg KH
  2023-02-02 16:17   ` Dan Carpenter
  2023-02-02 17:28   ` Manivannan Sadhasivam
  0 siblings, 2 replies; 5+ messages in thread
From: Greg KH @ 2023-02-02 15:54 UTC (permalink / raw)
  To: Manivannan Sadhasivam; +Cc: mhi, quic_carlv, slark_xiao, error27

On Mon, Jan 30, 2023 at 01:51:31PM +0530, Manivannan Sadhasivam wrote:
> The following changes since commit 1b929c02afd37871d5afb9d498426f83432e71c2:
> 
>   Linux 6.2-rc1 (2022-12-25 13:41:39 -0800)
> 
> are available in the Git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/mani/mhi.git tags/mhi-for-v6.3

I get the following error when pulling this in and trying to push it
out:

Commit: 62c0f48fa940 ("bus: mhi: ep: Fix off by one in mhi_ep_process_cmd_ring()")
	Fixes tag: Fixes: 2527ad44ddb2 ("bus: mhi: ep: Check if the channel is supported by the controller")
	Has these problem(s):
		- Target SHA1 does not exist


Didn't you get this error also from linux-next?  I use the same scripts as they
have.

Please fix up and resend.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [GIT PULL] MHI changes for v6.3
  2023-02-02 15:54 ` Greg KH
@ 2023-02-02 16:17   ` Dan Carpenter
  2023-02-02 17:29     ` Manivannan Sadhasivam
  2023-02-02 17:28   ` Manivannan Sadhasivam
  1 sibling, 1 reply; 5+ messages in thread
From: Dan Carpenter @ 2023-02-02 16:17 UTC (permalink / raw)
  To: Greg KH; +Cc: Manivannan Sadhasivam, mhi, quic_carlv, slark_xiao

On Thu, Feb 02, 2023 at 04:54:54PM +0100, Greg KH wrote:
> On Mon, Jan 30, 2023 at 01:51:31PM +0530, Manivannan Sadhasivam wrote:
> > The following changes since commit 1b929c02afd37871d5afb9d498426f83432e71c2:
> > 
> >   Linux 6.2-rc1 (2022-12-25 13:41:39 -0800)
> > 
> > are available in the Git repository at:
> > 
> >   git://git.kernel.org/pub/scm/linux/kernel/git/mani/mhi.git tags/mhi-for-v6.3
> 
> I get the following error when pulling this in and trying to push it
> out:
> 
> Commit: 62c0f48fa940 ("bus: mhi: ep: Fix off by one in mhi_ep_process_cmd_ring()")
> 	Fixes tag: Fixes: 2527ad44ddb2 ("bus: mhi: ep: Check if the channel is supported by the controller")
> 	Has these problem(s):
> 		- Target SHA1 does not exist
> 
> 
> Didn't you get this error also from linux-next?  I use the same scripts as they
> have.
> 
> Please fix up and resend.

Somebody must have done a rebase.  It's now:

Fixes: 6de4941c0215 ("bus: mhi: ep: Check if the channel is supported by the controller")

Manivannan, can you take care of that?

regards,
dan carpenter


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [GIT PULL] MHI changes for v6.3
  2023-02-02 15:54 ` Greg KH
  2023-02-02 16:17   ` Dan Carpenter
@ 2023-02-02 17:28   ` Manivannan Sadhasivam
  1 sibling, 0 replies; 5+ messages in thread
From: Manivannan Sadhasivam @ 2023-02-02 17:28 UTC (permalink / raw)
  To: Greg KH; +Cc: Manivannan Sadhasivam, mhi, quic_carlv, slark_xiao, error27

On Thu, Feb 02, 2023 at 04:54:54PM +0100, Greg KH wrote:
> On Mon, Jan 30, 2023 at 01:51:31PM +0530, Manivannan Sadhasivam wrote:
> > The following changes since commit 1b929c02afd37871d5afb9d498426f83432e71c2:
> > 
> >   Linux 6.2-rc1 (2022-12-25 13:41:39 -0800)
> > 
> > are available in the Git repository at:
> > 
> >   git://git.kernel.org/pub/scm/linux/kernel/git/mani/mhi.git tags/mhi-for-v6.3
> 
> I get the following error when pulling this in and trying to push it
> out:
> 
> Commit: 62c0f48fa940 ("bus: mhi: ep: Fix off by one in mhi_ep_process_cmd_ring()")
> 	Fixes tag: Fixes: 2527ad44ddb2 ("bus: mhi: ep: Check if the channel is supported by the controller")
> 	Has these problem(s):
> 		- Target SHA1 does not exist
>

Oops. Looks like a mistake from my end, sorry.
 
> 
> Didn't you get this error also from linux-next?  I use the same scripts as they
> have.
> 

No, I did not see the error from linux-next yet.

> Please fix up and resend.
> 

Done!

Thanks,
Mani

> thanks,
> 
> greg k-h
> 

-- 
மணிவண்ணன் சதாசிவம்

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [GIT PULL] MHI changes for v6.3
  2023-02-02 16:17   ` Dan Carpenter
@ 2023-02-02 17:29     ` Manivannan Sadhasivam
  0 siblings, 0 replies; 5+ messages in thread
From: Manivannan Sadhasivam @ 2023-02-02 17:29 UTC (permalink / raw)
  To: Dan Carpenter; +Cc: Greg KH, mhi, quic_carlv, slark_xiao

On Thu, Feb 02, 2023 at 07:17:14PM +0300, Dan Carpenter wrote:
> On Thu, Feb 02, 2023 at 04:54:54PM +0100, Greg KH wrote:
> > On Mon, Jan 30, 2023 at 01:51:31PM +0530, Manivannan Sadhasivam wrote:
> > > The following changes since commit 1b929c02afd37871d5afb9d498426f83432e71c2:
> > > 
> > >   Linux 6.2-rc1 (2022-12-25 13:41:39 -0800)
> > > 
> > > are available in the Git repository at:
> > > 
> > >   git://git.kernel.org/pub/scm/linux/kernel/git/mani/mhi.git tags/mhi-for-v6.3
> > 
> > I get the following error when pulling this in and trying to push it
> > out:
> > 
> > Commit: 62c0f48fa940 ("bus: mhi: ep: Fix off by one in mhi_ep_process_cmd_ring()")
> > 	Fixes tag: Fixes: 2527ad44ddb2 ("bus: mhi: ep: Check if the channel is supported by the controller")
> > 	Has these problem(s):
> > 		- Target SHA1 does not exist
> > 
> > 
> > Didn't you get this error also from linux-next?  I use the same scripts as they
> > have.
> > 
> > Please fix up and resend.
> 
> Somebody must have done a rebase.  It's now:
> 
> Fixes: 6de4941c0215 ("bus: mhi: ep: Check if the channel is supported by the controller")
> 
> Manivannan, can you take care of that?
> 

Sent v2. That's a mistake from my end, sorry.

Thanks,
Mani

> regards,
> dan carpenter
> 
> 

-- 
மணிவண்ணன் சதாசிவம்

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2023-02-02 17:29 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-30  8:21 [GIT PULL] MHI changes for v6.3 Manivannan Sadhasivam
2023-02-02 15:54 ` Greg KH
2023-02-02 16:17   ` Dan Carpenter
2023-02-02 17:29     ` Manivannan Sadhasivam
2023-02-02 17:28   ` Manivannan Sadhasivam

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).