* [PATCH] bus: mhi: host: Remove mhi_poll() API
@ 2023-02-24 12:01 Manivannan Sadhasivam
2023-02-24 14:43 ` Jeffrey Hugo
2023-03-07 16:35 ` Manivannan Sadhasivam
0 siblings, 2 replies; 3+ messages in thread
From: Manivannan Sadhasivam @ 2023-02-24 12:01 UTC (permalink / raw)
To: mhi; +Cc: quic_jhugo, quic_vpernami, Manivannan Sadhasivam
mhi_poll() API is not used within the MHI stack and also not by any client
drivers in mainline. So let's remove it until any consumer is available.
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
drivers/bus/mhi/host/main.c | 15 ---------------
include/linux/mhi.h | 7 -------
2 files changed, 22 deletions(-)
diff --git a/drivers/bus/mhi/host/main.c b/drivers/bus/mhi/host/main.c
index df0fbfee7b78..4fa0969472fc 100644
--- a/drivers/bus/mhi/host/main.c
+++ b/drivers/bus/mhi/host/main.c
@@ -1679,18 +1679,3 @@ void mhi_unprepare_from_transfer(struct mhi_device *mhi_dev)
}
}
EXPORT_SYMBOL_GPL(mhi_unprepare_from_transfer);
-
-int mhi_poll(struct mhi_device *mhi_dev, u32 budget)
-{
- struct mhi_controller *mhi_cntrl = mhi_dev->mhi_cntrl;
- struct mhi_chan *mhi_chan = mhi_dev->dl_chan;
- struct mhi_event *mhi_event = &mhi_cntrl->mhi_event[mhi_chan->er_index];
- int ret;
-
- spin_lock_bh(&mhi_event->lock);
- ret = mhi_event->process_event(mhi_cntrl, mhi_event, budget);
- spin_unlock_bh(&mhi_event->lock);
-
- return ret;
-}
-EXPORT_SYMBOL_GPL(mhi_poll);
diff --git a/include/linux/mhi.h b/include/linux/mhi.h
index a5441ad33c74..f6de4b6ecfc7 100644
--- a/include/linux/mhi.h
+++ b/include/linux/mhi.h
@@ -765,13 +765,6 @@ int mhi_prepare_for_transfer_autoqueue(struct mhi_device *mhi_dev);
*/
void mhi_unprepare_from_transfer(struct mhi_device *mhi_dev);
-/**
- * mhi_poll - Poll for any available data in DL direction
- * @mhi_dev: Device associated with the channels
- * @budget: # of events to process
- */
-int mhi_poll(struct mhi_device *mhi_dev, u32 budget);
-
/**
* mhi_queue_dma - Send or receive DMA mapped buffers from client device
* over MHI channel
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] bus: mhi: host: Remove mhi_poll() API
2023-02-24 12:01 [PATCH] bus: mhi: host: Remove mhi_poll() API Manivannan Sadhasivam
@ 2023-02-24 14:43 ` Jeffrey Hugo
2023-03-07 16:35 ` Manivannan Sadhasivam
1 sibling, 0 replies; 3+ messages in thread
From: Jeffrey Hugo @ 2023-02-24 14:43 UTC (permalink / raw)
To: Manivannan Sadhasivam, mhi; +Cc: quic_vpernami
On 2/24/2023 5:01 AM, Manivannan Sadhasivam wrote:
> mhi_poll() API is not used within the MHI stack and also not by any client
> drivers in mainline. So let's remove it until any consumer is available.
>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Reviewed-by: Jeffrey Hugo <quic_jhugo@quicinc.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] bus: mhi: host: Remove mhi_poll() API
2023-02-24 12:01 [PATCH] bus: mhi: host: Remove mhi_poll() API Manivannan Sadhasivam
2023-02-24 14:43 ` Jeffrey Hugo
@ 2023-03-07 16:35 ` Manivannan Sadhasivam
1 sibling, 0 replies; 3+ messages in thread
From: Manivannan Sadhasivam @ 2023-03-07 16:35 UTC (permalink / raw)
To: mhi; +Cc: quic_jhugo, quic_vpernami
On Fri, Feb 24, 2023 at 05:31:47PM +0530, Manivannan Sadhasivam wrote:
> mhi_poll() API is not used within the MHI stack and also not by any client
> drivers in mainline. So let's remove it until any consumer is available.
>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Applied to mhi-next!
Thanks,
Mani
> ---
> drivers/bus/mhi/host/main.c | 15 ---------------
> include/linux/mhi.h | 7 -------
> 2 files changed, 22 deletions(-)
>
> diff --git a/drivers/bus/mhi/host/main.c b/drivers/bus/mhi/host/main.c
> index df0fbfee7b78..4fa0969472fc 100644
> --- a/drivers/bus/mhi/host/main.c
> +++ b/drivers/bus/mhi/host/main.c
> @@ -1679,18 +1679,3 @@ void mhi_unprepare_from_transfer(struct mhi_device *mhi_dev)
> }
> }
> EXPORT_SYMBOL_GPL(mhi_unprepare_from_transfer);
> -
> -int mhi_poll(struct mhi_device *mhi_dev, u32 budget)
> -{
> - struct mhi_controller *mhi_cntrl = mhi_dev->mhi_cntrl;
> - struct mhi_chan *mhi_chan = mhi_dev->dl_chan;
> - struct mhi_event *mhi_event = &mhi_cntrl->mhi_event[mhi_chan->er_index];
> - int ret;
> -
> - spin_lock_bh(&mhi_event->lock);
> - ret = mhi_event->process_event(mhi_cntrl, mhi_event, budget);
> - spin_unlock_bh(&mhi_event->lock);
> -
> - return ret;
> -}
> -EXPORT_SYMBOL_GPL(mhi_poll);
> diff --git a/include/linux/mhi.h b/include/linux/mhi.h
> index a5441ad33c74..f6de4b6ecfc7 100644
> --- a/include/linux/mhi.h
> +++ b/include/linux/mhi.h
> @@ -765,13 +765,6 @@ int mhi_prepare_for_transfer_autoqueue(struct mhi_device *mhi_dev);
> */
> void mhi_unprepare_from_transfer(struct mhi_device *mhi_dev);
>
> -/**
> - * mhi_poll - Poll for any available data in DL direction
> - * @mhi_dev: Device associated with the channels
> - * @budget: # of events to process
> - */
> -int mhi_poll(struct mhi_device *mhi_dev, u32 budget);
> -
> /**
> * mhi_queue_dma - Send or receive DMA mapped buffers from client device
> * over MHI channel
> --
> 2.25.1
>
--
மணிவண்ணன் சதாசிவம்
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-03-07 16:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-24 12:01 [PATCH] bus: mhi: host: Remove mhi_poll() API Manivannan Sadhasivam
2023-02-24 14:43 ` Jeffrey Hugo
2023-03-07 16:35 ` Manivannan Sadhasivam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).