From: Palmer Dabbelt <palmer@rivosinc.com>
To: schwab@linux-m68k.org
Cc: linux-riscv@lists.infradead.org, rdunlap@infradead.org,
Paul Walmsley <paul.walmsley@sifive.com>,
aou@eecs.berkeley.edu, anup@brainfault.org,
vincent.chen@sifive.com, guoren@kernel.org,
Atish Patra <atishp@rivosinc.com>,
alexandre.ghiti@canonical.com, jszhang@kernel.org,
vitaly.wool@konsulko.com, gatecat@ds0.me,
wangkefeng.wang@huawei.com, mick@ics.forth.gr,
panqinglin2020@iscas.ac.cn, rppt@kernel.org,
linux-kernel@vger.kernel.org, linux@rivosinc.com, lkp@intel.com
Subject: Re: [PATCH v2 1/4] RISC-V: Avoid empty create_*_mapping definitions
Date: Wed, 25 May 2022 14:32:50 -0700 (PDT) [thread overview]
Message-ID: <mhng-3fb658cb-0f64-4c62-8318-b9b4c906ef00@palmer-ri-x1c9> (raw)
In-Reply-To: <87a6cfh0bq.fsf@igel.home>
On Wed, 20 Apr 2022 15:11:37 PDT (-0700), schwab@linux-m68k.org wrote:
> On Apr 20 2022, Palmer Dabbelt wrote:
>
>> (create_pmd_mpping() ends up skipped on XIP_KERNEL).
>
> Does it? There is always the semicolon left as the body of the
> conditional (which is why you get the empty-body warning in the first
> place).
Yep, you're right. I fixed up the commit message, thanks!
WARNING: multiple messages have this Message-ID (diff)
From: Palmer Dabbelt <palmer@rivosinc.com>
To: schwab@linux-m68k.org
Cc: linux-riscv@lists.infradead.org, rdunlap@infradead.org,
Paul Walmsley <paul.walmsley@sifive.com>,
aou@eecs.berkeley.edu, anup@brainfault.org,
vincent.chen@sifive.com, guoren@kernel.org,
Atish Patra <atishp@rivosinc.com>,
alexandre.ghiti@canonical.com, jszhang@kernel.org,
vitaly.wool@konsulko.com, gatecat@ds0.me,
wangkefeng.wang@huawei.com, mick@ics.forth.gr,
panqinglin2020@iscas.ac.cn, rppt@kernel.org,
linux-kernel@vger.kernel.org, linux@rivosinc.com, lkp@intel.com
Subject: Re: [PATCH v2 1/4] RISC-V: Avoid empty create_*_mapping definitions
Date: Wed, 25 May 2022 14:32:50 -0700 (PDT) [thread overview]
Message-ID: <mhng-3fb658cb-0f64-4c62-8318-b9b4c906ef00@palmer-ri-x1c9> (raw)
In-Reply-To: <87a6cfh0bq.fsf@igel.home>
On Wed, 20 Apr 2022 15:11:37 PDT (-0700), schwab@linux-m68k.org wrote:
> On Apr 20 2022, Palmer Dabbelt wrote:
>
>> (create_pmd_mpping() ends up skipped on XIP_KERNEL).
>
> Does it? There is always the semicolon left as the body of the
> conditional (which is why you get the empty-body warning in the first
> place).
Yep, you're right. I fixed up the commit message, thanks!
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2022-05-25 21:32 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-20 18:40 [PATCH v2 0/4] RISC-V: Various XIP fixes Palmer Dabbelt
2022-04-20 18:40 ` Palmer Dabbelt
2022-04-20 18:40 ` [PATCH v2 1/4] RISC-V: Avoid empty create_*_mapping definitions Palmer Dabbelt
2022-04-20 18:40 ` Palmer Dabbelt
2022-04-20 22:11 ` Andreas Schwab
2022-04-20 22:11 ` Andreas Schwab
2022-05-25 21:32 ` Palmer Dabbelt [this message]
2022-05-25 21:32 ` Palmer Dabbelt
2022-04-20 18:40 ` [PATCH v2 2/4] RISC-V: ignore xipImage Palmer Dabbelt
2022-04-20 18:40 ` Palmer Dabbelt
2022-04-21 6:26 ` Guo Ren
2022-04-21 6:26 ` Guo Ren
2022-04-20 18:40 ` [PATCH v2 3/4] RISC-V: Split out the XIP fixups into their own file Palmer Dabbelt
2022-04-20 18:40 ` Palmer Dabbelt
2022-04-21 6:45 ` Guo Ren
2022-04-21 6:45 ` Guo Ren
2022-05-25 21:45 ` Palmer Dabbelt
2022-05-25 21:45 ` Palmer Dabbelt
2022-04-20 18:40 ` [PATCH v2 4/4] RISC-V: Fix the XIP build Palmer Dabbelt
2022-04-20 18:40 ` Palmer Dabbelt
2022-04-21 6:46 ` Guo Ren
2022-04-21 6:46 ` Guo Ren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mhng-3fb658cb-0f64-4c62-8318-b9b4c906ef00@palmer-ri-x1c9 \
--to=palmer@rivosinc.com \
--cc=alexandre.ghiti@canonical.com \
--cc=anup@brainfault.org \
--cc=aou@eecs.berkeley.edu \
--cc=atishp@rivosinc.com \
--cc=gatecat@ds0.me \
--cc=guoren@kernel.org \
--cc=jszhang@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux@rivosinc.com \
--cc=lkp@intel.com \
--cc=mick@ics.forth.gr \
--cc=panqinglin2020@iscas.ac.cn \
--cc=paul.walmsley@sifive.com \
--cc=rdunlap@infradead.org \
--cc=rppt@kernel.org \
--cc=schwab@linux-m68k.org \
--cc=vincent.chen@sifive.com \
--cc=vitaly.wool@konsulko.com \
--cc=wangkefeng.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.