From: Palmer Dabbelt <palmer@dabbelt.com>
To: Conor Dooley <conor@kernel.org>
Cc: alexghiti@rivosinc.com, corbet@lwn.net,
Paul Walmsley <paul.walmsley@sifive.com>,
aou@eecs.berkeley.edu, Conor Dooley <conor.dooley@microchip.com>,
linux-doc@vger.kernel.org, linux-riscv@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -fixes v2 3/3] riscv: No need to relocate the dtb as it lies in the fixmap region
Date: Thu, 13 Apr 2023 18:17:00 -0700 (PDT) [thread overview]
Message-ID: <mhng-4113481b-4c71-4b5c-ab7e-6896058f074b@palmer-ri-x1c9a> (raw)
In-Reply-To: <9c90f390-92d2-4dde-8cd7-b50e9c858787@spud>
On Wed, 29 Mar 2023 08:33:45 PDT (-0700), Conor Dooley wrote:
> On Wed, Mar 29, 2023 at 04:40:18PM +0200, Alexandre Ghiti wrote:
>> On Wed, Mar 29, 2023 at 3:56 PM Conor Dooley <conor@kernel.org> wrote:
>> >
>> > On Wed, Mar 29, 2023 at 10:19:32AM +0200, Alexandre Ghiti wrote:
>> > > We used to access the dtb via its linear mapping address but now that the
>> > > dtb early mapping was moved in the fixmap region, we can keep using this
>> > > address since it is present in swapper_pg_dir, and remove the dtb
>> > > relocation.
>> > >
>> > > Note that the relocation was wrong anyway since early_memremap() is
>> > > restricted to 256K whereas the maximum fdt size is 2MB.
>> >
>> > So, should this be marked as a fix, and backported along with 1/3?
>>
>> Hmmm the whole series should be backported, it does not make sense to
>> move the dtb mapping and keep accessing it using its linear mapping
>> address since it could fail for the exact reason the relocation was
>> implemented in the first place and the relocation is wrong.
>>
>> Maybe we should simply add a "Cc: stable@vger.kernel.org" on all the patches?
>
> Yup, although hopefully Palmer can handle that if nothing else needs
> changing.
The bots usually pick it up anyway, but in general I try and put the
stable CC on there when I see stuff go by. I actually missed it this
time until seeing the comment, though...
WARNING: multiple messages have this Message-ID (diff)
From: Palmer Dabbelt <palmer@dabbelt.com>
To: Conor Dooley <conor@kernel.org>
Cc: alexghiti@rivosinc.com, corbet@lwn.net,
Paul Walmsley <paul.walmsley@sifive.com>,
aou@eecs.berkeley.edu, Conor Dooley <conor.dooley@microchip.com>,
linux-doc@vger.kernel.org, linux-riscv@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -fixes v2 3/3] riscv: No need to relocate the dtb as it lies in the fixmap region
Date: Thu, 13 Apr 2023 18:17:00 -0700 (PDT) [thread overview]
Message-ID: <mhng-4113481b-4c71-4b5c-ab7e-6896058f074b@palmer-ri-x1c9a> (raw)
In-Reply-To: <9c90f390-92d2-4dde-8cd7-b50e9c858787@spud>
On Wed, 29 Mar 2023 08:33:45 PDT (-0700), Conor Dooley wrote:
> On Wed, Mar 29, 2023 at 04:40:18PM +0200, Alexandre Ghiti wrote:
>> On Wed, Mar 29, 2023 at 3:56 PM Conor Dooley <conor@kernel.org> wrote:
>> >
>> > On Wed, Mar 29, 2023 at 10:19:32AM +0200, Alexandre Ghiti wrote:
>> > > We used to access the dtb via its linear mapping address but now that the
>> > > dtb early mapping was moved in the fixmap region, we can keep using this
>> > > address since it is present in swapper_pg_dir, and remove the dtb
>> > > relocation.
>> > >
>> > > Note that the relocation was wrong anyway since early_memremap() is
>> > > restricted to 256K whereas the maximum fdt size is 2MB.
>> >
>> > So, should this be marked as a fix, and backported along with 1/3?
>>
>> Hmmm the whole series should be backported, it does not make sense to
>> move the dtb mapping and keep accessing it using its linear mapping
>> address since it could fail for the exact reason the relocation was
>> implemented in the first place and the relocation is wrong.
>>
>> Maybe we should simply add a "Cc: stable@vger.kernel.org" on all the patches?
>
> Yup, although hopefully Palmer can handle that if nothing else needs
> changing.
The bots usually pick it up anyway, but in general I try and put the
stable CC on there when I see stuff go by. I actually missed it this
time until seeing the comment, though...
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2023-04-14 1:17 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-29 8:19 [PATCH -fixes v2 0/3] Fixes for dtb mapping Alexandre Ghiti
2023-03-29 8:19 ` Alexandre Ghiti
2023-03-29 8:19 ` [PATCH -fixes v2 1/3] riscv: Move early dtb mapping into the fixmap region Alexandre Ghiti
2023-03-29 8:19 ` Alexandre Ghiti
2023-03-29 8:19 ` [PATCH -fixes v2 2/3] riscv: Do not set initial_boot_params to the linear address of the dtb Alexandre Ghiti
2023-03-29 8:19 ` Alexandre Ghiti
2023-03-29 14:37 ` Conor Dooley
2023-03-29 14:37 ` Conor Dooley
2023-03-29 14:52 ` Alexandre Ghiti
2023-03-29 14:52 ` Alexandre Ghiti
2023-03-29 16:35 ` Conor Dooley
2023-03-29 16:35 ` Conor Dooley
2023-03-29 8:19 ` [PATCH -fixes v2 3/3] riscv: No need to relocate the dtb as it lies in the fixmap region Alexandre Ghiti
2023-03-29 8:19 ` Alexandre Ghiti
2023-03-29 13:56 ` Conor Dooley
2023-03-29 13:56 ` Conor Dooley
2023-03-29 14:40 ` Alexandre Ghiti
2023-03-29 14:40 ` Alexandre Ghiti
2023-03-29 15:33 ` Conor Dooley
2023-03-29 15:33 ` Conor Dooley
2023-04-14 1:17 ` Palmer Dabbelt [this message]
2023-04-14 1:17 ` Palmer Dabbelt
2023-04-14 1:13 ` [PATCH -fixes v2 0/3] Fixes for dtb mapping Palmer Dabbelt
2023-04-14 1:13 ` Palmer Dabbelt
2023-04-14 1:20 ` patchwork-bot+linux-riscv
2023-04-14 1:20 ` patchwork-bot+linux-riscv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mhng-4113481b-4c71-4b5c-ab7e-6896058f074b@palmer-ri-x1c9a \
--to=palmer@dabbelt.com \
--cc=alexghiti@rivosinc.com \
--cc=aou@eecs.berkeley.edu \
--cc=conor.dooley@microchip.com \
--cc=conor@kernel.org \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=paul.walmsley@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.