From: Palmer Dabbelt <palmer@dabbelt.com> To: Conor Dooley <conor@kernel.org> Cc: alexghiti@rivosinc.com, Paul Walmsley <paul.walmsley@sifive.com>, aou@eecs.berkeley.edu, Andrea Parri <andrea@rivosinc.com>, samuel.holland@sifive.com, anup@brainfault.org, rostedt@goodmis.org, mhiramat@kernel.org, Mark Rutland <mark.rutland@arm.com>, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, parri.andrea@gmail.com Subject: Re: [PATCH v3 1/2] riscv: Remove superfluous smp_mb() Date: Tue, 16 Apr 2024 18:29:22 -0700 (PDT) [thread overview] Message-ID: <mhng-493ab98f-27df-4576-ab29-90254bee34d0@palmer-ri-x1c9a> (raw) In-Reply-To: <20240304-aptly-surely-ab9ea7d82337@spud> On Mon, 04 Mar 2024 11:25:33 PST (-0800), Conor Dooley wrote: > On Thu, Feb 29, 2024 at 01:10:55PM +0100, Alexandre Ghiti wrote: >> This memory barrier is not needed and not documented so simply remove >> it. > > This looks like it should be patch 2 in the series, not patch 1, as it > is cleanup rather than a fix that needs backporting. IIUC neither is actually a fix, as the other is only exposed by the IOMMU driver and that's not upstream yet. So I'm just going to pick these up on for-next. > >> >> Suggested-by: Andrea Parri <andrea@rivosinc.com> >> Signed-off-by: Alexandre Ghiti <alexghiti@rivosinc.com> >> Reviewed-by: Andrea Parri <parri.andrea@gmail.com> >> --- >> arch/riscv/kernel/patch.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/arch/riscv/kernel/patch.c b/arch/riscv/kernel/patch.c >> index 37e87fdcf6a0..0b5c16dfe3f4 100644 >> --- a/arch/riscv/kernel/patch.c >> +++ b/arch/riscv/kernel/patch.c >> @@ -239,7 +239,6 @@ static int patch_text_cb(void *data) >> } else { >> while (atomic_read(&patch->cpu_count) <= num_online_cpus()) >> cpu_relax(); >> - smp_mb(); >> } >> >> return ret; >> -- >> 2.39.2 >> >> >> _______________________________________________ >> linux-riscv mailing list >> linux-riscv@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: Palmer Dabbelt <palmer@dabbelt.com> To: Conor Dooley <conor@kernel.org> Cc: alexghiti@rivosinc.com, Paul Walmsley <paul.walmsley@sifive.com>, aou@eecs.berkeley.edu, Andrea Parri <andrea@rivosinc.com>, samuel.holland@sifive.com, anup@brainfault.org, rostedt@goodmis.org, mhiramat@kernel.org, Mark Rutland <mark.rutland@arm.com>, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, parri.andrea@gmail.com Subject: Re: [PATCH v3 1/2] riscv: Remove superfluous smp_mb() Date: Tue, 16 Apr 2024 18:29:22 -0700 (PDT) [thread overview] Message-ID: <mhng-493ab98f-27df-4576-ab29-90254bee34d0@palmer-ri-x1c9a> (raw) In-Reply-To: <20240304-aptly-surely-ab9ea7d82337@spud> On Mon, 04 Mar 2024 11:25:33 PST (-0800), Conor Dooley wrote: > On Thu, Feb 29, 2024 at 01:10:55PM +0100, Alexandre Ghiti wrote: >> This memory barrier is not needed and not documented so simply remove >> it. > > This looks like it should be patch 2 in the series, not patch 1, as it > is cleanup rather than a fix that needs backporting. IIUC neither is actually a fix, as the other is only exposed by the IOMMU driver and that's not upstream yet. So I'm just going to pick these up on for-next. > >> >> Suggested-by: Andrea Parri <andrea@rivosinc.com> >> Signed-off-by: Alexandre Ghiti <alexghiti@rivosinc.com> >> Reviewed-by: Andrea Parri <parri.andrea@gmail.com> >> --- >> arch/riscv/kernel/patch.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/arch/riscv/kernel/patch.c b/arch/riscv/kernel/patch.c >> index 37e87fdcf6a0..0b5c16dfe3f4 100644 >> --- a/arch/riscv/kernel/patch.c >> +++ b/arch/riscv/kernel/patch.c >> @@ -239,7 +239,6 @@ static int patch_text_cb(void *data) >> } else { >> while (atomic_read(&patch->cpu_count) <= num_online_cpus()) >> cpu_relax(); >> - smp_mb(); >> } >> >> return ret; >> -- >> 2.39.2 >> >> >> _______________________________________________ >> linux-riscv mailing list >> linux-riscv@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-riscv _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2024-04-17 1:29 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-02-29 12:10 [PATCH v3 0/2] riscv: fix patching with IPI Alexandre Ghiti 2024-02-29 12:10 ` Alexandre Ghiti 2024-02-29 12:10 ` [PATCH v3 1/2] riscv: Remove superfluous smp_mb() Alexandre Ghiti 2024-02-29 12:10 ` Alexandre Ghiti 2024-03-04 19:25 ` Conor Dooley 2024-03-04 19:25 ` Conor Dooley 2024-04-17 1:29 ` Palmer Dabbelt [this message] 2024-04-17 1:29 ` Palmer Dabbelt 2024-02-29 12:10 ` [PATCH v3 2/2] riscv: Fix text patching when IPI are used Alexandre Ghiti 2024-02-29 12:10 ` Alexandre Ghiti 2024-03-04 19:27 ` Conor Dooley 2024-03-04 19:27 ` Conor Dooley 2024-03-04 20:24 ` Björn Töpel 2024-03-04 20:24 ` Björn Töpel 2024-03-05 3:03 ` Anup Patel 2024-03-05 3:03 ` Anup Patel 2024-03-05 7:59 ` Conor Dooley 2024-03-05 7:59 ` Conor Dooley 2024-03-05 8:21 ` Björn Töpel 2024-03-05 8:21 ` Björn Töpel 2024-04-28 22:00 ` [PATCH v3 0/2] riscv: fix patching with IPI patchwork-bot+linux-riscv 2024-04-28 22:00 ` patchwork-bot+linux-riscv
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=mhng-493ab98f-27df-4576-ab29-90254bee34d0@palmer-ri-x1c9a \ --to=palmer@dabbelt.com \ --cc=alexghiti@rivosinc.com \ --cc=andrea@rivosinc.com \ --cc=anup@brainfault.org \ --cc=aou@eecs.berkeley.edu \ --cc=conor@kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-riscv@lists.infradead.org \ --cc=linux-trace-kernel@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=mhiramat@kernel.org \ --cc=parri.andrea@gmail.com \ --cc=paul.walmsley@sifive.com \ --cc=rostedt@goodmis.org \ --cc=samuel.holland@sifive.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.