From: Palmer Dabbelt <palmer@dabbelt.com>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <will@kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
aou@eecs.berkeley.edu, chris@zankel.net, jcmvbkbc@gmail.com,
steven.price@arm.com, vincenzo.frascino@arm.com,
leyfoon.tan@starfivetech.com, mason.huo@starfivetech.com,
jeeheng.sia@starfivetech.com,
Conor Dooley <conor.dooley@microchip.com>,
ajones@ventanamicro.com, songshuaishuai@tinylab.org,
linux@armlinux.org.uk, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org
Subject: Re: (subset) [PATCH V2 0/4] Remove WARN_ON in save_processor_state
Date: Thu, 22 Jun 2023 11:28:56 -0700 (PDT) [thread overview]
Message-ID: <mhng-d670ba57-2c68-4d38-8ad9-795f8ca3b69d@palmer-ri-x1c9a> (raw)
In-Reply-To: <168736259084.605458.4732376069158804322.b4-ty@arm.com>
On Wed, 21 Jun 2023 08:51:43 PDT (-0700), Catalin Marinas wrote:
> On Fri, 09 Jun 2023 15:50:45 +0800, Song Shuai wrote:
>> During hibernation or restoration, freeze_secondary_cpus
>> checks num_online_cpus via BUG_ON, and the subsequent
>> save_processor_state also does the checking with WARN_ON.
>>
>> In the case of CONFIG_PM_SLEEP_SMP=n, freeze_secondary_cpus
>> is not defined, but the sole possible condition to disable
>> CONFIG_PM_SLEEP_SMP is !SMP where num_online_cpus is always 1.
>> We also don't have to check it in save_processor_state.
>>
>> [...]
>
> Applied to arm64 (for-next/misc), thanks!
>
> I couldn't tell whether this series would go in as a whole but given
> that the patches are independent, I picked up the arm64 one.
>
> [2/4] arm64: hibernate: remove WARN_ON in save_processor_state
> https://git.kernel.org/arm64/c/615af0021a61
I was pretty much in the same spot until I saw this, so I'm picking the
RISC-V bit and just ignoring the rest. It's testing so it might take a bit to
land in linux-next, but seems pretty safe.
WARNING: multiple messages have this Message-ID (diff)
From: Palmer Dabbelt <palmer@dabbelt.com>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <will@kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
aou@eecs.berkeley.edu, chris@zankel.net, jcmvbkbc@gmail.com,
steven.price@arm.com, vincenzo.frascino@arm.com,
leyfoon.tan@starfivetech.com, mason.huo@starfivetech.com,
jeeheng.sia@starfivetech.com,
Conor Dooley <conor.dooley@microchip.com>,
ajones@ventanamicro.com, songshuaishuai@tinylab.org,
linux@armlinux.org.uk, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org
Subject: Re: (subset) [PATCH V2 0/4] Remove WARN_ON in save_processor_state
Date: Thu, 22 Jun 2023 11:28:56 -0700 (PDT) [thread overview]
Message-ID: <mhng-d670ba57-2c68-4d38-8ad9-795f8ca3b69d@palmer-ri-x1c9a> (raw)
In-Reply-To: <168736259084.605458.4732376069158804322.b4-ty@arm.com>
On Wed, 21 Jun 2023 08:51:43 PDT (-0700), Catalin Marinas wrote:
> On Fri, 09 Jun 2023 15:50:45 +0800, Song Shuai wrote:
>> During hibernation or restoration, freeze_secondary_cpus
>> checks num_online_cpus via BUG_ON, and the subsequent
>> save_processor_state also does the checking with WARN_ON.
>>
>> In the case of CONFIG_PM_SLEEP_SMP=n, freeze_secondary_cpus
>> is not defined, but the sole possible condition to disable
>> CONFIG_PM_SLEEP_SMP is !SMP where num_online_cpus is always 1.
>> We also don't have to check it in save_processor_state.
>>
>> [...]
>
> Applied to arm64 (for-next/misc), thanks!
>
> I couldn't tell whether this series would go in as a whole but given
> that the patches are independent, I picked up the arm64 one.
>
> [2/4] arm64: hibernate: remove WARN_ON in save_processor_state
> https://git.kernel.org/arm64/c/615af0021a61
I was pretty much in the same spot until I saw this, so I'm picking the
RISC-V bit and just ignoring the rest. It's testing so it might take a bit to
land in linux-next, but seems pretty safe.
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: Palmer Dabbelt <palmer@dabbelt.com>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <will@kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
aou@eecs.berkeley.edu, chris@zankel.net, jcmvbkbc@gmail.com,
steven.price@arm.com, vincenzo.frascino@arm.com,
leyfoon.tan@starfivetech.com, mason.huo@starfivetech.com,
jeeheng.sia@starfivetech.com,
Conor Dooley <conor.dooley@microchip.com>,
ajones@ventanamicro.com, songshuaishuai@tinylab.org,
linux@armlinux.org.uk, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org
Subject: Re: (subset) [PATCH V2 0/4] Remove WARN_ON in save_processor_state
Date: Thu, 22 Jun 2023 11:28:56 -0700 (PDT) [thread overview]
Message-ID: <mhng-d670ba57-2c68-4d38-8ad9-795f8ca3b69d@palmer-ri-x1c9a> (raw)
In-Reply-To: <168736259084.605458.4732376069158804322.b4-ty@arm.com>
On Wed, 21 Jun 2023 08:51:43 PDT (-0700), Catalin Marinas wrote:
> On Fri, 09 Jun 2023 15:50:45 +0800, Song Shuai wrote:
>> During hibernation or restoration, freeze_secondary_cpus
>> checks num_online_cpus via BUG_ON, and the subsequent
>> save_processor_state also does the checking with WARN_ON.
>>
>> In the case of CONFIG_PM_SLEEP_SMP=n, freeze_secondary_cpus
>> is not defined, but the sole possible condition to disable
>> CONFIG_PM_SLEEP_SMP is !SMP where num_online_cpus is always 1.
>> We also don't have to check it in save_processor_state.
>>
>> [...]
>
> Applied to arm64 (for-next/misc), thanks!
>
> I couldn't tell whether this series would go in as a whole but given
> that the patches are independent, I picked up the arm64 one.
>
> [2/4] arm64: hibernate: remove WARN_ON in save_processor_state
> https://git.kernel.org/arm64/c/615af0021a61
I was pretty much in the same spot until I saw this, so I'm picking the
RISC-V bit and just ignoring the rest. It's testing so it might take a bit to
land in linux-next, but seems pretty safe.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-06-22 18:29 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-09 7:50 [PATCH V2 0/4] Remove WARN_ON in save_processor_state Song Shuai
2023-06-09 7:50 ` Song Shuai
2023-06-09 7:50 ` Song Shuai
2023-06-09 7:50 ` [PATCH V2 1/4] ARM: hibernate: remove " Song Shuai
2023-06-09 7:50 ` Song Shuai
2023-06-09 7:50 ` Song Shuai
2023-06-09 7:50 ` [PATCH V2 2/4] arm64: " Song Shuai
2023-06-09 7:50 ` Song Shuai
2023-06-09 7:50 ` Song Shuai
2023-06-09 10:23 ` Will Deacon
2023-06-09 10:23 ` Will Deacon
2023-06-09 10:23 ` Will Deacon
2023-06-09 7:50 ` [PATCH V2 3/4] riscv: " Song Shuai
2023-06-09 7:50 ` Song Shuai
2023-06-09 7:50 ` Song Shuai
2023-06-10 15:39 ` Conor Dooley
2023-06-10 15:39 ` Conor Dooley
2023-06-09 7:50 ` [PATCH V2 4/4] xtensa: " Song Shuai
2023-06-09 7:50 ` Song Shuai
2023-06-09 7:50 ` Song Shuai
2023-06-21 15:51 ` (subset) [PATCH V2 0/4] Remove " Catalin Marinas
2023-06-21 15:51 ` Catalin Marinas
2023-06-21 15:51 ` Catalin Marinas
2023-06-22 18:28 ` Palmer Dabbelt [this message]
2023-06-22 18:28 ` Palmer Dabbelt
2023-06-22 18:28 ` Palmer Dabbelt
2023-06-25 23:17 ` Palmer Dabbelt
2023-06-25 23:17 ` Palmer Dabbelt
2023-06-25 23:17 ` Palmer Dabbelt
2023-06-25 23:20 ` patchwork-bot+linux-riscv
2023-06-25 23:20 ` patchwork-bot+linux-riscv
2023-06-25 23:20 ` patchwork-bot+linux-riscv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mhng-d670ba57-2c68-4d38-8ad9-795f8ca3b69d@palmer-ri-x1c9a \
--to=palmer@dabbelt.com \
--cc=ajones@ventanamicro.com \
--cc=aou@eecs.berkeley.edu \
--cc=catalin.marinas@arm.com \
--cc=chris@zankel.net \
--cc=conor.dooley@microchip.com \
--cc=jcmvbkbc@gmail.com \
--cc=jeeheng.sia@starfivetech.com \
--cc=leyfoon.tan@starfivetech.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=mason.huo@starfivetech.com \
--cc=paul.walmsley@sifive.com \
--cc=songshuaishuai@tinylab.org \
--cc=steven.price@arm.com \
--cc=vincenzo.frascino@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.