From: Palmer Dabbelt <palmer@sifive.com>
To: alistair23@gmail.com
Cc: Alistair Francis <Alistair.Francis@wdc.com>,
philmd@redhat.com, qemu-devel@nongnu.org, qemu-riscv@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v1 1/1] riscv/boot: Fixup the RISC-V firmware warning
Date: Mon, 22 Jul 2019 12:09:16 -0700 (PDT) [thread overview]
Message-ID: <mhng-d801380f-1010-4ee3-a3ee-d6f16159474e@palmer-si-x1c4> (raw)
In-Reply-To: <CAKmqyKNnkToYf3Y025Hpv1e8jazMVjxhjAaOBtn0ajcHSFaTUA@mail.gmail.com>
On Mon, 22 Jul 2019 11:22:43 PDT (-0700), alistair23@gmail.com wrote:
> On Sat, Jul 20, 2019 at 2:30 AM Philippe Mathieu-Daudé
> <philmd@redhat.com> wrote:
>>
>> On 7/19/19 8:05 PM, Alistair Francis wrote:
>> > Fix a typo in the warning message displayed to users, don't print the
>> > message when running inside qtest and don't mention a specific QEMU
>> > version for the deprecation.
>> >
>> > Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
>> > ---
>> > hw/riscv/boot.c | 12 ++++++++----
>> > 1 file changed, 8 insertions(+), 4 deletions(-)
>> >
>> > diff --git a/hw/riscv/boot.c b/hw/riscv/boot.c
>> > index 5dee63011b..4b32ab1d26 100644
>> > --- a/hw/riscv/boot.c
>> > +++ b/hw/riscv/boot.c
>> > @@ -26,6 +26,7 @@
>> > #include "hw/riscv/boot.h"
>> > #include "hw/boards.h"
>> > #include "elf.h"
>> > +#include "sysemu/qtest.h"
>> >
>> > #if defined(TARGET_RISCV32)
>> > # define KERNEL_BOOT_ADDRESS 0x80400000
>> > @@ -46,10 +47,13 @@ void riscv_find_and_load_firmware(MachineState *machine,
>> > * In the future this defaul will change to loading the prebuilt
>> > * OpenSBI firmware. Let's warn the user and then continue.
>> > */
>> > - warn_report("No -bios option specified. Not loading a firmware.");
>> > - warn_report("This default will change in QEMU 4.3. Please use the " \
>> > - "-bios option to aviod breakages when this happens.");
>> > - warn_report("See QEMU's deprecation documentation for details");
>> > + if (!qtest_enabled()) {
>> > + warn_report("No -bios option specified. Not loading a firmware.");
>> > + warn_report("This default will change in a future QEMU release. " \
>> > + "Please use the -bios option to avoid breakages when "\
>> > + "this happens.");
>> > + warn_report("See QEMU's deprecation documentation for details");
>>
>> Maybe a final '.' in the last warning to be consistent with the previous
>> lines?
>
> Done in v2.
I don't see a v2, did I miss it?
>> Regardless:
>> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>
> Thanks!
>
> Alistair
>
>>
>> > + }
>> > return;
>> > }
>> >
>> >
WARNING: multiple messages have this Message-ID (diff)
From: Palmer Dabbelt <palmer@sifive.com>
To: alistair23@gmail.com
Cc: philmd@redhat.com, Alistair Francis <Alistair.Francis@wdc.com>,
qemu-devel@nongnu.org, qemu-riscv@nongnu.org
Subject: Re: [Qemu-riscv] [Qemu-devel] [PATCH v1 1/1] riscv/boot: Fixup the RISC-V firmware warning
Date: Mon, 22 Jul 2019 12:09:16 -0700 (PDT) [thread overview]
Message-ID: <mhng-d801380f-1010-4ee3-a3ee-d6f16159474e@palmer-si-x1c4> (raw)
In-Reply-To: <CAKmqyKNnkToYf3Y025Hpv1e8jazMVjxhjAaOBtn0ajcHSFaTUA@mail.gmail.com>
On Mon, 22 Jul 2019 11:22:43 PDT (-0700), alistair23@gmail.com wrote:
> On Sat, Jul 20, 2019 at 2:30 AM Philippe Mathieu-Daudé
> <philmd@redhat.com> wrote:
>>
>> On 7/19/19 8:05 PM, Alistair Francis wrote:
>> > Fix a typo in the warning message displayed to users, don't print the
>> > message when running inside qtest and don't mention a specific QEMU
>> > version for the deprecation.
>> >
>> > Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
>> > ---
>> > hw/riscv/boot.c | 12 ++++++++----
>> > 1 file changed, 8 insertions(+), 4 deletions(-)
>> >
>> > diff --git a/hw/riscv/boot.c b/hw/riscv/boot.c
>> > index 5dee63011b..4b32ab1d26 100644
>> > --- a/hw/riscv/boot.c
>> > +++ b/hw/riscv/boot.c
>> > @@ -26,6 +26,7 @@
>> > #include "hw/riscv/boot.h"
>> > #include "hw/boards.h"
>> > #include "elf.h"
>> > +#include "sysemu/qtest.h"
>> >
>> > #if defined(TARGET_RISCV32)
>> > # define KERNEL_BOOT_ADDRESS 0x80400000
>> > @@ -46,10 +47,13 @@ void riscv_find_and_load_firmware(MachineState *machine,
>> > * In the future this defaul will change to loading the prebuilt
>> > * OpenSBI firmware. Let's warn the user and then continue.
>> > */
>> > - warn_report("No -bios option specified. Not loading a firmware.");
>> > - warn_report("This default will change in QEMU 4.3. Please use the " \
>> > - "-bios option to aviod breakages when this happens.");
>> > - warn_report("See QEMU's deprecation documentation for details");
>> > + if (!qtest_enabled()) {
>> > + warn_report("No -bios option specified. Not loading a firmware.");
>> > + warn_report("This default will change in a future QEMU release. " \
>> > + "Please use the -bios option to avoid breakages when "\
>> > + "this happens.");
>> > + warn_report("See QEMU's deprecation documentation for details");
>>
>> Maybe a final '.' in the last warning to be consistent with the previous
>> lines?
>
> Done in v2.
I don't see a v2, did I miss it?
>> Regardless:
>> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>
> Thanks!
>
> Alistair
>
>>
>> > + }
>> > return;
>> > }
>> >
>> >
next prev parent reply other threads:[~2019-07-22 19:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-19 18:05 [Qemu-devel] [PATCH v1 1/1] riscv/boot: Fixup the RISC-V firmware warning Alistair Francis
2019-07-19 18:05 ` [Qemu-riscv] " Alistair Francis
2019-07-20 9:30 ` [Qemu-devel] " Philippe Mathieu-Daudé
2019-07-20 9:30 ` [Qemu-riscv] " Philippe Mathieu-Daudé
2019-07-22 18:22 ` Alistair Francis
2019-07-22 18:22 ` [Qemu-riscv] " Alistair Francis
2019-07-22 19:09 ` Palmer Dabbelt [this message]
2019-07-22 19:09 ` Palmer Dabbelt
2019-07-22 20:21 ` Alistair Francis
2019-07-22 20:21 ` [Qemu-riscv] " Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mhng-d801380f-1010-4ee3-a3ee-d6f16159474e@palmer-si-x1c4 \
--to=palmer@sifive.com \
--cc=Alistair.Francis@wdc.com \
--cc=alistair23@gmail.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.