mm-commits.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* + writeback-remove-the-always-false-bdi_cap_writeback_dirty-test.patch added to -mm tree
@ 2009-12-01 23:08 akpm
  0 siblings, 0 replies; only message in thread
From: akpm @ 2009-12-01 23:08 UTC (permalink / raw)
  To: mm-commits; +Cc: fengguang.wu, Trond.Myklebust, fengguang.wu, hch, jens.axboe


The patch titled
     writeback: remove the always false bdi_cap_writeback_dirty() test
has been added to the -mm tree.  Its filename is
     writeback-remove-the-always-false-bdi_cap_writeback_dirty-test.patch

Before you just go and hit "reply", please:
   a) Consider who else should be cc'ed
   b) Prefer to cc a suitable mailing list as well
   c) Ideally: find the original patch on the mailing list and do a
      reply-to-all to that, adding suitable additional cc's

*** Remember to use Documentation/SubmitChecklist when testing your code ***

See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find
out what to do about this

The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/

------------------------------------------------------
Subject: writeback: remove the always false bdi_cap_writeback_dirty() test
From: Wu Fengguang <fengguang.wu@gmail.com>

This is dead code because no bdi flush thread will be started for
!bdi_cap_writeback_dirty bdi.

Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
Cc: Jens Axboe <jens.axboe@oracle.com>
Cc: Trond Myklebust <Trond.Myklebust@netapp.com>
Cc: Christoph Hellwig <hch@infradead.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 fs/fs-writeback.c |   18 ------------------
 1 file changed, 18 deletions(-)

diff -puN fs/fs-writeback.c~writeback-remove-the-always-false-bdi_cap_writeback_dirty-test fs/fs-writeback.c
--- a/fs/fs-writeback.c~writeback-remove-the-always-false-bdi_cap_writeback_dirty-test
+++ a/fs/fs-writeback.c
@@ -615,7 +615,6 @@ static void writeback_inodes_wb(struct b
 				struct writeback_control *wbc)
 {
 	struct super_block *sb = wbc->sb, *pin_sb = NULL;
-	const int is_blkdev_sb = sb_is_blkdev_sb(sb);
 	const unsigned long start = jiffies;	/* livelock avoidance */
 
 	spin_lock(&inode_lock);
@@ -636,23 +635,6 @@ static void writeback_inodes_wb(struct b
 			continue;
 		}
 
-		if (!bdi_cap_writeback_dirty(wb->bdi)) {
-			redirty_tail(inode);
-			if (is_blkdev_sb) {
-				/*
-				 * Dirty memory-backed blockdev: the ramdisk
-				 * driver does this.  Skip just this inode
-				 */
-				continue;
-			}
-			/*
-			 * Dirty memory-backed inode against a filesystem other
-			 * than the kernel-internal bdev filesystem.  Skip the
-			 * entire superblock.
-			 */
-			break;
-		}

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2009-12-01 23:09 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-12-01 23:08 + writeback-remove-the-always-false-bdi_cap_writeback_dirty-test.patch added to -mm tree akpm

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).