* + jbd-jbd-debug-and-jbd2-debug-should-be-writable.patch added to -mm tree
@ 2009-12-04 23:48 akpm
0 siblings, 0 replies; only message in thread
From: akpm @ 2009-12-04 23:48 UTC (permalink / raw)
To: mm-commits; +Cc: kangkai.yin, aneesh.kumar, jack
The patch titled
jbd: jbd-debug and jbd2-debug should be writable
has been added to the -mm tree. Its filename is
jbd-jbd-debug-and-jbd2-debug-should-be-writable.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find
out what to do about this
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
------------------------------------------------------
Subject: jbd: jbd-debug and jbd2-debug should be writable
From: Yin Kangkai <kangkai.yin@intel.com>
jbd-debug and jbd2-debug is currently read-only (S_IRUGO), which is not
correct. Make it writable so that we can start debuging.
Signed-off-by: Yin Kangkai <kangkai.yin@intel.com>
Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Cc: Jan Kara <jack@ucw.cz>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
fs/jbd/journal.c | 2 +-
fs/jbd2/journal.c | 3 ++-
2 files changed, 3 insertions(+), 2 deletions(-)
diff -puN fs/jbd/journal.c~jbd-jbd-debug-and-jbd2-debug-should-be-writable fs/jbd/journal.c
--- a/fs/jbd/journal.c~jbd-jbd-debug-and-jbd2-debug-should-be-writable
+++ a/fs/jbd/journal.c
@@ -1913,7 +1913,7 @@ static void __init jbd_create_debugfs_en
{
jbd_debugfs_dir = debugfs_create_dir("jbd", NULL);
if (jbd_debugfs_dir)
- jbd_debug = debugfs_create_u8("jbd-debug", S_IRUGO,
+ jbd_debug = debugfs_create_u8("jbd-debug", S_IRUGO | S_IWUSR,
jbd_debugfs_dir,
&journal_enable_debug);
}
diff -puN fs/jbd2/journal.c~jbd-jbd-debug-and-jbd2-debug-should-be-writable fs/jbd2/journal.c
--- a/fs/jbd2/journal.c~jbd-jbd-debug-and-jbd2-debug-should-be-writable
+++ a/fs/jbd2/journal.c
@@ -2110,7 +2110,8 @@ static void __init jbd2_create_debugfs_e
{
jbd2_debugfs_dir = debugfs_create_dir("jbd2", NULL);
if (jbd2_debugfs_dir)
- jbd2_debug = debugfs_create_u8(JBD2_DEBUG_NAME, S_IRUGO,
+ jbd2_debug = debugfs_create_u8(JBD2_DEBUG_NAME,
+ S_IRUGO | S_IWUSR,
jbd2_debugfs_dir,
&jbd2_journal_enable_debug);
}
_
Patches currently in -mm which might be from kangkai.yin@intel.com are
jbd-jbd-debug-and-jbd2-debug-should-be-writable.patch
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2009-12-04 23:49 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-12-04 23:48 + jbd-jbd-debug-and-jbd2-debug-should-be-writable.patch added to -mm tree akpm
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).