mm-commits.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [to-be-updated] olpc-alsa-fix-cs5535audios-mic-gpio-to-enable-input.patch removed from -mm tree
@ 2010-03-03  0:00 akpm
  0 siblings, 0 replies; only message in thread
From: akpm @ 2010-03-03  0:00 UTC (permalink / raw)
  To: dilinger, gardner.ben, jayakumar.alsa, stable, tiwai, mm-commits


The patch titled
     OLPC: ALSA: fix cs5535audio's MIC GPIO to enable input
has been removed from the -mm tree.  Its filename was
     olpc-alsa-fix-cs5535audios-mic-gpio-to-enable-input.patch

This patch was dropped because an updated version will be merged

The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/

------------------------------------------------------
Subject: OLPC: ALSA: fix cs5535audio's MIC GPIO to enable input
From: Andres Salomon <dilinger@collabora.co.uk>

Previously the MIC GPIO was set to output mode, and when checking the
status after setting it we were checking OUTPUT_VAL.  This worked, though
I'm not quite sure why.  Instead, if we actually check the READ_BACK
value, it doesn't work unless the GPIO is in bidirectional mode.  Thus,
enable input mode as well.

Signed-off-by: Andres Salomon <dilinger@collabora.co.uk>
Cc: Ben Gardner <gardner.ben@gmail.com>
Cc: Jaya Kumar <jayakumar.alsa@gmail.com>
Cc: Takashi Iwai <tiwai@suse.de>
Cc: <stable@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 sound/pci/cs5535audio/cs5535audio_olpc.c |    1 +
 1 file changed, 1 insertion(+)

diff -puN sound/pci/cs5535audio/cs5535audio_olpc.c~olpc-alsa-fix-cs5535audios-mic-gpio-to-enable-input sound/pci/cs5535audio/cs5535audio_olpc.c
--- a/sound/pci/cs5535audio/cs5535audio_olpc.c~olpc-alsa-fix-cs5535audios-mic-gpio-to-enable-input
+++ a/sound/pci/cs5535audio/cs5535audio_olpc.c
@@ -157,6 +157,7 @@ int __devinit olpc_quirks(struct snd_car
 		return -EIO;
 	}
 	gpio_direction_output(OLPC_GPIO_MIC_AC, 0);
+	gpio_direction_input(OLPC_GPIO_MIC_AC);
 
 	/* drop the original AD1888 HPF control */
 	memset(&elem, 0, sizeof(elem));
_

Patches currently in -mm which might be from dilinger@collabora.co.uk are

origin.patch
linux-next.patch
olpc-alsa-fix-cs5535audios-mic-gpio-to-enable-input.patch
cs5535-clockevt-free-timer-in-irq-setup-error-path.patch
mac80211-give-warning-if-building-w-out-rate-ctrl-algorithm.patch
mfgpt-move-clocksource-menu.patch
gpio-cs5535-gpio-fix-input-direction.patch
cs5535_gpio-gpio_chipget-should-return-the-input-value.patch


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2010-03-03  0:00 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-03-03  0:00 [to-be-updated] olpc-alsa-fix-cs5535audios-mic-gpio-to-enable-input.patch removed from -mm tree akpm

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).