* + drivers-gpu-drm-drm_fb_helperc-drm_fb_helper_setcmap-wrong-index-used-in-inner-loop.patch added to -mm tree
@ 2011-03-07 22:58 akpm
0 siblings, 0 replies; only message in thread
From: akpm @ 2011-03-07 22:58 UTC (permalink / raw)
To: mm-commits; +Cc: roel.kluin, airlied, chris, sliedes
The patch titled
drivers/gpu/drm/drm_fb_helper.c: drm_fb_helper_setcmap(): wrong index used in inner loop
has been added to the -mm tree. Its filename is
drivers-gpu-drm-drm_fb_helperc-drm_fb_helper_setcmap-wrong-index-used-in-inner-loop.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find
out what to do about this
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
------------------------------------------------------
Subject: drivers/gpu/drm/drm_fb_helper.c: drm_fb_helper_setcmap(): wrong index used in inner loop
From: roel <roel.kluin@gmail.com>
Index i was already used in the outer loop.
Chris implies that this solve
https://bugzilla.kernel.org/show_bug.cgi?id=19512.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Cc: Sami Liedes <sliedes@cc.hut.fi>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Dave Airlie <airlied@linux.ie>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
drivers/gpu/drm/drm_fb_helper.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff -puN drivers/gpu/drm/drm_fb_helper.c~drivers-gpu-drm-drm_fb_helperc-drm_fb_helper_setcmap-wrong-index-used-in-inner-loop drivers/gpu/drm/drm_fb_helper.c
--- a/drivers/gpu/drm/drm_fb_helper.c~drivers-gpu-drm-drm_fb_helperc-drm_fb_helper_setcmap-wrong-index-used-in-inner-loop
+++ a/drivers/gpu/drm/drm_fb_helper.c
@@ -677,7 +677,7 @@ int drm_fb_helper_setcmap(struct fb_cmap
struct drm_crtc_helper_funcs *crtc_funcs;
u16 *red, *green, *blue, *transp;
struct drm_crtc *crtc;
- int i, rc = 0;
+ int i, j, rc = 0;
int start;
for (i = 0; i < fb_helper->crtc_count; i++) {
@@ -690,7 +690,7 @@ int drm_fb_helper_setcmap(struct fb_cmap
transp = cmap->transp;
start = cmap->start;
- for (i = 0; i < cmap->len; i++) {
+ for (j = 0; j < cmap->len; j++) {
u16 hred, hgreen, hblue, htransp = 0xffff;
hred = *red++;
_
Patches currently in -mm which might be from roel.kluin@gmail.com are
linux-next.patch
drivers-gpu-drm-drm_fb_helperc-drm_fb_helper_setcmap-wrong-index-used-in-inner-loop.patch
btrfs-dont-dereference-extent_mapping-if-null.patch
frv-duplicate-output_buffer-of-e03.patch
frv-duplicate-output_buffer-of-e03-checkpatch-fixes.patch
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2011-03-07 22:58 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-03-07 22:58 + drivers-gpu-drm-drm_fb_helperc-drm_fb_helper_setcmap-wrong-index-used-in-inner-loop.patch added to -mm tree akpm
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).