mm-commits.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* + fs-execc-acct_arg_size-ptl-is-no-longer-needed-for-add_mm_counter.patch added to -mm tree
@ 2011-07-13 23:23 akpm
  0 siblings, 0 replies; only message in thread
From: akpm @ 2011-07-13 23:23 UTC (permalink / raw)
  To: mm-commits; +Cc: oleg, dave, kamezawa.hiroyu, matt.fleming


The patch titled
     fs/exec.c:acct_arg_size(): ptl is no longer needed for add_mm_counter()
has been added to the -mm tree.  Its filename is
     fs-execc-acct_arg_size-ptl-is-no-longer-needed-for-add_mm_counter.patch

Before you just go and hit "reply", please:
   a) Consider who else should be cc'ed
   b) Prefer to cc a suitable mailing list as well
   c) Ideally: find the original patch on the mailing list and do a
      reply-to-all to that, adding suitable additional cc's

*** Remember to use Documentation/SubmitChecklist when testing your code ***

See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find
out what to do about this

The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/

------------------------------------------------------
Subject: fs/exec.c:acct_arg_size(): ptl is no longer needed for add_mm_counter()
From: Oleg Nesterov <oleg@redhat.com>

acct_arg_size() takes ->page_table_lock around add_mm_counter() if
!SPLIT_RSS_COUNTING.  This is not needed after 172703b0 ("mm: delete
non-atomic mm counter implementation").

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Cc: Matt Fleming <matt.fleming@linux.intel.com>
Cc: Dave Hansen <dave@linux.vnet.ibm.com>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 fs/exec.c |    7 -------
 1 file changed, 7 deletions(-)

diff -puN fs/exec.c~fs-execc-acct_arg_size-ptl-is-no-longer-needed-for-add_mm_counter fs/exec.c
--- a/fs/exec.c~fs-execc-acct_arg_size-ptl-is-no-longer-needed-for-add_mm_counter
+++ a/fs/exec.c
@@ -181,14 +181,7 @@ static void acct_arg_size(struct linux_b
 		return;
 
 	bprm->vma_pages = pages;
-
-#ifdef SPLIT_RSS_COUNTING
-	add_mm_counter(mm, MM_ANONPAGES, diff);
-#else
-	spin_lock(&mm->page_table_lock);
 	add_mm_counter(mm, MM_ANONPAGES, diff);
-	spin_unlock(&mm->page_table_lock);
-#endif
 }
 
 static struct page *get_arg_page(struct linux_binprm *bprm, unsigned long pos,
_

Patches currently in -mm which might be from oleg@redhat.com are

xtensa-prevent-arbitrary-read-in-ptrace.patch
xtensa-prevent-arbitrary-read-in-ptrace-fix.patch
linux-next.patch
x86-do_signal-simplify-the-ts_restore_sigmask-logic.patch
ptrace-unify-show_regs-prototype.patch
ptrace-unify-show_regs-prototype-fix.patch
signals-convert-the-ia32_emulation-code-to-use-set_current_blocked.patch
signals-convert-the-x86_32-code-to-use-set_current_blocked.patch
signals-sys_ssetmask-sys_rt_sigsuspend-should-use-set_current_blocked.patch
coredump-use-task-comm-instead-of-unknown.patch
do_coredump-fix-the-ispipe-error-check.patch
fs-execc-acct_arg_size-ptl-is-no-longer-needed-for-add_mm_counter.patch
ipc-introduce-shm_rmid_forced-sysctl.patch
ipc-introduce-shm_rmid_forced-sysctl-fix-2.patch
ipc-introduce-shm_rmid_forced-sysctl-testing.patch


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2011-07-13 23:24 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-07-13 23:23 + fs-execc-acct_arg_size-ptl-is-no-longer-needed-for-add_mm_counter.patch added to -mm tree akpm

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).