* [merged] drivers-video-ssd1307fbc-fix-bit-order-bug-in-the-byte-translation-function.patch removed from -mm tree
@ 2013-01-14 20:38 akpm
0 siblings, 0 replies; only message in thread
From: akpm @ 2013-01-14 20:38 UTC (permalink / raw)
To: maxime.ripard, FlorianSchandinat, brian, gregkh, thomas,
tomi.valkeinen, mm-commits
The patch titled
Subject: drivers/video/ssd1307fb.c: fix bit order bug in the byte translation function
has been removed from the -mm tree. Its filename was
drivers-video-ssd1307fbc-fix-bit-order-bug-in-the-byte-translation-function.patch
This patch was dropped because it was merged into mainline or a subsystem tree
------------------------------------------------------
From: Maxime Ripard <maxime.ripard@free-electrons.com>
Subject: drivers/video/ssd1307fb.c: fix bit order bug in the byte translation function
This was leading to a strange behaviour when using the fbcon driver on top
of this one: the letters were in the right order, but each letter had a
vertical symmetry.
This was because the addressing was right for the byte, but the addressing
of each individual bit was inverted.
Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Brian Lilly <brian@crystalfontz.com>
Cc: Greg Kroah-Hartman <gregkh@linux-foundation.org>
Cc: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
Cc: Thomas Petazzoni <thomas@free-electrons.com>
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
drivers/video/ssd1307fb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff -puN drivers/video/ssd1307fb.c~drivers-video-ssd1307fbc-fix-bit-order-bug-in-the-byte-translation-function drivers/video/ssd1307fb.c
--- a/drivers/video/ssd1307fb.c~drivers-video-ssd1307fbc-fix-bit-order-bug-in-the-byte-translation-function
+++ a/drivers/video/ssd1307fb.c
@@ -145,8 +145,8 @@ static void ssd1307fb_update_display(str
u32 page_length = SSD1307FB_WIDTH * i;
u32 index = page_length + (SSD1307FB_WIDTH * k + j) / 8;
u8 byte = *(vmem + index);
- u8 bit = byte & (1 << (7 - (j % 8)));
- bit = bit >> (7 - (j % 8));
+ u8 bit = byte & (1 << (j % 8));
+ bit = bit >> (j % 8);
buf |= bit << k;
}
ssd1307fb_write_data(par->client, buf);
_
Patches currently in -mm which might be from maxime.ripard@free-electrons.com are
origin.patch
linux-next.patch
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2013-01-14 20:38 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-01-14 20:38 [merged] drivers-video-ssd1307fbc-fix-bit-order-bug-in-the-byte-translation-function.patch removed from -mm tree akpm
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).