* + lib-parserc-fix-up-comments-for-valid-return-values-from-match_number.patch added to -mm tree
@ 2013-01-17 23:28 akpm
0 siblings, 0 replies; only message in thread
From: akpm @ 2013-01-17 23:28 UTC (permalink / raw)
To: mm-commits; +Cc: namjae.jeon, a.sahrawat
The patch titled
Subject: lib/parser.c: fix up comments for valid return values from match_number
has been added to the -mm tree. Its filename is
lib-parserc-fix-up-comments-for-valid-return-values-from-match_number.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Namjae Jeon <namjae.jeon@samsung.com>
Subject: lib/parser.c: fix up comments for valid return values from match_number
match_number() has return values of -ENOMEM, -EINVAL and -ERANGE. So, for
all the functions calling match_number, the return value should include
these values. Fix up the comments to reflect the correct values.
Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
Signed-off-by: Amit Sahrawat <a.sahrawat@samsung.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
lib/parser.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff -puN lib/parser.c~lib-parserc-fix-up-comments-for-valid-return-values-from-match_number lib/parser.c
--- a/lib/parser.c~lib-parserc-fix-up-comments-for-valid-return-values-from-match_number
+++ a/lib/parser.c
@@ -157,7 +157,7 @@ static int match_number(substring_t *s,
*
* Description: Attempts to parse the &substring_t @s as a decimal integer. On
* success, sets @result to the integer represented by the string and returns 0.
- * Returns either -ENOMEM or -EINVAL on failure.
+ * Returns -ENOMEM, -EINVAL, or -ERANGE on failure.
*/
int match_int(substring_t *s, int *result)
{
@@ -171,7 +171,7 @@ int match_int(substring_t *s, int *resul
*
* Description: Attempts to parse the &substring_t @s as an octal integer. On
* success, sets @result to the integer represented by the string and returns
- * 0. Returns either -ENOMEM or -EINVAL on failure.
+ * 0. Returns -ENOMEM, -EINVAL, or -ERANGE on failure.
*/
int match_octal(substring_t *s, int *result)
{
@@ -185,7 +185,7 @@ int match_octal(substring_t *s, int *res
*
* Description: Attempts to parse the &substring_t @s as a hexadecimal integer.
* On success, sets @result to the integer represented by the string and
- * returns 0. Returns either -ENOMEM or -EINVAL on failure.
+ * returns 0. Returns -ENOMEM, -EINVAL, or -ERANGE on failure.
*/
int match_hex(substring_t *s, int *result)
{
_
Patches currently in -mm which might be from namjae.jeon@samsung.com are
origin.patch
linux-next.patch
lib-parserc-fix-up-comments-for-valid-return-values-from-match_number.patch
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2013-01-17 23:28 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-01-17 23:28 + lib-parserc-fix-up-comments-for-valid-return-values-from-match_number.patch added to -mm tree akpm
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).