* Re: mmotm 2013-06-27-16-36 uploaded
[not found] ` <20130628095712.120bec7036284584fd467ee2@canb.auug.org.au>
@ 2013-06-28 0:32 ` Andrew Morton
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Morton @ 2013-06-28 0:32 UTC (permalink / raw)
To: Stephen Rothwell
Cc: mm-commits, linux-kernel, linux-mm, linux-fsdevel, linux-next
On Fri, 28 Jun 2013 09:57:12 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi Andrew,
>
> On Thu, 27 Jun 2013 16:37:33 -0700 akpm@linux-foundation.org wrote:
> >
> > The mm-of-the-moment snapshot 2013-06-27-16-36 has been uploaded to
> >
> > http://www.ozlabs.org/~akpm/mmotm/
> >
> > include-linux-smph-on_each_cpu-switch-back-to-a-macro.patch
> > arch-c6x-mm-include-asm-uaccessh-to-pass-compiling.patch
> > drivers-dma-pl330c-fix-locking-in-pl330_free_chan_resources.patch
>
> Did you mean to drop these three patches from linux-next?
Nope, they should be inside the NEXT_PATCHES_START/NEXT_PATCHES_END
section, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: mmotm 2013-06-27-16-36 uploaded (wait event common)
[not found] ` <51CD1F81.4040202@infradead.org>
@ 2013-06-28 5:51 ` Andrew Morton
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Morton @ 2013-06-28 5:51 UTC (permalink / raw)
To: Randy Dunlap
Cc: mm-commits, linux-kernel, linux-mm, linux-fsdevel, linux-next,
Oleg Nesterov
On Thu, 27 Jun 2013 22:30:41 -0700 Randy Dunlap <rdunlap@infradead.org> wrote:
> On 06/27/13 16:37, akpm@linux-foundation.org wrote:
> > The mm-of-the-moment snapshot 2013-06-27-16-36 has been uploaded to
> >
> > http://www.ozlabs.org/~akpm/mmotm/
> >
> > mmotm-readme.txt says
> >
> > README for mm-of-the-moment:
> >
> > http://www.ozlabs.org/~akpm/mmotm/
> >
>
> My builds are littered with hundreds of warnings like this one:
>
> drivers/tty/tty_ioctl.c:220:6: warning: the omitted middle operand in ?: will always be 'true', suggest explicit middle operand [-Wparentheses]
>
> I guess due to this line from wait_event_common():
>
> + __ret = __wait_no_timeout(tout) ?: (tout) ?: 1;
>
Ah, sorry, I missed that. Had I noticed it, I would have spat it back
on taste grounds alone, it being unfit for human consumption.
Something like this?
--- a/include/linux/wait.h~wait-introduce-wait_event_commonwq-condition-state-timeout-fix
+++ a/include/linux/wait.h
@@ -196,7 +196,11 @@ wait_queue_head_t *bit_waitqueue(void *,
for (;;) { \
prepare_to_wait(&wq, &__wait, state); \
if (condition) { \
- __ret = __wait_no_timeout(tout) ?: __tout ?: 1; \
+ __ret = __wait_no_timeout(tout); \
+ if (!__ret) \
+ __ret = __tout; \
+ if (!__ret) \
+ __ret = 1; \
break; \
} \
\
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-06-28 5:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20130627233733.BAEB131C3BE@corp2gmr1-1.hot.corp.google.com>
[not found] ` <20130628095712.120bec7036284584fd467ee2@canb.auug.org.au>
2013-06-28 0:32 ` mmotm 2013-06-27-16-36 uploaded Andrew Morton
[not found] ` <51CD1F81.4040202@infradead.org>
2013-06-28 5:51 ` mmotm 2013-06-27-16-36 uploaded (wait event common) Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).