mm-commits.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* + loop-use-worker-per-cgroup-instead-of-kworker-fix.patch added to -mm tree
@ 2020-03-01  2:10 akpm
  0 siblings, 0 replies; only message in thread
From: akpm @ 2020-03-01  2:10 UTC (permalink / raw)
  To: dan.carpenter, mm-commits, schatzberg.dan, sfr


The patch titled
     Subject: loop: fix IS_ERR() vs NULL bugs in loop_prepare_queue()
has been added to the -mm tree.  Its filename is
     loop-use-worker-per-cgroup-instead-of-kworker-fix.patch

This patch should soon appear at
    http://ozlabs.org/~akpm/mmots/broken-out/loop-use-worker-per-cgroup-instead-of-kworker-fix.patch
and later at
    http://ozlabs.org/~akpm/mmotm/broken-out/loop-use-worker-per-cgroup-instead-of-kworker-fix.patch

Before you just go and hit "reply", please:
   a) Consider who else should be cc'ed
   b) Prefer to cc a suitable mailing list as well
   c) Ideally: find the original patch on the mailing list and do a
      reply-to-all to that, adding suitable additional cc's

*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***

The -mm tree is included into linux-next and is updated
there every 3-4 working days

------------------------------------------------------
From: Dan Carpenter <dan.carpenter@oracle.com>
Subject: loop: fix IS_ERR() vs NULL bugs in loop_prepare_queue()

The alloc_workqueue() function returns NULL on error, it never returns
error pointers.

Link: http://lkml.kernel.org/r/20200228172136.h5dvwvrg5yfywxss@kili.mountain
Fixes: 29dab2122492 ("loop: use worker per cgroup instead of kworker")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Dan Schatzberg <schatzberg.dan@gmail.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 drivers/block/loop.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/block/loop.c~loop-use-worker-per-cgroup-instead-of-kworker-fix
+++ a/drivers/block/loop.c
@@ -901,7 +901,7 @@ static int loop_prepare_queue(struct loo
 					WQ_UNBOUND | WQ_FREEZABLE |
 					WQ_MEM_RECLAIM,
 					lo->lo_number);
-	if (IS_ERR(lo->workqueue))
+	if (!lo->workqueue)
 		return -ENOMEM;
 
 	return 0;
_

Patches currently in -mm which might be from dan.carpenter@oracle.com are

loop-use-worker-per-cgroup-instead-of-kworker-fix.patch

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2020-03-01  2:10 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-01  2:10 + loop-use-worker-per-cgroup-instead-of-kworker-fix.patch added to -mm tree akpm

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).