mm-commits.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* + mm-cma-fix-null-pointer-dereference-when-cma-could-not-be-activated.patch added to -mm tree
@ 2020-06-16 19:46 akpm
  0 siblings, 0 replies; only message in thread
From: akpm @ 2020-06-16 19:46 UTC (permalink / raw)
  To: mm-commits, david, jay.xu


The patch titled
     Subject: mm/cma.c: fix NULL pointer dereference when cma could not be activated
has been added to the -mm tree.  Its filename is
     mm-cma-fix-null-pointer-dereference-when-cma-could-not-be-activated.patch

This patch should soon appear at
    http://ozlabs.org/~akpm/mmots/broken-out/mm-cma-fix-null-pointer-dereference-when-cma-could-not-be-activated.patch
and later at
    http://ozlabs.org/~akpm/mmotm/broken-out/mm-cma-fix-null-pointer-dereference-when-cma-could-not-be-activated.patch

Before you just go and hit "reply", please:
   a) Consider who else should be cc'ed
   b) Prefer to cc a suitable mailing list as well
   c) Ideally: find the original patch on the mailing list and do a
      reply-to-all to that, adding suitable additional cc's

*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***

The -mm tree is included into linux-next and is updated
there every 3-4 working days

------------------------------------------------------
From: Jianqun Xu <jay.xu@rock-chips.com>
Subject: mm/cma.c: fix NULL pointer dereference when cma could not be activated

In some case the cma area could not be activated, but the cma_alloc be
used under this case, then the kernel will crash caused by NULL pointer
dereference.

Add bitmap valid check in cma_alloc to avoid this issue.

Link: http://lkml.kernel.org/r/20200615010123.15596-1-jay.xu@rock-chips.com
Signed-off-by: Jianqun Xu <jay.xu@rock-chips.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 mm/cma.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/mm/cma.c~mm-cma-fix-null-pointer-dereference-when-cma-could-not-be-activated
+++ a/mm/cma.c
@@ -425,7 +425,7 @@ struct page *cma_alloc(struct cma *cma,
 	struct page *page = NULL;
 	int ret = -ENOMEM;
 
-	if (!cma || !cma->count)
+	if (!cma || !cma->count || !cma->bitmap)
 		return NULL;
 
 	pr_debug("%s(cma %p, count %zu, align %d)\n", __func__, (void *)cma,
_

Patches currently in -mm which might be from jay.xu@rock-chips.com are

mm-cma-fix-null-pointer-dereference-when-cma-could-not-be-activated.patch

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2020-06-16 19:46 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-16 19:46 + mm-cma-fix-null-pointer-dereference-when-cma-could-not-be-activated.patch added to -mm tree akpm

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).