* + mm-oom-show-process-exiting-information-in-__oom_kill_process.patch added to -mm tree
@ 2020-07-21 22:43 akpm
0 siblings, 0 replies; only message in thread
From: akpm @ 2020-07-21 22:43 UTC (permalink / raw)
To: cai, laoar.shao, mhocko, mm-commits, penguin-kernel, rientjes
The patch titled
Subject: mm, oom: show process exiting information in __oom_kill_process()
has been added to the -mm tree. Its filename is
mm-oom-show-process-exiting-information-in-__oom_kill_process.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/mm-oom-show-process-exiting-information-in-__oom_kill_process.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/mm-oom-show-process-exiting-information-in-__oom_kill_process.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Yafang Shao <laoar.shao@gmail.com>
Subject: mm, oom: show process exiting information in __oom_kill_process()
When the OOM killer finds a victim and tryies to kill it, if the victim is
already exiting, the task mm will be NULL and no process will be killed.
But the dump_header() has been already executed, so it will be strange to
dump so much information without killing a process. We'd better show some
helpful information to indicate why this happens.
Link: http://lkml.kernel.org/r/20200721010127.17238-1-laoar.shao@gmail.com
Suggested-by: David Rientjes <rientjes@google.com>
Signed-off-by: Yafang Shao <laoar.shao@gmail.com>
Acked-by: Michal Hocko <mhocko@suse.com>
Cc: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Cc: Qian Cai <cai@lca.pw>
Cc: David Rientjes <rientjes@google.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
mm/oom_kill.c | 2 ++
1 file changed, 2 insertions(+)
--- a/mm/oom_kill.c~mm-oom-show-process-exiting-information-in-__oom_kill_process
+++ a/mm/oom_kill.c
@@ -861,6 +861,8 @@ static void __oom_kill_process(struct ta
p = find_lock_task_mm(victim);
if (!p) {
+ pr_info("%s: OOM victim %d (%s) is already exiting. Skip killing the task\n",
+ message, task_pid_nr(victim), victim->comm);
put_task_struct(victim);
return;
} else if (victim != p) {
_
Patches currently in -mm which might be from laoar.shao@gmail.com are
mm-memcg-avoid-stale-protection-values-when-cgroup-is-above-protection.patch
memcg-oom-check-memcg-margin-for-parallel-oom.patch
mm-oom-make-the-calculation-of-oom-badness-more-accurate.patch
mm-oom-make-the-calculation-of-oom-badness-more-accurate-v3.patch
mm-oom-show-process-exiting-information-in-__oom_kill_process.patch
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-07-21 22:43 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-21 22:43 + mm-oom-show-process-exiting-information-in-__oom_kill_process.patch added to -mm tree akpm
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).