* [merged] mm-memcontrol-use-the-preferred-form-for-passing-the-size-of-a-structure-type.patch removed from -mm tree
@ 2020-10-14 21:00 akpm
0 siblings, 0 replies; only message in thread
From: akpm @ 2020-10-14 21:00 UTC (permalink / raw)
To: gustavoars, hannes, mhocko, mm-commits, vdavydov.dev
The patch titled
Subject: mm: memcontrol: use the preferred form for passing the size of a structure type
has been removed from the -mm tree. Its filename was
mm-memcontrol-use-the-preferred-form-for-passing-the-size-of-a-structure-type.patch
This patch was dropped because it was merged into mainline or a subsystem tree
------------------------------------------------------
From: "Gustavo A. R. Silva" <gustavoars@kernel.org>
Subject: mm: memcontrol: use the preferred form for passing the size of a structure type
Use the preferred form for passing the size of a structure type. The
alternative form where the structure type is spelled out hurts readability
and introduces an opportunity for a bug when the object type is changed
but the corresponding object identifier to which the sizeof operator is
applied is not.
Link: https://lkml.kernel.org/r/773e013ff2f07fe2a0b47153f14dea054c0c04f1.1596214831.git.gustavoars@kernel.org
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Acked-by: Michal Hocko <mhocko@suse.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: Vladimir Davydov <vdavydov.dev@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
mm/memcontrol.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/mm/memcontrol.c~mm-memcontrol-use-the-preferred-form-for-passing-the-size-of-a-structure-type
+++ a/mm/memcontrol.c
@@ -4264,7 +4264,7 @@ static int __mem_cgroup_usage_register_e
new->entries[size - 1].threshold = threshold;
/* Sort thresholds. Registering of new threshold isn't time-critical */
- sort(new->entries, size, sizeof(struct mem_cgroup_threshold),
+ sort(new->entries, size, sizeof(*new->entries),
compare_thresholds, NULL);
/* Find current threshold */
_
Patches currently in -mm which might be from gustavoars@kernel.org are
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-10-14 21:00 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-14 21:00 [merged] mm-memcontrol-use-the-preferred-form-for-passing-the-size-of-a-structure-type.patch removed from -mm tree akpm
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).