* + mm-hugetlb-avoid-unnecessary-hugetlb_acct_memory-call.patch added to -mm tree
@ 2021-01-17 21:23 akpm
0 siblings, 0 replies; only message in thread
From: akpm @ 2021-01-17 21:23 UTC (permalink / raw)
To: david, linmiaohe, mike.kravetz, mm-commits, osalvador
The patch titled
Subject: mm/hugetlb: avoid unnecessary hugetlb_acct_memory() call
has been added to the -mm tree. Its filename is
mm-hugetlb-avoid-unnecessary-hugetlb_acct_memory-call.patch
This patch should soon appear at
https://ozlabs.org/~akpm/mmots/broken-out/mm-hugetlb-avoid-unnecessary-hugetlb_acct_memory-call.patch
and later at
https://ozlabs.org/~akpm/mmotm/broken-out/mm-hugetlb-avoid-unnecessary-hugetlb_acct_memory-call.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Miaohe Lin <linmiaohe@huawei.com>
Subject: mm/hugetlb: avoid unnecessary hugetlb_acct_memory() call
When reservation accounting remains unchanged, hugetlb_acct_memory() will
do nothing except holding and releasing hugetlb_lock. We should avoid
this unnecessary hugetlb_lock lock/unlock cycle which is happening on
'most' hugetlb munmap operations by check delta against 0 at the beginning
of hugetlb_acct_memory.
Link: https://lkml.kernel.org/r/20210115092013.61012-1-linmiaohe@huawei.com
Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Reviewed-by: Oscar Salvador <osalvador@suse.de>
Cc: Mike Kravetz <mike.kravetz@oracle.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
mm/hugetlb.c | 3 +++
1 file changed, 3 insertions(+)
--- a/mm/hugetlb.c~mm-hugetlb-avoid-unnecessary-hugetlb_acct_memory-call
+++ a/mm/hugetlb.c
@@ -3588,6 +3588,9 @@ static int hugetlb_acct_memory(struct hs
{
int ret = -ENOMEM;
+ if (!delta)
+ return 0;
+
spin_lock(&hugetlb_lock);
/*
* When cpuset is configured, it breaks the strict hugetlb page
_
Patches currently in -mm which might be from linmiaohe@huawei.com are
mm-hugetlb-fix-potential-double-free-in-hugetlb_register_node-error-path.patch
mm-hugetlb-avoid-unnecessary-hugetlb_acct_memory-call.patch
mm-compaction-remove-duplicated-vm_bug_on_page-pagelocked.patch
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2021-01-17 21:24 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-17 21:23 + mm-hugetlb-avoid-unnecessary-hugetlb_acct_memory-call.patch added to -mm tree akpm
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).