mm-commits.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* + m68k-make-__pfn_to_phys-and-__phys_to_pfn-available-for-mmu.patch added to -mm tree
@ 2021-02-11 23:35 akpm
  0 siblings, 0 replies; only message in thread
From: akpm @ 2021-02-11 23:35 UTC (permalink / raw)
  To: mm-commits, lkp, gerg, geert, rppt


The patch titled
     Subject: m68k: make __pfn_to_phys() and __phys_to_pfn() available for !MMU
has been added to the -mm tree.  Its filename is
     m68k-make-__pfn_to_phys-and-__phys_to_pfn-available-for-mmu.patch

This patch should soon appear at
    https://ozlabs.org/~akpm/mmots/broken-out/m68k-make-__pfn_to_phys-and-__phys_to_pfn-available-for-mmu.patch
and later at
    https://ozlabs.org/~akpm/mmotm/broken-out/m68k-make-__pfn_to_phys-and-__phys_to_pfn-available-for-mmu.patch

Before you just go and hit "reply", please:
   a) Consider who else should be cc'ed
   b) Prefer to cc a suitable mailing list as well
   c) Ideally: find the original patch on the mailing list and do a
      reply-to-all to that, adding suitable additional cc's

*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***

The -mm tree is included into linux-next and is updated
there every 3-4 working days

------------------------------------------------------
From: Mike Rapoport <rppt@linux.ibm.com>
Subject: m68k: make __pfn_to_phys() and __phys_to_pfn() available for !MMU

Recent changes that obsoleted DISCONTIGMEM on m68k switched the MMU
variant to use generic definitions of __pfn_to_phys() and __phys_to_pfn(),
but missed the !MMU variant which caused a build failure:

All errors (new ones prefixed by >>):

   drivers/media/common/videobuf2/videobuf2-dma-contig.c: In function 'vb2_dc_get_userptr':
>> drivers/media/common/videobuf2/videobuf2-dma-contig.c:509:5: error: implicit declaration of function '__pfn_to_phys' [-Werror=implicit-function-declaration]
     509 |     __pfn_to_phys(nums[0]), size, buf->dma_dir, 0);
         |     ^~~~~~~~~~~~~
   cc1: some warnings being treated as errors

Enable __pfn_to_phys() and __phys_to_pfn() on !MMU builds.

Link: https://lkml.kernel.org/r/20210211232202.GS299309@linux.ibm.com
Fixes: 4bfc848e0981 ("m68k/mm: enable use of generic memory_model.h for !DISCONTIGMEM")
Signed-off-by: Mike Rapoport <rppt@linux.ibm.com>
Reported-by: kernel test robot <lkp@intel.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Greg Ungerer <gerg@linux-m68k.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 arch/m68k/include/asm/page.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/arch/m68k/include/asm/page.h~m68k-make-__pfn_to_phys-and-__phys_to_pfn-available-for-mmu
+++ a/arch/m68k/include/asm/page.h
@@ -62,7 +62,7 @@ extern unsigned long _ramend;
 #include <asm/page_no.h>
 #endif
 
-#ifdef CONFIG_DISCONTIGMEM
+#if !defined(CONFIG_MMU) || defined(CONFIG_DISCONTIGMEM)
 #define __phys_to_pfn(paddr)	((unsigned long)((paddr) >> PAGE_SHIFT))
 #define __pfn_to_phys(pfn)	PFN_PHYS(pfn)
 #endif
_

Patches currently in -mm which might be from rppt@linux.ibm.com are

m68k-make-__pfn_to_phys-and-__phys_to_pfn-available-for-mmu.patch
mm-refactor-initialization-of-struct-page-for-holes-in-memory-layout.patch


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-02-11 23:36 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-11 23:35 + m68k-make-__pfn_to_phys-and-__phys_to_pfn-available-for-mmu.patch added to -mm tree akpm

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).