From: Andrew Morton <akpm@linux-foundation.org>
To: akpm@linux-foundation.org, linux-mm@kvack.org,
mm-commits@vger.kernel.org, slyfox@gentoo.org,
torvalds@linux-foundation.org
Subject: [patch 08/14] ia64: mca: allocate early mca with GFP_ATOMIC
Date: Wed, 24 Mar 2021 21:37:38 -0700 [thread overview]
Message-ID: <20210325043738.dMGofoOUi%akpm@linux-foundation.org> (raw)
In-Reply-To: <20210324213644.bf03a529aec4ef9580e17dbc@linux-foundation.org>
From: Sergei Trofimovich <slyfox@gentoo.org>
Subject: ia64: mca: allocate early mca with GFP_ATOMIC
The sleep warning happens at early boot right at secondary CPU activation
bootup:
smp: Bringing up secondary CPUs ...
BUG: sleeping function called from invalid context at mm/page_alloc.c:4942
in_atomic(): 0, irqs_disabled(): 1, non_block: 0, pid: 0, name: swapper/1
CPU: 1 PID: 0 Comm: swapper/1 Not tainted 5.12.0-rc2-00007-g79e228d0b611-dirty #99
Call Trace:
[<a000000100014d10>] show_stack+0x90/0xc0
[<a000000101111d90>] dump_stack+0x150/0x1c0
[<a0000001000cbec0>] ___might_sleep+0x1c0/0x2a0
[<a0000001000cc040>] __might_sleep+0xa0/0x160
[<a000000100399960>] __alloc_pages_nodemask+0x1a0/0x600
[<a0000001003b71b0>] alloc_page_interleave+0x30/0x1c0
[<a0000001003b9b60>] alloc_pages_current+0x2c0/0x340
[<a00000010038c270>] __get_free_pages+0x30/0xa0
[<a000000100044730>] ia64_mca_cpu_init+0x2d0/0x3a0
[<a000000100023430>] cpu_init+0x8b0/0x1440
[<a000000100054680>] start_secondary+0x60/0x700
[<a00000010111e1d0>] start_ap+0x750/0x780
Fixed BSP b0 value from CPU 1
As I understand interrupts are not enabled yet and system has a lot of
memory. There is little chance to sleep and switch to GFP_ATOMIC should
be a no-op.
Link: https://lkml.kernel.org/r/20210315085045.204414-1-slyfox@gentoo.org
Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
arch/ia64/kernel/mca.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/arch/ia64/kernel/mca.c~ia64-mca-allocate-early-mca-with-gfp_atomic
+++ a/arch/ia64/kernel/mca.c
@@ -1824,7 +1824,7 @@ ia64_mca_cpu_init(void *cpu_data)
data = mca_bootmem();
first_time = 0;
} else
- data = (void *)__get_free_pages(GFP_KERNEL,
+ data = (void *)__get_free_pages(GFP_ATOMIC,
get_order(sz));
if (!data)
panic("Could not allocate MCA memory for cpu %d\n",
_
next prev parent reply other threads:[~2021-03-25 4:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-25 4:36 incoming Andrew Morton
2021-03-25 4:37 ` [patch 01/14] hugetlb_cgroup: fix imbalanced css_get and css_put pair for shared mappings Andrew Morton
2021-03-25 4:37 ` [patch 02/14] kasan: fix per-page tags for non-page_alloc pages Andrew Morton
2021-03-25 4:37 ` [patch 03/14] mm/mmu_notifiers: ensure range_end() is paired with range_start() Andrew Morton
2021-03-25 4:37 ` [patch 04/14] selftests/vm: fix out-of-tree build Andrew Morton
2021-03-25 4:37 ` [patch 05/14] z3fold: prevent reclaim/free race for headless pages Andrew Morton
2021-03-25 4:37 ` [patch 06/14] squashfs: fix inode lookup sanity checks Andrew Morton
2021-03-25 4:37 ` [patch 07/14] squashfs: fix xattr id and id " Andrew Morton
2021-03-25 4:37 ` Andrew Morton [this message]
2021-03-25 4:37 ` [patch 09/14] ia64: fix format strings for err_inject Andrew Morton
2021-03-25 4:37 ` [patch 10/14] gcov: fix clang-11+ support Andrew Morton
2021-03-25 4:37 ` [patch 11/14] kfence: make compatible with kmemleak Andrew Morton
2021-03-25 4:37 ` [patch 12/14] mm: memblock: fix section mismatch warning again Andrew Morton
2021-03-25 4:37 ` [patch 13/14] mm/highmem: fix CONFIG_DEBUG_KMAP_LOCAL_FORCE_MAP Andrew Morton
2021-03-25 4:37 ` [patch 14/14] mailmap: update Andrey Konovalov's email address Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210325043738.dMGofoOUi%akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mm-commits@vger.kernel.org \
--cc=slyfox@gentoo.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).