* + lib-percpu_counter-tame-kernel-doc-compile-warning.patch added to -mm tree
@ 2021-04-06 2:22 akpm
0 siblings, 0 replies; only message in thread
From: akpm @ 2021-04-06 2:22 UTC (permalink / raw)
To: alexs, mm-commits, nborisov, swboyd
The patch titled
Subject: lib/percpu_counter: tame kernel-doc compile warning
has been added to the -mm tree. Its filename is
lib-percpu_counter-tame-kernel-doc-compile-warning.patch
This patch should soon appear at
https://ozlabs.org/~akpm/mmots/broken-out/lib-percpu_counter-tame-kernel-doc-compile-warning.patch
and later at
https://ozlabs.org/~akpm/mmotm/broken-out/lib-percpu_counter-tame-kernel-doc-compile-warning.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Alex Shi <alexs@kernel.org>
Subject: lib/percpu_counter: tame kernel-doc compile warning
commit 3e8f399da490 ("writeback: rework wb_[dec|inc]_stat family of
functions") add some function description of percpu_counter_add_batch.
but the double '*' in comments means a kernel-doc format comment which
isn't right.
Since the whole file of lib/percpu_counter.c has no any other kernel-doc
format comments, we'd better to remove this incomplete one to tame the
kernel-doc warning:
lib/percpu_counter.c:83: warning: Function parameter or member 'fbc' not described in 'percpu_counter_add_batch'
lib/percpu_counter.c:83: warning: Function parameter or member 'amount' not described in 'percpu_counter_add_batch'
lib/percpu_counter.c:83: warning: Function parameter or member 'batch' not described in 'percpu_counter_add_batch'
Link: https://lkml.kernel.org/r/20210405135505.132446-1-alexs@kernel.org
Signed-off-by: Alex Shi <alexs@kernel.org>
Cc: Nikolay Borisov <nborisov@suse.com>
Cc: Stephen Boyd <swboyd@chromium.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
lib/percpu_counter.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/lib/percpu_counter.c~lib-percpu_counter-tame-kernel-doc-compile-warning
+++ a/lib/percpu_counter.c
@@ -72,7 +72,7 @@ void percpu_counter_set(struct percpu_co
}
EXPORT_SYMBOL(percpu_counter_set);
-/**
+/*
* This function is both preempt and irq safe. The former is due to explicit
* preemption disable. The latter is guaranteed by the fact that the slow path
* is explicitly protected by an irq-safe spinlock whereas the fast patch uses
_
Patches currently in -mm which might be from alexs@kernel.org are
lib-percpu_counter-tame-kernel-doc-compile-warning.patch
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2021-04-06 2:22 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-06 2:22 + lib-percpu_counter-tame-kernel-doc-compile-warning.patch added to -mm tree akpm
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).