mm-commits.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* + makefile-extend-32b-aligned-debug-option-to-64b-aligned.patch added to -mm tree
@ 2021-05-09  3:20 akpm
  0 siblings, 0 replies; only message in thread
From: akpm @ 2021-05-09  3:20 UTC (permalink / raw)
  To: ak, andi.kleen, andriy.shevchenko, feng.tang, masahiroy,
	michal.lkml, mm-commits, tglx, ying.huang


The patch titled
     Subject: Makefile: extend 32B aligned debug option to 64B aligned
has been added to the -mm tree.  Its filename is
     makefile-extend-32b-aligned-debug-option-to-64b-aligned.patch

This patch should soon appear at
    https://ozlabs.org/~akpm/mmots/broken-out/makefile-extend-32b-aligned-debug-option-to-64b-aligned.patch
and later at
    https://ozlabs.org/~akpm/mmotm/broken-out/makefile-extend-32b-aligned-debug-option-to-64b-aligned.patch

Before you just go and hit "reply", please:
   a) Consider who else should be cc'ed
   b) Prefer to cc a suitable mailing list as well
   c) Ideally: find the original patch on the mailing list and do a
      reply-to-all to that, adding suitable additional cc's

*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***

The -mm tree is included into linux-next and is updated
there every 3-4 working days

------------------------------------------------------
From: Feng Tang <feng.tang@intel.com>
Subject: Makefile: extend 32B aligned debug option to 64B aligned

commit 09c60546f04f ("./Makefile: add debug option to enable function
aligned on 32 bytes") was introduced to help debugging strange kernel
performance changes caused by code alignment change.

Recently we found 2 similar cases [1][2] caused by code-alignment changes,
which can only be identified by forcing 64 bytes aligned for all
functions.

Originally, 32 bytes was used mainly for not wasting too much text space,
but this option is only for debug anyway where text space is not a big
concern.  So extend the alignment to 64 bytes to cover more similar cases.

[1].https://lore.kernel.org/lkml/20210427090013.GG32408@xsang-OptiPlex-9020/
[2].https://lore.kernel.org/lkml/20210420030837.GB31773@xsang-OptiPlex-9020/
Link: https://lkml.kernel.org/r/1620286499-40999-1-git-send-email-feng.tang@intel.com
Signed-off-by: Feng Tang <feng.tang@intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Masahiro Yamada <masahiroy@kernel.org>
Cc: Michal Marek <michal.lkml@markovi.net>
Cc: Andi Kleen <andi.kleen@intel.com>
Cc: Huang Ying <ying.huang@intel.com>
Cc: Andy Shevchenko <andriy.shevchenko@intel.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 Makefile          |    4 ++--
 lib/Kconfig.debug |    4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

--- a/lib/Kconfig.debug~makefile-extend-32b-aligned-debug-option-to-64b-aligned
+++ a/lib/Kconfig.debug
@@ -400,8 +400,8 @@ config SECTION_MISMATCH_WARN_ONLY
 
 	  If unsure, say Y.
 
-config DEBUG_FORCE_FUNCTION_ALIGN_32B
-	bool "Force all function address 32B aligned" if EXPERT
+config DEBUG_FORCE_FUNCTION_ALIGN_64B
+	bool "Force all function address 64B aligned" if EXPERT
 	help
 	  There are cases that a commit from one domain changes the function
 	  address alignment of other domains, and cause magic performance
--- a/Makefile~makefile-extend-32b-aligned-debug-option-to-64b-aligned
+++ a/Makefile
@@ -953,8 +953,8 @@ KBUILD_CFLAGS	+= $(CC_FLAGS_CFI)
 export CC_FLAGS_CFI
 endif
 
-ifdef CONFIG_DEBUG_FORCE_FUNCTION_ALIGN_32B
-KBUILD_CFLAGS += -falign-functions=32
+ifdef CONFIG_DEBUG_FORCE_FUNCTION_ALIGN_64B
+KBUILD_CFLAGS += -falign-functions=64
 endif
 
 # arch Makefile may override CC so keep this after arch Makefile is included
_

Patches currently in -mm which might be from feng.tang@intel.com are

makefile-extend-32b-aligned-debug-option-to-64b-aligned.patch


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-05-09  3:20 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-09  3:20 + makefile-extend-32b-aligned-debug-option-to-64b-aligned.patch added to -mm tree akpm

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).