* + mm-page_alloc-dump-migrate-failed-pages-only-at-ebusy.patch added to -mm tree
@ 2021-05-25 0:03 akpm
0 siblings, 0 replies; only message in thread
From: akpm @ 2021-05-25 0:03 UTC (permalink / raw)
To: david, joaodias, mhocko, minchan, mm-commits, surenb
The patch titled
Subject: mm: page_alloc: dump migrate-failed pages only at -EBUSY
has been added to the -mm tree. Its filename is
mm-page_alloc-dump-migrate-failed-pages-only-at-ebusy.patch
This patch should soon appear at
https://ozlabs.org/~akpm/mmots/broken-out/mm-page_alloc-dump-migrate-failed-pages-only-at-ebusy.patch
and later at
https://ozlabs.org/~akpm/mmotm/broken-out/mm-page_alloc-dump-migrate-failed-pages-only-at-ebusy.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Minchan Kim <minchan@kernel.org>
Subject: mm: page_alloc: dump migrate-failed pages only at -EBUSY
alloc_contig_dump_pages() aims for helping debugging page migration
failure by elevated page refcount compared to expected_count. (for the
detail, please look at migrate_page_move_mapping)
However, -ENOMEM is just the case that system is under memory pressure
state, not relevant with page refcount at all. Thus, the dumping page
list is not helpful for the debugging point of view.
Link: https://lkml.kernel.org/r/YKa2Wyo9xqIErpfa@google.com
Signed-off-by: Minchan Kim <minchan@kernel.org>
Reviewed-by: David Hildenbrand <david@redhat.com>
Cc: Suren Baghdasaryan <surenb@google.com>
Cc: John Dias <joaodias@google.com>
Cc: Michal Hocko <mhocko@suse.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
mm/page_alloc.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--- a/mm/page_alloc.c~mm-page_alloc-dump-migrate-failed-pages-only-at-ebusy
+++ a/mm/page_alloc.c
@@ -8763,7 +8763,8 @@ static int __alloc_contig_migrate_range(
lru_cache_enable();
if (ret < 0) {
- alloc_contig_dump_pages(&cc->migratepages);
+ if (ret == -EBUSY)
+ alloc_contig_dump_pages(&cc->migratepages);
putback_movable_pages(&cc->migratepages);
return ret;
}
_
Patches currently in -mm which might be from minchan@kernel.org are
mm-page_alloc-dump-migrate-failed-pages-only-at-ebusy.patch
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2021-05-25 0:04 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-25 0:03 + mm-page_alloc-dump-migrate-failed-pages-only-at-ebusy.patch added to -mm tree akpm
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).