From: akpm@linux-foundation.org
To: code@tyhicks.com, hch@lst.de, mm-commits@vger.kernel.org,
willy@infradead.org
Subject: [folded-merged] mm-require-set_page_dirty-to-be-explicitly-wire-up-fix.patch removed from -mm tree
Date: Mon, 28 Jun 2021 17:19:27 -0700 [thread overview]
Message-ID: <20210629001927.zgEmNYixL%akpm@linux-foundation.org> (raw)
The patch titled
Subject: ecryptfs: add a ->set_page_dirty cludge
has been removed from the -mm tree. Its filename was
mm-require-set_page_dirty-to-be-explicitly-wire-up-fix.patch
This patch was dropped because it was folded into mm-require-set_page_dirty-to-be-explicitly-wire-up.patch
------------------------------------------------------
From: Christoph Hellwig <hch@lst.de>
Subject: ecryptfs: add a ->set_page_dirty cludge
"fix" ecryptfs to work the same as before the recent change to the
behavior without a ->set_page_dirty method.
Link: https://lkml.kernel.org/r/20210624125250.536369-1-hch@lst.de
Signed-off-by: Christoph Hellwig <hch@lst.de>
Acked-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Cc: Tyler Hicks <code@tyhicks.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
fs/ecryptfs/mmap.c | 13 +++++++++++++
1 file changed, 13 insertions(+)
--- a/fs/ecryptfs/mmap.c~mm-require-set_page_dirty-to-be-explicitly-wire-up-fix
+++ a/fs/ecryptfs/mmap.c
@@ -533,7 +533,20 @@ static sector_t ecryptfs_bmap(struct add
return block;
}
+#include <linux/buffer_head.h>
+
const struct address_space_operations ecryptfs_aops = {
+ /*
+ * XXX: This is pretty broken for multiple reasons: ecryptfs does not
+ * actually use buffer_heads, and ecryptfs will crash without
+ * CONFIG_BLOCK. But it matches the behavior before the default for
+ * address_space_operations without the ->set_page_dirty method was
+ * cleaned up, so this is the best we can do without maintainer
+ * feedback.
+ */
+#ifdef CONFIG_BLOCK
+ .set_page_dirty = __set_page_dirty_buffers,
+#endif
.writepage = ecryptfs_writepage,
.readpage = ecryptfs_readpage,
.write_begin = ecryptfs_write_begin,
_
Patches currently in -mm which might be from hch@lst.de are
fs-unexport-__set_page_dirty.patch
fs-move-ramfs_aops-to-libfs.patch
mm-require-set_page_dirty-to-be-explicitly-wire-up.patch
reply other threads:[~2021-06-29 0:19 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210629001927.zgEmNYixL%akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=code@tyhicks.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mm-commits@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).