mm-commits.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [folded-merged] mm-require-set_page_dirty-to-be-explicitly-wire-up-fix.patch removed from -mm tree
@ 2021-06-29  0:19 akpm
  0 siblings, 0 replies; only message in thread
From: akpm @ 2021-06-29  0:19 UTC (permalink / raw)
  To: code, hch, mm-commits, willy


The patch titled
     Subject: ecryptfs: add a ->set_page_dirty cludge
has been removed from the -mm tree.  Its filename was
     mm-require-set_page_dirty-to-be-explicitly-wire-up-fix.patch

This patch was dropped because it was folded into mm-require-set_page_dirty-to-be-explicitly-wire-up.patch

------------------------------------------------------
From: Christoph Hellwig <hch@lst.de>
Subject: ecryptfs: add a ->set_page_dirty cludge

"fix" ecryptfs to work the same as before the recent change to the
behavior without a ->set_page_dirty method.

Link: https://lkml.kernel.org/r/20210624125250.536369-1-hch@lst.de
Signed-off-by: Christoph Hellwig <hch@lst.de>
Acked-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Cc: Tyler Hicks <code@tyhicks.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 fs/ecryptfs/mmap.c |   13 +++++++++++++
 1 file changed, 13 insertions(+)

--- a/fs/ecryptfs/mmap.c~mm-require-set_page_dirty-to-be-explicitly-wire-up-fix
+++ a/fs/ecryptfs/mmap.c
@@ -533,7 +533,20 @@ static sector_t ecryptfs_bmap(struct add
 	return block;
 }
 
+#include <linux/buffer_head.h>
+
 const struct address_space_operations ecryptfs_aops = {
+	/*
+	 * XXX: This is pretty broken for multiple reasons: ecryptfs does not
+	 * actually use buffer_heads, and ecryptfs will crash without
+	 * CONFIG_BLOCK.  But it matches the behavior before the default for
+	 * address_space_operations without the ->set_page_dirty method was
+	 * cleaned up, so this is the best we can do without maintainer
+	 * feedback.
+	 */
+#ifdef CONFIG_BLOCK
+	.set_page_dirty = __set_page_dirty_buffers,
+#endif
 	.writepage = ecryptfs_writepage,
 	.readpage = ecryptfs_readpage,
 	.write_begin = ecryptfs_write_begin,
_

Patches currently in -mm which might be from hch@lst.de are

fs-unexport-__set_page_dirty.patch
fs-move-ramfs_aops-to-libfs.patch
mm-require-set_page_dirty-to-be-explicitly-wire-up.patch


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-06-29  0:19 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-29  0:19 [folded-merged] mm-require-set_page_dirty-to-be-explicitly-wire-up-fix.patch removed from -mm tree akpm

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).