mm-commits.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* + add-fat-messages-to-printk-index-checkpatch-fixes.patch added to -mm tree
@ 2022-03-31  1:42 Andrew Morton
  0 siblings, 0 replies; only message in thread
From: Andrew Morton @ 2022-03-31  1:42 UTC (permalink / raw)
  To: mm-commits, jof, hirofumi, akpm, akpm


The patch titled
     Subject: add-fat-messages-to-printk-index-checkpatch-fixes
has been added to the -mm tree.  Its filename is
     add-fat-messages-to-printk-index-checkpatch-fixes.patch

This patch should soon appear at
    https://ozlabs.org/~akpm/mmots/broken-out/add-fat-messages-to-printk-index-checkpatch-fixes.patch
and later at
    https://ozlabs.org/~akpm/mmotm/broken-out/add-fat-messages-to-printk-index-checkpatch-fixes.patch

Before you just go and hit "reply", please:
   a) Consider who else should be cc'ed
   b) Prefer to cc a suitable mailing list as well
   c) Ideally: find the original patch on the mailing list and do a
      reply-to-all to that, adding suitable additional cc's

*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***

The -mm tree is included into linux-next and is updated
there every 3-4 working days

------------------------------------------------------
From: Andrew Morton <akpm@linux-foundation.org>
Subject: add-fat-messages-to-printk-index-checkpatch-fixes

WARNING: 'changable' may be misspelled - perhaps 'changeable'?
#7: 
changable ad-hoc format strings (as they always have; no change of
^^^^^^^^^

ERROR: space required before the open parenthesis '('
#41: FILE: fs/fat/fat.h:442:
+} while(0)

total: 1 errors, 1 warnings, 43 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

./patches/add-fat-messages-to-printk-index.patch has style problems, please review.

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

Please run checkpatch prior to sending patches

Cc: Jonathan Lassoff <jof@thejof.com>
Cc: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 fs/fat/fat.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/fs/fat/fat.h~add-fat-messages-to-printk-index-checkpatch-fixes
+++ a/fs/fat/fat.h
@@ -439,7 +439,7 @@ void __fat_fs_error(struct super_block *
 do {									\
 	printk_index_subsys_emit(FAT_PRINTK_PREFIX, level, fmt, ##args);\
 	_fat_msg(sb, level, fmt, ##args);				\
-} while(0)
+} while (0)
 __printf(3, 4) __cold
 void _fat_msg(struct super_block *sb, const char *level, const char *fmt, ...);
 #define fat_msg_ratelimit(sb, level, fmt, args...)	\
_

Patches currently in -mm which might be from akpm@linux-foundation.org are

mm.patch
mm-shmem-make-shmem_init-return-void-fix.patch
ksm-count-ksm-merging-pages-for-each-process-fix.patch
mm-memory_hotplug-refactor-hotadd_init_pgdat-and-try_online_node-checkpatch-fixes.patch
proc-fix-dentry-inode-overinstantiating-under-proc-pid-net-checkpatch-fixes.patch
add-fat-messages-to-printk-index-checkpatch-fixes.patch
linux-next-rejects.patch
mm-oom_killc-fix-vm_oom_kill_table-ifdeffery.patch
mutex-subsystem-synchro-test-module-fix.patch
kernel-forkc-export-kernel_thread-to-modules.patch


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-03-31  1:42 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-31  1:42 + add-fat-messages-to-printk-index-checkpatch-fixes.patch added to -mm tree Andrew Morton

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).