* + mm-hwpoison-put-page-in-already-hwpoisoned-case-with-mf_count_increased.patch added to -mm tree
@ 2022-04-08 23:46 Andrew Morton
0 siblings, 0 replies; only message in thread
From: Andrew Morton @ 2022-04-08 23:46 UTC (permalink / raw)
To: mm-commits, shy828301, mike.kravetz, linmiaohe, dan.carpenter,
naoya.horiguchi, akpm
The patch titled
Subject: mm/hwpoison: put page in already hwpoisoned case with MF_COUNT_INCREASED
has been added to the -mm tree. Its filename is
mm-hwpoison-put-page-in-already-hwpoisoned-case-with-mf_count_increased.patch
This patch should soon appear at
https://ozlabs.org/~akpm/mmots/broken-out/mm-hwpoison-put-page-in-already-hwpoisoned-case-with-mf_count_increased.patch
and later at
https://ozlabs.org/~akpm/mmotm/broken-out/mm-hwpoison-put-page-in-already-hwpoisoned-case-with-mf_count_increased.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Naoya Horiguchi <naoya.horiguchi@nec.com>
Subject: mm/hwpoison: put page in already hwpoisoned case with MF_COUNT_INCREASED
In already hwpoisoned case, memory_failure() is supposed to return with
releasing the page refcount taken for error handling. But currently the
refcount is not released when called with MF_COUNT_INCREASED, which makes
page refcount inconsistent. This should be rare and non-critical, but it
might be inconvenient in testing (unpoison doesn't work).
Link: https://lkml.kernel.org/r/20220408135323.1559401-3-naoya.horiguchi@linux.dev
Signed-off-by: Naoya Horiguchi <naoya.horiguchi@nec.com>
Suggested-by: Miaohe Lin <linmiaohe@huawei.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Mike Kravetz <mike.kravetz@oracle.com>
Cc: Yang Shi <shy828301@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
mm/memory-failure.c | 2 ++
1 file changed, 2 insertions(+)
--- a/mm/memory-failure.c~mm-hwpoison-put-page-in-already-hwpoisoned-case-with-mf_count_increased
+++ a/mm/memory-failure.c
@@ -1809,6 +1809,8 @@ try_again:
res = -EHWPOISON;
if (flags & MF_ACTION_REQUIRED)
res = kill_accessing_process(current, pfn, flags);
+ if (flags & MF_COUNT_INCREASED)
+ put_page(p);
goto unlock_mutex;
}
_
Patches currently in -mm which might be from naoya.horiguchi@nec.com are
mm-hwpoison-fix-race-between-hugetlb-free-demotion-and-memory_failure_hugetlb.patch
mm-hwpoison-put-page-in-already-hwpoisoned-case-with-mf_count_increased.patch
revert-mm-memory-failurec-fix-race-with-changing-page-compound-again.patch
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-04-08 23:46 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-08 23:46 + mm-hwpoison-put-page-in-already-hwpoisoned-case-with-mf_count_increased.patch added to -mm tree Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).